•  

Comment Results

Review Name Created Custom Fields Content
DIALIN-DEN-4690-1 07 Oct 2020

This function name could be clearer

Please remove the v prefix. It doesn't add any information

UI-DEN-4690-1 07 Oct 2020

RESOLVED

UI-DEN-4438-1 25 Aug 2020

Absolutely,
I'm doing it incrementally and slowly to not to make the code reviews harder and confusing git.
I did for so many and this file will get its turn soon.

HD-DEN-7347-1 07 Apr 2021

Removed.

UI-DEN-4438-1 25 Aug 2020

removed extra line.

DG-DEN-5855-1 10 Dec 2020

RESOLVED in CODE WLA

UI-DEN-4438-1 25 Aug 2020

removed extra line.
And put the same reply for the other related comments.

UI-DEN-3605-4 05 Oct 2020

Done, will post update to this review soon

UI-DEN-4964-1 30 Oct 2020

RESOLVED

HD-DEN-4308-3 31 Aug 2020

You are using this step change #define for step size (as name implies) but also for a maximum delta from your target position. Though they share the same value at this time (1000), they are two different things.

HD-DEN-4211-1 31 Aug 2020

RESOLVED in CODE WALKTHROUGH.

DIALIN-DEN-4640-1 30 Oct 2020

This extra comma will cause an issue with the publish decorator

HD-DEN-4308-3 01 Sep 2020

Done

DG-DEN-3504-1 30 Oct 2020

The function has been moved upward in order defined in the header Comm.h.

HD-DEN-4211-1 14 Sep 2020

RESOLVED in CODE WALKTHROUGH.

DIALIN-DEN-4308-1 01 Oct 2020

Done

HD-DEN-4308-3 22 Sep 2020

Done

DG-DEN-5855-1 10 Dec 2020

RESOLVED in CODE WALKTHROUGH.

DIALIN-DEN-4308-1 02 Oct 2020

RESOLVED

HD-DEN-4308-3 22 Sep 2020

Do you mean to use the state enum instead of the boolean variable that I defined?

HD-DEN-4308-3 22 Sep 2020

This enum is used by the clients to request any of the positions. This enum is used in setValvePosition function.

DIALIN-DEN-3421-1 01 Dec 2020

How come all gain offsets were changed to zero? This sensor behavior is physically unlikely to happen in the field.

HD-DEN-4308-3 05 Oct 2020

Why does this else get commented out?

HD-DEN-5053-1 22 Sep 2020

Suggest replacing pressure and occlusion with air trap.

HD-DEN-4308-3 23 Sep 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-4308-3 23 Sep 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-4308-3 22 Sep 2020

s/w fault is appropriate here.

HD-DEN-4308-3 22 Sep 2020

This condition warrants a comment since it is very similar to the first condition.

HD-DEN-4308-3 22 Sep 2020

Why are we not assigning this directly in the switch statement? Why did we need the local state?

UI-DEN-3605-4 07 Oct 2020

RESOLVED

HD-DEN-4308-3 23 Sep 2020

Remove ///< if you use /// above.

UI-DEN-3605-4 05 Oct 2020

It will be reviewed later.
RESOLVED.

UI-DEN-3605-4 05 Oct 2020

Thanks,
I couldn't find a requirement for hiding the scrollbars and also don't see any reason why we need to do that.
It's always good to see the scrollbars if the components are not fit in the view port of the container, so the user immediately will catch that there are more to take care of.

UI-DEN-3605-4 05 Oct 2020

RESOLVED

UI-DEN-3605-4 30 Sep 2020

put id: in front of parenthesis.
Please apply this everywhere.

UI-DEN-3605-4 30 Sep 2020

Please always put the
id: <name of the object>
in front of the
<Type> {
to be able to find object easily.
I saw this in other codes but since it was the first line after { I didn't put any comment.
So please follow this rule every where.

HD-DEN-4308-3 05 Oct 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-4308-3 05 Oct 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-4308-3 05 Oct 2020

This should be public rather than private.

UI-DEN-3605-4 06 Oct 2020

Done

DIALIN-DEN-4640-1 06 Oct 2020

Just curious, what was the reason for the deletion?

DIALIN-DEN-4690-1 06 Oct 2020

fixed

UI-DEN-3605-4 06 Oct 2020

Please put a short description of your component and explain what it does and where it can be used.
Since it is a specific or compound component and is not a general component like a just a Slider or Progressbar, it helps to understand the use case of the component.

DIALIN-DEN-4690-1 07 Oct 2020

RESOLVED.

UI-DEN-3605-4 07 Oct 2020

Please put "done" when the code is pushed.
When an email is sent to the reviewer it is assumed that there is something to review but putting a "done" and "will be updated" is not something that can be reviewed.

UI-DEN-4690-1 07 Oct 2020

RESOLVED

UI-DEN-4690-1 07 Oct 2020

RESOLVED

UI-DEN-3605-4 07 Oct 2020

Done, I don't know why, but crucible created a duplicate file http://dvm-linux02:8060/cru/UI-DEN-3605-4#CFR-16961

UI-DEN-4690-1 07 Oct 2020

It is all documentations and Doxygenization.
If you see otherwise is because the file names changed and the code review takes it as a new file and marks all the file content as to be reviewed.
Let me know if otherwise.

UI-DEN-3605-4 07 Oct 2020

I don't know why, but crucible creates duplicate files sometimes. Please check on the left hand pane and see the change(s) in the duplicate files.