Target weight can be anything - comes from the HD. For calibration, I think we should be using a #define for what we think the fluid weight would be when reservoir drained to end of drain straw.
I removed all of these and just tested on the target and the performance appears to be the same.
The cpp code is in control of the business logic of when to enable/disable the continue button. Making the qml in control divides responsibility between the cpp code and qml as the cpp code needs to enable / disable it when we get a response back from FW.
The cpp code keeps track of which variable has been set and which hasn't.
Here are a couple of relevant requirements:
SRSUI 551: The "Continue" button shall be only enabled after all the "Treatment Parameters" has been set by user. SRSUI 560: The "Create Treatment" screen shall display the "Treatment Parameters" values as has been set after user sets the value of each "Treatment Parameter".
Please change Tr to Treatment. It is not clear if used separately from the other ones. The clear meaning is preferred. Please align afterward. Apply to all the others, please.
Should this only be incremented if major travel progress is not made? As it's coded, I think you're only giving the entire 1,000 step advancement 20 ms to complete.
What are these two extra object names? If it's that much necessary can be moved inside the component implementation. You have the object name and the postfix string is a constant string.
This assumes we will be at position zero when we get here. Maybe true if first homing, but if we get here from idle, it may not be the case. I think you should set this target to current position + step change.
all the other cases are like each other and consistent why this implementation is different?
All : vPayload = Format::fromVariant(vData); LOG_EVENT(AdjustSalineRequestData::toString(vData));
This : vPayload = Format::fromVariant(vData); // -------> Why data passed to this method instead of toString? TreatmentParameters params; params.fromVariantList(vData); // -------> why do you have this here? LOG_EVENT("GOT HERE"); LOG_EVENT(params.toString()); // -------> same as first comment....
Absolutely, I'm doing it incrementally and slowly to not to make the code reviews harder and confusing git. I did for so many and this file will get its turn soon.
You are running release
CR4.8.14
FE4.8.14
(20240111091859 2024-01-11 09:20),
please report your release number when reporting bugs.
