•  

Comment Results

Review Name Created Custom Fields Content
DIALIN-DEN-4211-1 08 Sep 2020

Done

DG-DEN-4793-1 04 Sep 2020

Insert blank line between declarations and function code.

UI-DEN-3605-4 08 Sep 2020

The MModel.h has been included in the MessageInterpreter.h which has the models #include to the MTreatmentParameters.
Please remove this duplicate inclusion.
Please follow the code structure and please notice that there is no other model included here and has to be a reason for that.

DG-DEN-4793-1 08 Sep 2020

RESOLVED in CODE WALKTHROUGH.

DIALIN-DEN-4690-1 08 Sep 2020

Removed.

DIALIN-DEN-4211-1 08 Sep 2020

This is an old formatted copyright. The new copyright format will be inserted into the file automatically by Bamboo.

DIALIN-DEN-4211-1 08 Sep 2020

This is an old formatted copyright. The new copyright format will be inserted into the file automatically by Bamboo.

UI-DEN-4690-1 08 Sep 2020

Changed the file name so Doxygen is not documenting it.
Doxygen is looking for .h/.cpp/.qml only.

UI-DEN-4690-1 08 Sep 2020

RESOLVED.

UI-DEN-4690-1 08 Sep 2020

RESOLVED.

UI-DEN-4690-1 08 Sep 2020

Remove extra line.

UI-DEN-4690-1 08 Sep 2020

Interesting !!!
This file doesn't even exist anymore and has been replaced by Logger.h
I don't see it in my folder and don't see it in my git log.
Don't know why has been shown here.

UI-DEN-4690-1 08 Sep 2020

This file has been replaced by its Camel Case version.
Not sure why it shows up here!

UI-DEN-4690-1 08 Sep 2020

this file has been removed.
don't know why it shows up here!

UI-DEN-4690-1 08 Sep 2020

This file has been removed.
Not sure why is showing up here!

UI-DEN-4690-1 08 Sep 2020

This file has been removed.
Not sure why is showing up here!

UI-DEN-4690-1 08 Sep 2020

Removed

UI-DEN-4690-1 08 Sep 2020

This file replaced with its Camel Case version.

UI-DEN-4690-1 08 Sep 2020

This file is removed with its Camel Case name version.

UI-DEN-4690-1 08 Sep 2020

This file is replaced with its Camel Case name version.

UI-DEN-4690-1 08 Sep 2020

This file is replaced with its Camel Case name version.

UI-DEN-4690-1 08 Sep 2020

This file is replaced with its Camel Case name version.

UI-DEN-4690-1 08 Sep 2020

Remove extra line.

UI-DEN-4690-1 08 Sep 2020

Remove extra line.

UI-DEN-4690-1 08 Sep 2020

Remove extra line.

UI-DEN-3605-4 14 Sep 2020

As per our conversation today, due to the design changes with MAbstract.h and MModel.h that were merged to master on Aug. 31st, the create treatment models will be updated to subclass these parent classes.
This work is going to be tracked in this ticket: http://dvm-linux02:8080/browse/DEN-4981

HD-DEN-4308-3 22 Sep 2020

Combine into one line, it does not seem to exceed the word count limit yet.

HD-DEN-5053-1 22 Sep 2020

Done.

HD-DEN-5053-1 22 Sep 2020

Change Self test to Self-test for consistency.

HD-DEN-5053-1 22 Sep 2020

Incorrect description. Should remove this since there is another inlined doxygen comment for this define.

HD-DEN-4308-3 23 Sep 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-4308-3 23 Sep 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-4308-3 23 Sep 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-4308-3 23 Sep 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-4308-3 22 Sep 2020

Should this only be incremented if major travel progress is not being made? (same issue as function above)

HD-DEN-4308-3 23 Sep 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-4308-3 23 Sep 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-4308-3 23 Sep 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-4308-3 04 Sep 2020

Use U32 instead of enum type VALVE_POSITION_T to ensure memcpy will only copy to this variable.

HD-DEN-4308-3 04 Sep 2020

Suggest renaming variable to something meaningful like valveState.
Also, change type to U32 as compiler may not consider an enum type like OPN_CLS_STATE_T as 32-bit and so memcpy may corrupt data beyond the enum. You can cast this valveState as a OPN_CLS_STATE_T when using in function call below.

HD-DEN-4308-3 23 Sep 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-4308-3 23 Sep 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-4308-3 23 Sep 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-4308-3 23 Sep 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-4308-3 23 Sep 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-4308-3 27 Aug 2020

I think these are both reported positions (as comments infer) and commanded positions. Recommend making comments more broad to accommodate both uses.

HD-DEN-4308-3 02 Sep 2020

Done

DG-DEN-5855-1 10 Dec 2020

Do we need the conversion from U16 to S32? If we do, suggest combine into one line and remove roFlow variable.

DIALIN-DEN-4308-1 02 Oct 2020

RESOLVED

UI-DEN-4690-1 08 Sep 2020

Changed the file name so Doxygen is not documenting it.
Doxygen is looking for .h/.cpp/.qml only.