•  

Comment Results

Review Name Created Custom Fields Content
UI-DEN-4690-1 08 Sep 2020

This file is replaced with its Camel Case name version.

UI-DEN-4690-1 08 Sep 2020

Why file name ends in .h._?

HD-DEN-4308-3 04 Sep 2020

Use U32. VALVE_T may not be 32 bits.

HD-DEN-4308-3 27 Aug 2020

Do we need to check whether valve has been homed? I thought we couldn't get to idle state unless homing is completed.

HD-DEN-4308-3 27 Aug 2020

No copyright?

HD-DEN-4211-1 26 Aug 2020

Replace # with number.

HD-DEN-4211-1 26 Aug 2020

Consider changing 0 to FALSE.

DIALIN-DEN-4211-1 27 Aug 2020

The logger should be passed to the constructor so a script writer can turn the logger and any debug messages on or off

HD-DEN-4211-1 02 Sep 2020

Result no longer same.

DIALIN-DEN-4308-1 01 Oct 2020

Done

UI-DEN-4690-1 08 Sep 2020

Changed the file name so Doxygen is not documenting it.
Doxygen is looking for .h/.cpp/.qml only.

DIALIN-DEN-4308-1 01 Oct 2020

RESOLVED

DG-DEN-5855-1 10 Dec 2020

RESOLVED in CODE WALKTHROUGH.

DIALIN-DEN-4690-1 05 Oct 2020

Added

UI-DEN-3605-4 30 Sep 2020

http://192.168.10.132:8060/cru/UI-DEN-3605-4#c5090

DIALIN-DEN-4640-1 30 Oct 2020

RESOLVED

DG-DEN-3504-1 30 Oct 2020

Allowed or allow? If allowed, please correct for all lines.

DG-DEN-4793-1 04 Sep 2020

Done.

DG-DEN-6081-1 30 Dec 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-4793-1 04 Sep 2020

Done.

DIALIN-DEN-4344-1 26 Aug 2020

Is there a way to get these values right from c code of firmware?
Like a scripts which reads the c file and generates this py code.

DIALIN-DEN-4344-1 26 Aug 2020

Is there a way to get these values right from c code of firmware?
Like a scripts which reads the c file and generates this py code.

DIALIN-DEN-4344-1 26 Aug 2020

It has been updated in scripts to "Projects"

HD-DEN-4211-1 26 Aug 2020

Done

HD-DEN-4308-3 22 Sep 2020

Shouldn't we increment fail count here? As it stands, seems like the counter is 1 fail behind.

DIALIN-DEN-4690-1 08 Sep 2020

Remove second copyright.

UI-DEN-4690-1 08 Sep 2020

Changed the file name so Doxygen is not documenting it.
Doxygen is looking for .h/.cpp/.qml only.

UI-DEN-4690-1 08 Sep 2020

Why does file name end in ._?

HD-DEN-4308-3 27 Aug 2020

Comment above says you should subtract here - not add. Check direction on both - I think position B would be addition and C would be subtraction.

DIALIN-DEN-4211-1 08 Sep 2020

RESOLVED.

HD-DEN-4308-3 27 Aug 2020

To be consistent with the many other state machines, we should just return state to executive and let executive assign new state to valvesStatus[ valve ].execState.

DG-DEN-4322-1 26 Aug 2020

{ at next line based on C Coding Standard

HD-DEN-4211-1 26 Aug 2020

Change # to number.

HD-DEN-4211-1 26 Aug 2020

Remove function name.

HD-DEN-4211-1 26 Aug 2020

Remove function name.

HD-DEN-4211-1 26 Aug 2020

Change to doxygen style.

HD-DEN-4211-1 26 Aug 2020

Replace # with number.

HD-DEN-4211-1 26 Aug 2020

Replace # with number.

HD-DEN-4211-1 26 Aug 2020

Replace # with number.

DIALIN-DEN-4211-1 08 Sep 2020

This is an old formatted copyright. The new copyright format will be inserted into the file automatically by Bamboo.

UI-DEN-4690-1 08 Sep 2020

Remove extra line.

UI-DEN-4690-1 08 Sep 2020

Remove extra line.

UI-DEN-4690-1 08 Sep 2020

RESOLVED.

UI-DEN-4690-1 08 Sep 2020

You are right Peman.
I kept them as a template and removed them from the project for later use.
Now I had to remove it from Doxygen sight.
Prefer to keep it if you don't mind.
Can be removed as well.

UI-DEN-4690-1 08 Sep 2020

Remove.

UI-DEN-4690-1 08 Sep 2020

Remove extra line.

UI-DEN-4690-1 08 Sep 2020

Remove extra line.

UI-DEN-4690-1 08 Sep 2020

Remove extra line.

UI-DEN-4690-1 08 Sep 2020

Remove extra line.

UI-DEN-4690-1 08 Sep 2020

Remove extra line.