•  

Comment Results

Review Name Created Custom Fields Content
DG-DEN-4322-1 26 Aug 2020

Done.

DG-DEN-4322-1 26 Aug 2020

Done.

DIALIN-DEN-4344-1 26 Aug 2020

Okay. It's "Projects" now

DIALIN-DEN-4344-1 26 Aug 2020

Reminded him again and he is aware of it and has plan to do so.
We use "Projects" and if meanwhile anyone has a non-updated VM will update the folder name manually for now.

DIALIN-DEN-4344-1 26 Aug 2020

RESOLVED.

HD-DEN-4211-1 26 Aug 2020

Done

HD-DEN-4211-1 26 Aug 2020

Done

HD-DEN-4211-1 26 Aug 2020

Yes. Done.

HD-DEN-4211-1 26 Aug 2020

Done

HD-DEN-4211-1 26 Aug 2020

Done

HD-DEN-4211-1 26 Aug 2020

Done

HD-DEN-4211-1 26 Aug 2020

Done

HD-DEN-4211-1 26 Aug 2020

Done

HD-DEN-4211-1 26 Aug 2020

Done

HD-DEN-4211-1 26 Aug 2020

Done

HD-DEN-4211-1 26 Aug 2020

Done

HD-DEN-4211-1 26 Aug 2020

Done

HD-DEN-4211-1 26 Aug 2020

Done

HD-DEN-4211-1 26 Aug 2020

Done

HD-DEN-4211-1 26 Aug 2020

Done

HD-DEN-4211-1 26 Aug 2020

Done

UI-DEN-4438-1 28 Aug 2020

RESOLVED.

HD-DEN-4211-1 26 Aug 2020

Change private to public.

HD-DEN-4211-1 26 Aug 2020

Change msg buffer to buffer and remove semi-colon.

HD-DEN-4211-1 26 Aug 2020

Done

HD-DEN-4308-3 04 Sep 2020

This function has been removed.

HD-DEN-4211-1 26 Aug 2020

No. Removed.

DIALIN-DEN-4308-1 01 Oct 2020

Done

HD-DEN-4308-3 04 Sep 2020

This function has been removed.

HD-DEN-5053-1 01 Oct 2020

RESOLVED in CODE WALKTHROUGH.

DIALIN-DEN-4211-1 08 Sep 2020

Done

HD-DEN-4308-3 27 Aug 2020

Don't use fabs() on integers. I don't think you want absolute values of individual positions - just absolute value of the difference - and that might not even be right.
The PID may overshoot your 1,000 count advancement target - sometimes by a lot if spring is helping to push. If we overshoot the target by more than max deviation, we should consider that as having reached the target (and then some) and proceed to next advancement target. So absolute value does not seem appropriate here even for the delta.

HD-DEN-4308-3 27 Aug 2020

Can't you just pass in i here?

LEAHI-APPLICATION-LDT-2160-1 05 Sep 2025

Why did this change?
It may affect other screens inheriting this.

HD-DEN-4308-3 22 Sep 2020

This is the most important item to be initialized. The rest will be initialized according to what state the valve is. For instance, if homing is commanded, edge counter, number of failed homings and other variables pertaining to homing will be initialized first.

DG-DEN-3504-1 30 Oct 2020

TODO is missing if it is intended to keep these comments, otherwise delete.

DIALIN-DEN-4211-1 08 Sep 2020

RESOLVED.

DG-DEN-5855-1 10 Dec 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-7117-1 02 Apr 2021

Compiler will not allow numeric start to a #define name.

DG-DEN-5855-1 10 Dec 2020

RESOLVED in CODE WALKTHROUGH.

UI-DEN-4690-1 08 Sep 2020

Removed but not showing up here.

HD-DEN-4308-3 02 Oct 2020

Done

UI-DEN-4690-1 08 Sep 2020

This file replaced with its Camel Case version.

DIALIN-DEN-4690-1 08 Sep 2020

Removed.

DIALIN-DEN-4211-1 08 Sep 2020

This is an old formatted copyright. The new copyright format will be inserted into the file automatically by Bamboo.

DIALIN-DEN-4211-1 08 Sep 2020

This is an old formatted copyright. The new copyright format will be inserted into the file automatically by Bamboo.

UI-DEN-4690-1 08 Sep 2020

Changed the file name so Doxygen is not documenting it.
Doxygen is looking for .h/.cpp/.qml only.

UI-DEN-4690-1 08 Sep 2020

Remove extra line.

UI-DEN-4690-1 08 Sep 2020

Remove extra line.

UI-DEN-3605-4 05 Oct 2020

Done, will post update to this review soon