Remove extra line.
Done, will post update to this review soon
RESOLVED.
Done
Done, will post the update to this review soon
this file has been removed. don't know why it shows up here!
this file has been replaced by its Camel Case version. don't know why it shows up here!
Good point, I don't know. This is the way Crucible shows them.
Function name is not matched.
This file has been removed. Not sure why is showing up here!
The function name is not matched.
This file is replaced with its Camel Case name version.
Remove extra lines.
Removed the local variable.
RESOLVED in CODE WALKTHROUGH.
Should be air trap data.
This appears to be a homing step timeout - rename and use task interval to clarify timing.
Do we need the variable roPumpPWMDutyCyclePct anymore?
The function has been moved upward in order defined in the header Comm.h.
Waiting until merge to staging - logger not yet available until then.
Changed the file name so Doxygen is not documenting it. Doxygen is looking for .h/.cpp/.qml only.
I think it should say "required" after adding acid.
Removed.
This is not just to check the range of the valves. All the other enums that we have such as valves positions and valves states also need to be tried to make sure nothing out of range was selected.
Remove.
RESOLVED
Got a suggestion or an issue? Discuss it on the Atlassian Community or visit Atlassian Support for other options.
