Comment Search

Done

this file has been removed.
don't know why it shows up here!

Good point, I don't know.
This is the way Crucible shows them.

this file has been replaced by its Camel Case version.
don't know why it shows up here!

This file has been removed.
Not sure why is showing up here!

The function name is not matched.

This file is replaced with its Camel Case name version.

This file is replaced with its Camel Case name version.

Remove extra lines.

Remove extra line.

Remove extra line.

Done

RESOLVED in CODE WALKTHROUGH.

Should be air trap data.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

This appears to be a homing step timeout - rename and use task interval to clarify timing.

Do we need the variable roPumpPWMDutyCyclePct anymore?

Waiting until merge to staging - logger not yet available until then.

Changed the file name so Doxygen is not documenting it.
Doxygen is looking for .h/.cpp/.qml only.

Removed.

This is not just to check the range of the valves. All the other enums that we have such as valves positions and valves states also need to be tried to make sure nothing out of range was selected.

This file has been removed.
Not sure why is showing up here!

This file has been removed.
Not sure why is showing up here!

This code review was created on August 25.
The design changes with MAbstract and MModel were merged to master on August 31st.
Our process now discourages merging code between development branches, so the create treatment implementation doesn't incorporate the design changes that were first merged to master on August 31st.
As per Behrouz's and my conversation yesterday, the work to subclass MAbstract and MModel is going to be tracked in this ticket next sprint. http://dvm-linux02:8080/browse/DEN-4981