•  

Comment Results

Review Name Created Custom Fields Content
UI-DEN-3605-4 06 Oct 2020

Please change Btn to Button and re-align the ':'.
In general please don't use these kinds of simplifications unless it's too obvious like Rectangle->rect.

UI-DEN-3605-4 07 Oct 2020

Later please use more familiar terms like "Option Button".
The layout "grid of options" is feature of "Option Button" not the component itself.
RESOLVED

UI-DEN-3605-4 07 Oct 2020

See 5387db3 after dragging the slider to the right on the top

Previously you requested I rename this to MAdjustTreatmentParametersRequest, which is what I changed it to in 5387db3.

Which do you prefer, MTreatmentParameters or is MAdjustTreatmentParametersRequest?

DIALIN-DEN-4690-1 07 Oct 2020

This should be removed

DIALIN-DEN-4690-1 07 Oct 2020

This function name could be clearer

TESTSUITES-DEN-3724-1 14 Oct 2020

Done

DIALIN-DEN-4856-1 14 Oct 2020

RESOLVED.

DG-DEN-3421-1 19 Oct 2020

Add TODO

TESTSUITES-DEN-3724-1 15 Oct 2020

RESOLVED

DG-DEN-3421-1 19 Oct 2020

Add TODO

UI-DEN-4438-1 25 Aug 2020

Absolutely,
I'm doing it incrementally and slowly to not to make the code reviews harder and confusing git.
I did for so many and this file will get its turn soon.

DIALIN-DEN-7117-1 07 Apr 2021

Done.

UI-DEN-4438-1 25 Aug 2020

Absolutely,
I'm doing it incrementally and slowly to not to make the code reviews harder and confusing git.
I did for so many and this file will get its turn soon.

UI-DEN-4964-1 13 Oct 2020

This should go under Views - HD - Data

UI-DEN-4438-1 25 Aug 2020

Absolutely,
I'm doing it incrementally and slowly to not to make the code reviews harder and confusing git.
I did for so many and this file will get its turn soon.

HD-DEN-4308-3 29 Aug 2020

Could you please be more specific? I need both those conditions to be true to fault.

UI-DEN-4438-1 25 Aug 2020

Thanks for your attention into the details.
I tweaked it many times to get that value and I should have missed it.
done.

HD-DEN-4211-1 31 Aug 2020

RESOLVED in CODE WALKTHROUGH.

UI-DEN-4438-1 25 Aug 2020

done

DG-DEN-3504-1 30 Oct 2020

we are (instead of we're)

HD-DEN-4308-3 01 Sep 2020

Params have been removed since we use structures directly. Removed the params.

DIALIN-DEN-3421-1 10 Dec 2020

RESOLVED

DG-DEN-3504-1 07 Oct 2020

0.1 what? I assume grams. Add units to #define or at least comments to clarify. 0.1 g is a very tight tolerance.

DG-DEN-3504-1 30 Oct 2020

Why removed?

HD-DEN-4308-3 23 Sep 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-4308-3 01 Oct 2020

Move valves to controllers section above.

DIALIN-DEN-3421-1 10 Dec 2020

Done

DIALIN-DEN-4690-1 05 Oct 2020

Description added.
I am not familiar with Sphinx and that's not the documentation we should use for UI Software.
The comments are in the Markup language and Sphinx, like all the other documentation tools, must have a way to understand it.

HD-DEN-4308-3 22 Sep 2020

Rather than use the if statement to assign variable energized to TRUE, i recommend to assign the if condition directly to the variable energized.
So the whole if statement can be replaced by one line - BOOL const energized = (STATE_OPEN == state).
Both has the same result, but the other way has less code.

UI-DEN-3605-4 05 Oct 2020

Controls is needed for the scrollbar. Looks like Layouts isn't needed, so I've removed it
Will post the update soon

UI-DEN-3605-4 05 Oct 2020

I've updated it to use an attached scrollbar. Just FYI, for some reason the attached scrollbar doesn't hide automatically when the content height is less than the height of the screen.
Will post my update soon

UI-DEN-3605-4 09 Sep 2020

Treatment parameters are set before the start of a treatment, so naming them with Adjust prefix is misleading of the intended function.

UI-DEN-3605-4 30 Sep 2020

Why these two libs has been imported?

UI-DEN-3605-4 30 Sep 2020

Why another class has been created for saving files.
What is the advantage of this class other than inherited from Q_Object and can have signal/slot.
It could be a simple single function in another class inherited from Q_Object.

HD-DEN-5053-1 22 Sep 2020

Recommend to combine into one line and return the if condition.

UI-DEN-3605-4 05 Oct 2020

will be reviewed later on the assigned code review.
RESOLVED

HD-DEN-4308-3 22 Sep 2020

Done

HD-DEN-7091-1 22 Mar 2021

Done.

UI-DEN-3605-4 05 Oct 2020

RESOLVED

HD-DEN-4308-3 23 Sep 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-4308-3 22 Sep 2020

I set the result variable to TRUE by default so if any of these cases are not true, the variable is returned as TRUE. So there is implicitly an else statement.

UI-DEN-3605-4 05 Oct 2020

RESOLVED

HD-DEN-4308-3 22 Sep 2020

Done

DIALIN-DEN-4640-1 06 Oct 2020

Okay, thanks. RESOLVED.

HD-DEN-4308-3 22 Sep 2020

Will be addressed in Sprint28 branch.

HD-DEN-4308-3 22 Sep 2020

s/w fault.

HD-DEN-4308-3 23 Sep 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-4308-3 22 Sep 2020

I recommend we always reverse the order of == conditions so that if we accidentally use = instead of ==, the compiler will give an error.

HD-DEN-4308-3 23 Sep 2020

RESOLVED in CODE WALKTHROUGH.

UI-DEN-3605-4 30 Sep 2020

fine then.
RESOLVED.