•  

Comment Results

Review Name Created Custom Fields Content
HD-DEN-7117-1 06 Apr 2021

Fixed.

UI-DEN-4438-1 25 Aug 2020

Absolutely,
I'm doing it incrementally and slowly to not to make the code reviews harder and confusing git.
I did for so many and this file will get its turn soon.

UI-DEN-3605-4 28 Aug 2020

RESOLVED.

UI-DEN-4438-1 25 Aug 2020

Absolutely,
I'm doing it incrementally and slowly to not to make the code reviews harder and confusing git.
I did for so many and this file will get its turn soon.

UI-DEN-3605-4 28 Aug 2020

Done

UI-DEN-3605-4 30 Sep 2020

The order is so important and that the order of receiving the information over the CANBus which going to be used the same order everywhere even in Models and Views.
To be clarified, please confirm.
1 - The order is changed and has been implemented correctly in the recent modification of the class.
2 - I expect to see later in a code review the correct order as has been defined in the "message list" excel sheet as below :

54, 0x020, 6, Rsp, Y, HD, UI, "Validate New Create Treatment Response"
01 - (U32)-0=No, 1=Yes
02 - (U32) Blood Flow Rate Response
03 - (U32) Dialysate Flow Rate Response
04 - (U32) Duration Response
05 - (U32) Heparin Stop Time Response
06 - (U32) Saline Bolus Response
07 - (U32) Acid Concentrate Response
08 - (U32) Bicarbonate Concentrate Response
09 - (U32) Dialyzer Type Response
10 - (U32) Blood Pressure Measure Interval Response
11 - (U32) Rinseback Flow Rate Response
12 - (U32) Arterial Pressure Limit Low Response
13 - (U32) Arterial Pressure Limit High Response
14 - (U32) Venous Pressure Limit Low Response
15 - (U32) Venous Pressure Limit High Response
16 - (U32) Heparin Dispensing Rate Response
17 - (U32) Heparin Bolus Volume Response
18 - (U32) Dialysate Temperature Response

DG-DEN-4322-1 25 Aug 2020

I think we decided that all .c and .h files would end with one blank line. Looks like all DG source files now have no blank lines at end.

UI-DEN-3605-4 28 Aug 2020

Done

HD-DEN-4308-3 29 Aug 2020

This is for testing only. I was concentrating on one valve at the time.

UI-DEN-3605-4 30 Sep 2020

I mentioned before, but I don't see why another specific macro other than the standards have been created?

HD-DEN-4211-1 31 Aug 2020

RESOLVED in CODE WALKTHROUGH.

UI-DEN-3605-4 01 Sep 2020

RESOLVED.

HD-DEN-5053-1 01 Oct 2020

RESOLVED in CODE WALKTHROUGH.

UI-DEN-3605-4 01 Sep 2020

RESOLVED.

HD-DEN-4308-3 02 Oct 2020

Done

HD-DEN-4308-3 01 Sep 2020

Copyright will be automatically added during the Bamboo build.

HD-DEN-4308-3 01 Sep 2020

Done

UI-DEN-4690-1 09 Sep 2020

RESOLVED.

UI-DEN-4690-1 30 Sep 2020

RESOLVED.

DIALIN-DEN-4308-1 30 Sep 2020

Done

HD-DEN-4308-3 02 Oct 2020

This is the number associated with that particular enum. It is displayed every 5 counts.

HD-DEN-4308-3 23 Sep 2020

Done

HD-DEN-4308-3 02 Oct 2020

Improved the comment.

HD-DEN-4308-3 23 Sep 2020

Done. I like them to be in multiple lines for better readability though.

HD-DEN-4308-3 30 Sep 2020

I thought our C coding standard mandates spaces between [ ] and ( ) and their arguments?

UI-DEN-3605-4 30 Sep 2020

Same comment as
http://192.168.10.132:8060/cru/UI-DEN-3605-4#c5093

DIALIN-DEN-4308-1 30 Sep 2020
HD-DEN-4308-3 23 Sep 2020

This is done in the first if and else statements in this function. 15000 steps is assigned and in this function if the current position to the target position is less than 15000 steps, it will assign the target to it.

HD-DEN-5053-1 23 Sep 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-3504-1 30 Oct 2020

Sean Nash These flags might still be needed. What do you think?

HD-DEN-5053-1 23 Sep 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-5053-1 22 Sep 2020

The description seems to be incorrect.

DIALIN-DEN-5282-1 30 Oct 2020

Okay, RESOLVED

HD-DEN-5053-1 23 Sep 2020

I think it's more readable this way.

HD-DEN-4308-3 22 Sep 2020

Check valve and position params are valid.

DIALIN-DEN-4690-1 07 Oct 2020

This should be removed

UI-DEN-4598-1 29 Oct 2020

After I checked out into your feature branch I found out the filesaver(.h,.cpp) name is not PascalCase.
Please change the filesaver to FileSaver.

UI-DEN-4690-1 07 Oct 2020

Should indicate the return type and what is returned when. if init() changes, this function will behave differently, but it won't be reflected in the documentation

DIALIN-DEN-5053-1 29 Sep 2020

Done.

DG-DEN-5846-1 30 Nov 2020

It was removed from this branch. It is still available in the RO pump branch.

DIALIN-DEN-5053-1 29 Sep 2020

Done.

UI-DEN-4690-2-1 30 Sep 2020

Totaly agree but I didn't use classes at the beginning.
When I improve the simulator will consider using class and remove the globals.

DG-DEN-5846-1 30 Nov 2020

I have not seen the parameter name in these functions. I added it.

DIALIN-2 30 Sep 2020

Good,
So please consider cleaning up used libraries periodically.

RESOLVED.

DIALIN-DEN-4308-1 28 Sep 2020

Remove extra spaces at the end of argument list between ().

HD-DEN-4308-3 22 Sep 2020

Why only initializing the state for each valve?

UI-DEN-3605-4 28 Aug 2020

Done

UI-DEN-4438-1 25 Aug 2020

Absolutely,
I'm doing it incrementally and slowly to not to make the code reviews harder and confusing git.
I did for so many and this file will get its turn soon.

UI-DEN-4438-1 25 Aug 2020

Absolutely,
I'm doing it incrementally and slowly to not to make the code reviews harder and confusing git.
I did for so many and this file will get its turn soon.

HD-DEN-4308-3 23 Sep 2020

RESOLVED in CODE WALKTHROUGH.