•  

Comment Results

Review Name Created Custom Fields Content
UI-DEN-3149-1 11 Jun 2020

That's what I have for EMC test.
I would like to keep it so as I mentioned in the task for EMC support I pushed the code here to be reviewed and kept.

DG-DEN-3421-1 13 Aug 2020

@Sean - review and direct Dara how to resolve.

DG-DEN-3421-1 12 Aug 2020

It should logically be an else but I wanted to make sure we don't go to the verify flow state due to any other unexpected conditions.

UI-DEN-3253-1 17 Jun 2020

Dispositioned to DEN-3742

UI-DEN-3253-1 17 Jun 2020

Requested change has been made. Ready to be resolved.

HD-DEN-7091-1 15 Mar 2021

Fixed.

HD-DEN-3115-1 19 Jun 2020

HALCoGen removed these when I changed from FIQ to IRQ.

HD-DEN-3115-1 19 Jun 2020

This is the TI copyright that we got these API files originally. Yes, they are different from the other TI files that are generated by HALCoGen but they are still TI files and not ours. When I was working on the copyright script, I realized the script did not realize they are not our files and added our copyright. I enhanced the algorithm that checks whether a file belongs to Diality or not, so this issue will not happen. At the same time, I removed the Diality copyright. I am not sure why there is a "?" in their copyright that does not affect the script's parsing capabilities.

UI-DEN-3253-1 15 Jun 2020

Thanks Peter,
My comments were redundant.
At the time I started I didn't know which one will catch you're attention.
RESOLVED

UI-DEN-3253-1 26 Jun 2020

Sure,
I'll update that in my current working branch.
So Peter leave it as it is here and I'll fix that there.
Thanks,

UI-DEN-3253-1 26 Jun 2020

Peter,
Could you please explain why it needs to be separated.
The current unit tests on server are using the same object name and identification and working.
The only thing needs to be done is to separate them by their container which the location it has been instantiated and used.
So this way you're working with objects not classes.

UI-DEN-3875-1 20 Aug 2020

RESOLVED.

UI-DEN-3253-1 01 Jul 2020

Done

UI-DEN-3605-4 28 Aug 2020

RESOLVED.

DG-DEN-5846-1 30 Nov 2020

There are only two states. The other state only waits for a few ms for FPGA to start reading. Also, I didn't want to monitor the thermistors every 50ms.

UI-DEN-3875-1 20 Aug 2020

The mL to L is only used in ultrafiltration and only for volume and only for display on screen.
it wasn't worth including utility class here which costs more code and build time only for a division/multiplication.
comment will suffice.

DIALIN-DEN-3421-1 10 Dec 2020

It is there.

UI-DEN-3253-1 06 Jul 2020

I don't agree with the implementation.
OK for now.

RESOLVED

DIALIN-DEN-2379-1 01 Jul 2020

Make sure to decorate your _handler functions with the _publish decorator with a list of strings for all class variables that will be published.

UI-DEN-3875-1 20 Aug 2020

The mL to L is only used in ultrafiltration and only for volume and only for display on screen.
it wasn't worth including utility class here which costs more code and build time only for a division/multiplication.
comment will suffice.

DG-DEN-5846-1 30 Nov 2020

Done

DG-DEN-3421-1 13 Aug 2020

RESOLVED in CODE WALKTHROUGH.

UI-DEN-3605-4 28 Aug 2020

RESOLVED.

HD-DEN-13460-2 22 Sep 2022

Done.

UI-DEN-3875-1 20 Aug 2020

Correct, our latest C++ Coding Standard Point 51. states: "File content should be kept within 200 number of columns."

UI-DEN-3875-1 12 Aug 2020

Align arguments under each other for increased legibility.

DG-DEN-3421-1 12 Aug 2020

Done

DG-DEN-4217-1 11 Aug 2020

Good catch. Removed HD_ prefix and moved to common Accel.h.

UI-DEN-3875-1 12 Aug 2020

Create utility class with fromLtoML method (local or global)

DG-DEN-3421-1 12 Aug 2020

Done

UI-DEN-3875-1 12 Aug 2020

Create utility class with fromLtoML method (local or global)

UI-DEN-3875-1 20 Aug 2020

RESOLVED.

DG-DEN-3421-1 12 Aug 2020

All the modules will have doxygen hooks eventually

HD-DEN-4308-3 31 Aug 2020

I think this would be simpler with the following structure:
if out of range
increment counter
if out of range for too long
fault
else
counter = 0

HD-DEN-13460-2 22 Sep 2022

RESOLVED IN CODE WALKTHROUGH

HD-DEN-4308-3 01 Sep 2020

Done

DG-DEN-4217-1 12 Aug 2020

This module not yet converted to new Doxygen format.

HD-DEN-14000-1 13 Oct 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-4217-1 12 Aug 2020

Done

DG-DEN-3421-1 12 Aug 2020

Done

DG-DEN-3421-1 11 Aug 2020

This looks more like a heatDisinfectStartTime. Elapsed time is calculated later.

DG-DEN-3421-1 11 Aug 2020

Should this be >= ?

DG-DEN-3421-1 10 Aug 2020

I don't know if this will cause any Vectorcast problems. But generally, I thought we agreed to add new enums to bottom of list.

UI-DEN-4690-1 09 Sep 2020

RESOLVED.

HD-DEN-13834-1 13 Oct 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-13834-1 14 Oct 2022

Done.

UI-DEN-4690-1 09 Sep 2020

RESOLVED.

UI-DEN-3875-1 21 Aug 2020

Ok, RESOLVED.

UI-DEN-4690-1 09 Sep 2020

RESOLVED.

UI-DEN-4438-1 25 Aug 2020

Absolutely,
I'm doing it incrementally and slowly to not to make the code reviews harder and confusing git.
I did for so many and this file will get its turn soon.