•  

Comment Results

Review Name Created Custom Fields Content
UI-DEN-3605-4 25 Aug 2020

Remove extra line.

UI-DEN-3605-4 25 Aug 2020

Remove extra line.

DG-DEN-4217-1 12 Aug 2020

Moved these records to MessagePayloads.h

DG-DEN-4217-1 11 Aug 2020

Done.

DG-DEN-5855-1 10 Dec 2020

We should allow MAX value here (1.0).

UI-DEN-5282-1 30 Oct 2020

RESOLVED

UI-DEN-3875-1 07 Aug 2020

The code reaches column 189 here.

From the C++ coding standard 11.1:
"File content should be kept within 100 number of columns...."

DG-DEN-3421-1 12 Aug 2020

Done

UI-DEN-3605-4 25 Aug 2020

Remove extra line.

DG-DEN-3421-1 12 Aug 2020

Done

DIALIN-DEN-4438-1 21 Aug 2020

Peman this isn't Behrouz's change. I must have added this as a placeholder. I have now removed it on my development branch, so it can be replaced in the future with the coverage test.

UI-DEN-3605-4 25 Aug 2020

Remove extra line.

DG-DEN-3421-1 12 Aug 2020

I don't think I commented it. I uncommented it

DG-DEN-12224-7 23 May 2022

Done.

DG-DEN-3421-1 13 Aug 2020

Do not leave them as none.

DG-DEN-3421-1 13 Aug 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-12224-16 23 May 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-3421-1 13 Aug 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-4217-1 12 Aug 2020

I think SHA will (maybe already does) call out certain data items as critical and control measure is to have some kind of means to verify integrity. I think all of the treatment parameters that I'm adding in this story will qualify as critical so I added these critical data structures and functions.

DG-DEN-4217-1 12 Aug 2020

1) Done
2) This module not yet converted to new Doxygen format.

UI-DEN-4438-1 24 Aug 2020

This is the namespace brace and the namespaces braces are not indenting the code. so are at the same column as class brace in this case.

HD-DEN-13427-1 07 Sep 2022

Fixed. Thanks!

DIALIN-DEN-4438-1 20 Aug 2020

Why file is empty?

UI-DEN-4438-1 25 Aug 2020

File name must use camelCase.

UI-DEN-3605-4 28 Aug 2020

RESOLVED.

HD-DEN-9480-1 10 Nov 2021

Done.

UI-DEN-4438-1 25 Aug 2020

File name must use camelCase.

UI-DEN-4438-1 25 Aug 2020

File name must use camelCase.

UI-DEN-3605-4 01 Sep 2020

RESOLVED.

UI-DEN-4598-1 29 Oct 2020

Remove extra lines.

HD-DEN-13427-1 07 Sep 2022

Fixed. Thanks!

UI-DEN-4964-1 30 Oct 2020

RESOLVED

UI-DEN-4438-1 20 Aug 2020

Remove extra line before }

DG-DEN-13427-1 07 Sep 2022

Fixed. Thanks!

DG-DEN-13427-1 07 Sep 2022

Fixed. Thanks!

DIALIN-DEN-12716-1 08 Sep 2022

Updated.

DIALIN-DEN-12716-1 06 Jul 2022

Please add data types of the parameters.

DG-DEN-13427-1 09 Sep 2022

Header needs to be updated

DG-DEN-4322-1 26 Aug 2020

Done.

UI-DEN-4438-1 25 Aug 2020

Fix indentation of }

UI-DEN-3605-4 25 Aug 2020

Remove extra line.

UI-DEN-3253-1 11 Jun 2020

Remove extra line.

DG-DEN-4217-1 12 Aug 2020

Add extra line between } and function.

UI-DEN-3253-1 11 Jun 2020

RESOLVED.

DG-DEN-4217-1 12 Aug 2020

Missing the Doxygen /*@}/ at eof.

UI-DEN-3253-1 15 Jun 2020

It is a required import for ColorOverlay

DG-DEN-3421-1 12 Aug 2020

Make this entire assignment one line (does not exceed 150 characters)

UI-DEN-3253-1 06 Jul 2020

RESOLVED

DG-DEN-4217-1 12 Aug 2020

This module not yet converted to new Doxygen format.

UI-DEN-3253-1 26 Jun 2020

I understand and agree, that's extra work.
But that wasn't even part of the Alarm design.
This is the settings feature which has not been started yet.
That's exactly why we have this interview to let you (or any developer) know the changes before the Unit test/Integration Test/Code Coverage is done and also to know that against which code those test/coverage needs to be done.