This is the vertical code alignment to make sure the overloading is correctly done. data() is not override from base class but is const and fromByteArray() has to be overrode and should not be const.
Please correct the order of the fields regarding the message like what is done for the response message. There are three different types and it's hard to follow.
The representation of the data is not the way it's going to be on production but the code that is being code reviewed and doing code coverage on it, is. All those codes will be logged, in the production code.
Absolutely, I'm doing it incrementally and slowly to not to make the code reviews harder and confusing git. I did for so many and this file will get its turn soon.
Later when we have the API integrated in the Dialin, we need to send Ack back and then we have to remove this. The reason is application has to be tested exactly the way it is used in the field with no extra switch to bypass any check just to check. Otherwise we are not testing the real application.
FYI: AS of today, the QML coding standard (X:\Engineering\Denali\06- Software Design\Software Documentation\Coding Standards) doesn't currently dictate when and when not to use semicolons in QML.
This is the only and only place uses this value as hour and not minute. When more places use it I'll absolutely create a function. Currently a comment that what is 60 will suffice.
