•  

Comment Results

Review Name Created Custom Fields Content
DG-DEN-4169-1 31 Jul 2020

RESOLVED in CODE WALKTHROUGH.

DIALIN-DEN-4211-1 28 Aug 2020

RESOLVED.

DG-DEN-4169-1 31 Jul 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-15306-3 02 Jun 2023

Done.

DG-DEN-4184-1 03 Aug 2020

Fixed.

DG-DEN-4169-1 31 Jul 2020

Move all arguments and align them with the left "(" of start of argument list.

DG-DEN-4184-1 03 Aug 2020

RESOLVED IN CODE WALKTHROUGH

UI-DEN-3875-1 20 Aug 2020

Absolutely,
As // TODO says it has to be part of the pre-treatment flow getting the data from prescription parameters.

DG-DEN-3421-1 12 Aug 2020

I am still waiting to finalize the #defines. Once they are all done, I usually align all of them to the longest #define

DG-DEN-4322-1 20 Aug 2020

Why empty file deleted?

UI-DEN-3605-4 28 Aug 2020

RESOLVED.

UI-DEN-4438-1 25 Aug 2020

Remove extra line and fix indentation of }

DG-DEN-13598-2 22 Sep 2022

Done.

DG-DEN-4217-1 17 Aug 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-3421-1 12 Aug 2020

Yes, it is for the macros. The normal code fine

DG-DEN-13598-2 22 Sep 2022

Removed.

DG-DEN-3421-1 13 Aug 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-3421-1 13 Aug 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-3421-1 13 Aug 2020

RESOLVED in CODE WALKTHROUGH.

UI-DEN-3605-4 28 Aug 2020

RESOLVED.

UI-DEN-4438-1 25 Aug 2020

File name must use camelCase.

UI-DEN-4438-1 25 Aug 2020

Remove extra line and fix indentation of }

UI-DEN-3605-4 28 Aug 2020

RESOLVED.

UI-DEN-3605-4 28 Aug 2020

RESOLVED.

UI-DEN-4690-1 09 Sep 2020

RESOLVED.

UI-DEN-3253-1 22 Jun 2020

Why it has been imported ?

DG-DEN-4217-1 12 Aug 2020

Doxygen /*@}/ missing.

DG-DEN-4217-1 12 Aug 2020

What is our plan to generate different builds for various prototypes? Aren't we removing the capability of being able to build release v0.4 by removing this code?

UI-DEN-3253-1 11 Jun 2020

It was pulled from AlarmDefs.h.

Behrouz NematiPour I think to Peman's point it would be better to place these alarm messages in AlarmDefs.h. What do you think?

UI-DEN-3253-1 26 Jun 2020

Per our conversation please change the pressed to clicked.
Thanks,

UI-DEN-3149-1 11 Jun 2020

Sometimes it's easier to read for me.

DG-DEN-4169-1 31 Jul 2020

Why was this functionality removed?

UI-DEN-3253-1 15 Jun 2020

I have talked with Sean and the placeholder has been added to the message lists spreadsheet.

DG-DEN-5846-1 30 Nov 2020

Done

DG-DEN-3421-1 12 Aug 2020

No space after inputs, outputs, just ":" then space to be consistent everywhere.

DG-DEN-3922-1 22 Jul 2020

/// is also picked up by doxygen as well. However, changed to ///< as prefer.

DG-DEN-4322-1 21 Aug 2020

The git rebase operation has affected the review. This PersistentAlarm module has been moved to fwcommon and being deleted in dgfirmware.

UI-DEN-3875-1 20 Aug 2020

Sure,
I'll review it in the Saline Bolus story.
If I change it hear it may require so many codes to change.
Some of these get_<> test functions need to be removed.

DG-DEN-4217-1 20 Aug 2020

This isn't code - it's a commented equation explaining next 2 lines of code. That said, Dara can add spaces for readability on his branch.

DG-DEN-3421-1 12 Aug 2020

Done

HD-DEN-4211-1 28 Aug 2020

Done

LEAHI-APPLICATION-LDT-1536-1 11 Aug 2025

moved instantiating the dialog to main.qml

HD-DEN-4641-1 30 Nov 2020

Done.

UI-DEN-3875-1 12 Aug 2020

If this is to be removed, add TODO comment with keyword "Remove when ...". Demo code should never remain in release code. Other option is to create ifndef/endif one case with Demo Build, other for no Demo Build.

UI-DEN-3253-1 15 Jun 2020

Please see my latest commit

UI-DEN-3605-4 28 Aug 2020

RESOLVED.

DG-DEN-3421-1 12 Aug 2020

Does the /*@}/ come before or after the endif at eof?

UI-DEN-3605-4 25 Aug 2020

Remove extra 2 lines.

UI-DEN-3605-4 25 Aug 2020

Remove extra line at EOF.

UI-DEN-3605-4 25 Aug 2020

Remove extra line.