Where is this target speed being set? Do you even have a target speed in closed loop delta pressure mode? drainPumpDAC value should be set in the set delta pressure function. Only drainPumpDACSet should be set here.
Clearing should probably be a longer persistence than triggering threshold. Currently both are 50 sec. I think that's too long for triggering. Maybe ok for clearing.
Try to give a sense of time for this. I think Modes are calling the check function so that's on the General Task so that's every 50ms x 1000 = 50 seconds. I usually define these types of things as a # of ms divided by the appropriate task interval (in ms).
All of these flags are for DEBUG build only (not release) and most are not see by Vectorcast either - so for code review purposes it doesn't really matter what the last DEBUG build configuration was.
This should be done in "Set" function above. And assigned to the non "Set" variable. Then, here we would set roPumpPWMDutyCyclePctSet = roPumpPWMDutyCyclePct;
Release builds (i.e. Bamboo) will not have any of these build switches defined. As we get closer to DVT, we should be able to get rid of most of these debug build switches, but they will never interfere with a release build.
Please do not remove the comments with // SquishQt. It means it has been added to be used in SquishQt. And It shows that if we change it our unit tests in SquishQt is not working anymore since it is using this object name to identify the object properly.
Whether it is your code or anybody else's code, it doesn't matter, this way of writing code is simply off standard and unprecedented, frankly. It also does not matter whether Peter or anybody else approved it or not, all that matters is that it is against the standard.
It seems Jira is doing its best to confuse the user with this whole slider of commits and not showing the comments in order and sometimes even hiding comments. I totally don't understand the purpose of these confusing features. Source versioning is so simple and don't need to be complicated by this unnecessary features.
So please forgive me if because of this <not a good adjective> features I put some comments which are irrelevant. Thanks,
extra line removed. This is the namespace brace and the namespaces braces are not indenting the code. so are at the same column as class brace in this case.
