•  

Comment Results

Review Name Created Custom Fields Content
LEAHI-TD-FIRMWARE-LDT-4149-1 13 Aug 2026

use ternary operator

LEAHI-DD-FIRMWARE-LDT-3975-2 11 Aug 2026

fixed thanks

LEAHI-DD-FIRMWARE-LDT-5209-1 11 Aug 2026

fixed thanks

LEAHI-DD-FIRMWARE-LDT-5209-1 11 Aug 2026

Remove empty line.

LEAHI-DD-FIRMWARE-LDT-5186-1 12 Aug 2026

Or User cancels drain request: To cancel the ongoing drain process. Could you please add the condition as well?

LEAHI-TD-FIRMWARE-LDT-4149-1 13 Aug 2026

revert back the comment alignment change

LEAHI-DD-FIRMWARE-LDT-3975-2 11 Aug 2026

fixed thanks

LEAHI-DD-FIRMWARE-LDT-3975-2 11 Aug 2026

fixed thanks

LEAHI-DD-FIRMWARE-LDT-5409-1 11 Aug 2026

added

LEAHI-DD-FIRMWARE-LDT-5409-1 11 Aug 2026

updated

LEAHI-DD-FIRMWARE-LDT-5209-1 11 Aug 2026

fixed thanks

LEAHI-TD-FIRMWARE-LDT-4149-1 11 Aug 2026

Removed

LEAHI-TD-FIRMWARE-LDT-4149-1 11 Aug 2026

Remove extra blank line.

LEAHI-DD-FIRMWARE-LDT-5186-1 12 Aug 2026

You can remove the above condition and do the rest of code, except D65 valve opening. Initially this state was waiting for balancing chamber fill to be completed and open D65 valve later. Now that this function will check the condition and skip the valves actions if not met. this is not the expected behavior.

LEAHI-TD-FIRMWARE-LDT-4049-1 13 Aug 2026

Add parameter (disinfection cmd enum from DDDefs.h). Then only need one signal function for all disinfection types.

LEAHI-TD-FIRMWARE-LDT-4149-1 13 Aug 2026

Input and Output are none.

LEAHI-TD-FIRMWARE-LDT-4149-1 13 Aug 2026

Remove valve

LEAHI-DD-FIRMWARE-LDT-3975-2 11 Aug 2026

fixed thanks

LEAHI-DD-FIRMWARE-LDT-5409-1 11 Aug 2026

updated.

LEAHI-TD-FIRMWARE-LDT-4149-1 11 Aug 2026

Fixed

LEAHI-APPLICATION-LDT-5331-1 11 Aug 2026

check for any null index

LEAHI-TD-FIRMWARE-LDT-4049-1 13 Aug 2026

change enum name too. need 1 alarm for each disinfection type.

LEAHI-DD-FIRMWARE-LDT-3975-2 11 Aug 2026

Add comments.

LEAHI-TD-FIRMWARE-LDT-2240-1 12 Aug 2026

Why is this commented out?

LEAHI-TD-FIRMWARE-LDT-4149-1 13 Aug 2026

General Comment:
If a variable is a param, please remove it from the inputs section of the doxygen header of all the functions.

LEAHI-TD-FIRMWARE-LDT-4149-1 13 Aug 2026

Added

LEAHI-TD-FIRMWARE-LDT-4149-1 13 Aug 2026

add commandFailed to outputs

LEAHI-TD-FIRMWARE-LDT-4149-1 13 Aug 2026

Add to outputs pendingValveHomeRequest

LEAHI-TD-FIRMWARE-LDT-4149-1 13 Aug 2026

I consider constants as similar to a #define and prefer to put them in the definitions section.

LEAHI-TD-FIRMWARE-LDT-4149-1 13 Aug 2026

I see a lot of people doing this to avoid a compiler warning (due to non-use of the given parameter).
I don't think we should have to do weird things like this. As we get closer to s/w release, we can consider removing the function if it's still not doing anything.

LEAHI-TD-FIRMWARE-LDT-4149-1 13 Aug 2026

use ternary operator

LEAHI-TD-FIRMWARE-LDT-4149-1 13 Aug 2026

Outputs:
Remove enableResetValue.
Add pendingValveHomeRequest and pendingValvePositionRequest.

LEAHI-TD-FIRMWARE-LDT-4149-1 13 Aug 2026

Use the Ternary operator format ? : to assign TRUE or FALSE

LEAHI-TD-FIRMWARE-LDT-4149-1 13 Aug 2026

Should it be H1?

LEAHI-TD-FIRMWARE-LDT-4149-1 13 Aug 2026

add @param

LEAHI-TD-FIRMWARE-LDT-4149-1 13 Aug 2026

fix indentation