•  

Comment Results

Review Name Created Custom Fields Content
LEAHI-TD-FIRMWARE-LDT-4149-1 11 Aug 2026

Pinch valve driver shouldn't be needed here. Standby mode should work through Valves.h.

LEAHI-TD-FIRMWARE-LDT-4149-1 11 Aug 2026

Put blank line back.

LEAHI-DD-FIRMWARE-LDT-5186-1 12 Aug 2026

It's better to keep AND condition that d66 pressure must come down to decay pressure before we start vent process.

LEAHI-TD-FIRMWARE-LDT-4029-1 12 Aug 2026

Add a TODO comment to adjust this when new syringe pump assembly is ready.

LEAHI-TD-FIRMWARE-LDT-4149-1 12 Aug 2026

Remove extra blank line.

LEAHI-TD-FIRMWARE-LDT-4149-1 12 Aug 2026

Fix indent for break. Add comment before break "// unhandled position - do nothing.

LEAHI-DD-FIRMWARE-LDT-5186-1 12 Aug 2026

Remove D34 valve close.

LEAHI-DD-FIRMWARE-LDT-5409-1 12 Aug 2026

Are we done testing? Can we remote test variables and code?

LEAHI-TD-FIRMWARE-LDT-4063-1 31 Jul 2026

add safetyShutdownSelfTestStatus to outputs

LEAHI-TD-FIRMWARE-LDT-4063-1 04 Aug 2026

When we send any message to UI, usually add the message id in the doxygen header like this.

  • @details \b Message \b Sent: MSG_ID_TD_RESP_TREATMENT_PARAMS_TO_VALIDATE


Please refer to the function sendTreatmentParamsResponse()

LEAHI-TD-FIRMWARE-LDT-4040-1 04 Aug 2026

those are initialized in resetTreatmentRecircFlags() and that is called in init

LEAHI-TESTSUITES-LDT-3447-1 04 Aug 2026

Revert the staging test script and using the different branch

LEAHI-TD-FIRMWARE-LDT-4031-1 30 Jul 2026

Initialize this in the init function instead of here.

LEAHI-TD-FIRMWARE-LDT-4040-1 23 Jul 2026

Add @message MSG_ID_TD_RECIRCULATE_RESPONSE

LEAHI-APPLICATION-LDT-5074-3 07 Aug 2026

updated

LEAHI-TD-FIRMWARE-LDT-4040-1 06 Aug 2026

I thought Eliza said they wanted to do blood sitting timer even if blood was rinsed back (still a little blood in line).

LEAHI-TD-FIRMWARE-LDT-4072-2 05 Aug 2026

align comments

LEAHI-TD-FIRMWARE-LDT-4033-1 05 Aug 2026

Fixed

LEAHI-TD-FIRMWARE-LDT-4040-1 05 Aug 2026

Update function name: handleRinsebackAdditionalState

LEAHI-TD-FIRMWARE-LDT-4033-1 05 Aug 2026

Inputs : fpgaSensorReadings
Outputs: none

LEAHI-TD-FIRMWARE-LDT-4033-1 05 Aug 2026

Inputs : fpgaSensorReadings
Outputs: none

LEAHI-TD-FIRMWARE-LDT-4040-1 05 Aug 2026

Add cumulativeBloodPrimeVolume_mL to ouputs.

Optional: While you are updating, can you please also add bloodPrimeRampFlowRate_mL_min and bloodPrimeState to the inputs?

LEAHI-DD-FIRMWARE-LDT-3975-2 05 Aug 2026

Aling the indentation of value field.

LEAHI-DD-FIRMWARE-LDT-3975-2 05 Aug 2026

Space before and after paranthesis.

LEAHI-DD-FIRMWARE-LDT-5209-1 11 Aug 2026

fixed thanks

LEAHI-APPLICATION-LDT-5158-1 11 Aug 2026

remove from prime // priming - TODO check if needed. may not need

LEAHI-APPLICATION-LDT-5331-1 12 Aug 2026

added checks for this and the one in VSettings

LEAHI-DD-FIRMWARE-LDT-5186-1 12 Aug 2026

You need to initialize the valve states and timer etc., as similar to when you jump from idle state to fill water state. Fill water state just checks the pressure check condition.

LEAHI-TD-FIRMWARE-LDT-4149-1 27 Jul 2026

I think we should have handle functions that return next state for each of these cases (just like mode state machines).

LEAHI-TD-FIRMWARE-LDT-4149-1 12 Aug 2026

Remove extra blank line.

LEAHI-DD-FIRMWARE-LDT-3975-2 11 Aug 2026

fixed thanks

LEAHI-DD-FIRMWARE-LDT-5409-1 10 Aug 2026

Add comment.

LEAHI-DD-FIRMWARE-LDT-5186-1 12 Aug 2026

Open D80, not D85.

LEAHI-TD-FIRMWARE-LDT-4029-1 12 Aug 2026

Use if else or ternary operator to set BOOL to TRUE or FALSE explicitly.

LEAHI-DD-FIRMWARE-LDT-5409-1 10 Aug 2026

Remove empty line

LEAHI-TD-FIRMWARE-LDT-4149-1 11 Aug 2026

Removed

LEAHI-TD-FIRMWARE-LDT-4149-1 12 Aug 2026

Remove if not needed.

LEAHI-DD-FIRMWARE-LDT-3975-2 11 Aug 2026

fixed thanks

LEAHI-DD-FIRMWARE-LDT-3975-2 11 Aug 2026

fixed thanks

LEAHI-DD-FIRMWARE-LDT-3975-2 11 Aug 2026

fixed thanks

LEAHI-DD-FIRMWARE-LDT-5209-1 11 Aug 2026

Remove empty line.

LEAHI-DD-FIRMWARE-LDT-5209-1 30 Jul 2026

Do we need to transition to next state DD_PREGEN_DRY_BICART_INITIAL_FILL here?

LEAHI-TD-FIRMWARE-LDT-4149-1 12 Aug 2026

Should we remove the commented code?

LEAHI-TD-FIRMWARE-LDT-4029-1 12 Aug 2026

Does default mean invalid state (s/w fault) or does it mean it's a state that we don't need to do anything for? If latter, add a comment here saying that.

LEAHI-DD-FIRMWARE-LDT-3975-2 11 Aug 2026

fixed thanks

LEAHI-DD-FIRMWARE-LDT-5209-1 11 Aug 2026

fixed thanks

LEAHI-DD-FIRMWARE-LDT-5209-1 11 Aug 2026

Remove empty line.

LEAHI-DD-FIRMWARE-LDT-5186-1 12 Aug 2026

Or User cancels drain request: To cancel the ongoing drain process. Could you please add the condition as well?

LEAHI-DD-FIRMWARE-LDT-3975-2 11 Aug 2026

fixed thanks

LEAHI-DD-FIRMWARE-LDT-3975-2 11 Aug 2026

fixed thanks