•  

Comment Results

Review Name Created Custom Fields Content
LEAHI-TD-FIRMWARE-LDT-4072-2 31 Jul 2026

capitalize

LEAHI-TD-FIRMWARE-LDT-4072-2 31 Jul 2026

minor typo : fix batteru

LEAHI-TD-FIRMWARE-LDT-4072-2 31 Jul 2026

break this line

LEAHI-TD-FIRMWARE-LDT-4072-2 31 Jul 2026

Add space in [registerSel]

LEAHI-TD-FIRMWARE-LDT-4072-2 31 Jul 2026

Add Comments for line 43 to 50 and align all the comments of this section to line 38.

LEAHI-TD-FIRMWARE-LDT-4072-2 31 Jul 2026

break this line

LEAHI-TD-FIRMWARE-LDT-4072-2 31 Jul 2026

assign result to a variable and then return and break the line

LEAHI-TESTSUITES-LDT-3814-1 16 Jul 2026

after receiving the request for vitals send the response adn vitals data as well.

also please update verifying the request as this way will always pass

LEAHI-TD-FIRMWARE-LDT-4031-1 30 Jul 2026

Try to initialize these broadcast timer counters to different values (between 0 and 19) so that we don't broadcast all data messages at the same time - we want to spread these broadcasts out over each 1 second period of time.

LEAHI-TD-FIRMWARE-LDT-4040-1 23 Jul 2026

Update spelling of cummulativeRinsebackVolume_mL

LEAHI-TD-FIRMWARE-LDT-4033-1 05 Aug 2026

Fixed

LEAHI-TD-FIRMWARE-LDT-4072-2 05 Aug 2026

Should these three alarms be moved after alarm 852?

It looks like 999 is currently placed before 852.

LEAHI-APPLICATION-LDT-4959-1 31 Jul 2026

BN approves

LEAHI-TD-FIRMWARE-LDT-4072-2 31 Jul 2026

break this line

LEAHI-TD-FIRMWARE-LDT-4072-2 31 Jul 2026

break lines of this function to match our standard of 100 columns.

LEAHI-TESTSUITES-LDT-2721-1 31 Jul 2026

mvoe to utility

LEAHI-TD-FIRMWARE-LDT-4009-1 04 Aug 2026

updated

LEAHI-TD-FIRMWARE-LDT-4033-1 05 Aug 2026

Fixed

LEAHI-TD-FIRMWARE-LDT-4033-1 05 Aug 2026

Fixed

LEAHI-APPLICATION-LDT-4959-1 31 Jul 2026

BN approves

LEAHI-TD-FIRMWARE-LDT-4072-2 31 Jul 2026

add a blank line above

LEAHI-TD-FIRMWARE-LDT-4072-2 31 Jul 2026

add a blank line above

LEAHI-TD-FIRMWARE-LDT-4029-1 05 Aug 2026

What if we're in paused state (because your alarm has stop property set)? Should we return TRUE here if in paused state and interrupted state was the await syringe load confirmation state?

LEAHI-TD-FIRMWARE-LDT-4040-1 23 Jul 2026

Initialization is missing in the init function for variables from line 72 to 77.

LEAHI-TD-FIRMWARE-LDT-4040-1 23 Jul 2026

break into two lines

LEAHI-TD-FIRMWARE-LDT-4033-1 05 Aug 2026

Fixed

LEAHI-TD-FIRMWARE-LDT-4040-1 05 Aug 2026

break this line

LEAHI-TD-FIRMWARE-LDT-4033-1 05 Aug 2026

This was correct. Rever back the inputs and outputs.

LEAHI-APPLICATION-LDT-4767-1 31 Jul 2026

update to use FW enum

LEAHI-TD-FIRMWARE-LDT-4031-1 31 Jul 2026

Add to inputs: preTreatmentStatePublishInterval

LEAHI-TD-FIRMWARE-LDT-4063-1 04 Aug 2026

align comment

LEAHI-TD-FIRMWARE-LDT-4040-1 23 Jul 2026

break this line

LEAHI-APPLICATION-LDT-4959-1 28 Jul 2026

remove this or allowFloat

LEAHI-TD-FIRMWARE-LDT-4031-1 31 Jul 2026

Can we align like this
result = u32BroadcastIntervalOverride( message,
&preTreatmentStatePublishInterval,
TASK_GENERAL_INTERVAL );

LEAHI-TESTSUITES-LDT-3447-1 29 Jul 2026

This file is added in Create treatement and removed the file in this branch

LEAHI-TD-FIRMWARE-LDT-4072-2 31 Jul 2026

break this line

LEAHI-TD-FIRMWARE-LDT-4072-2 31 Jul 2026

input is none

LEAHI-TD-FIRMWARE-LDT-4072-2 31 Jul 2026

assign this to a variable and then return the variable.

break this line

LEAHI-TD-FIRMWARE-LDT-4063-1 04 Aug 2026

Please confirm if the source is DD?

LEAHI-TD-FIRMWARE-LDT-4040-1 04 Aug 2026

initialized using resetRinsebackFlags()

LEAHI-TESTSUITES-LDT-3670-1 05 Aug 2026

Removed the tst_new_design_createrx file and updated the tst_create_treatment

LEAHI-TESTSUITES-LDT-3670-1 05 Aug 2026

Removed the test scripts

LEAHI-TD-FIRMWARE-LDT-4040-1 23 Jul 2026

Outputs:
Add targetRinsebackVolumePlusAdditional_mL
Update spelling for :cummulativeRinsebackVolume_mL

LEAHI-TD-FIRMWARE-LDT-4072-2 31 Jul 2026

can we define this as NUM_OF_BATTERY_REGISTERS = BATTERY_END_OF_LIST_TIME_TO_PUBLISH,

and use NUM_OF_BATTERY_REGISTERS everywhere instead of using [ NUM_OF_BATTERY_REGISTERS - 1 ]

LEAHI-TD-FIRMWARE-LDT-4072-2 05 Aug 2026

add space in [ ]

LEAHI-TD-FIRMWARE-LDT-4033-1 05 Aug 2026

Inputs : fpgaSensorReadings
Outputs: none

LEAHI-APPLICATION-LDT-4959-1 31 Jul 2026

BN approves

LEAHI-TESTSUITES-LDT-3814-1 03 Aug 2026

Using the lambda updated the function

LEAHI-TD-FIRMWARE-LDT-4072-2 31 Jul 2026

Can we align = from line 270 to 281?

LEAHI-TD-FIRMWARE-LDT-4063-1 04 Aug 2026

When we send any message to UI, usually add the message id in the doxygen header like this.

@details \b Message \b Sent: MSG_ID_TD_RESP_TREATMENT_PARAMS_TO_VALIDATE

Please refer to the function sendTreatmentParamsResponse()