•  

Comment Results

Review Name Created Custom Fields Content
LEAHI-TD-FIRMWARE-LDT-4063-1 31 Jul 2026

break this line

LEAHI-TD-FIRMWARE-LDT-4063-1 31 Jul 2026

align comment

LEAHI-TD-FIRMWARE-LDT-4063-1 31 Jul 2026

Should we move this up before the test functions?

LEAHI-TD-FIRMWARE-LDT-4063-1 31 Jul 2026

why is this line commented out? Should we remove it or add a TODO?

LEAHI-TD-FIRMWARE-LDT-4063-1 31 Jul 2026

add @messages MSG_ID_TD_UI_GENERIC_CONFIRMATION_REQUEST

LEAHI-TD-FIRMWARE-LDT-4063-1 31 Jul 2026

Add @messages MSG_ID_TD_POST_FINAL_TEST_RESULT

LEAHI-TD-FIRMWARE-LDT-4031-1 30 Jul 2026

Set to local BOOL and then return the BOOL.

LEAHI-TD-FIRMWARE-LDT-4063-1 31 Jul 2026

What is the use case of including this header?

LEAHI-TD-FIRMWARE-LDT-4063-1 31 Jul 2026

output is none

LEAHI-TD-FIRMWARE-LDT-4063-1 31 Jul 2026

Remove blank line

LEAHI-TD-FIRMWARE-LDT-4072-2 31 Jul 2026

add a blank line above

LEAHI-TD-FIRMWARE-LDT-4072-2 31 Jul 2026

Rename to __BATTERY_DRIVER_H_

LEAHI-TD-FIRMWARE-LDT-4072-2 31 Jul 2026

break this line

LEAHI-TD-FIRMWARE-LDT-4033-1 05 Aug 2026

Fixed

LEAHI-TD-FIRMWARE-LDT-4072-2 31 Jul 2026

align comment

LEAHI-TD-FIRMWARE-LDT-4040-1 05 Aug 2026

break this line

LEAHI-TD-FIRMWARE-LDT-4072-2 31 Jul 2026

break lines of this function to match our standard of 100 columns.

LEAHI-TD-FIRMWARE-LDT-4072-2 31 Jul 2026

and break the line

LEAHI-DIALIN-LDT-4767-1 28 Jul 2026

add accept

LEAHI-APPLICATION-LDT-4959-1 31 Jul 2026

Do better BN approves

LEAHI-TD-FIRMWARE-LDT-4031-1 31 Jul 2026

While you are updating this file, can please break this line?

LEAHI-TD-FIRMWARE-LDT-4072-2 31 Jul 2026

align comment

LEAHI-TD-FIRMWARE-LDT-4072-2 31 Jul 2026

Should we remove APP_MONITORS and align with other header files.
Example: _BUTTONS_H_

LEAHI-APPLICATION-LDT-2428-1 02 Aug 2026

This was an onboarding test code and has been reviewed.

LEAHI-APPLICATION-LDT-2428-1 02 Aug 2026

Resolved.

LEAHI-TESTSUITES-LDT-2721-1 03 Aug 2026

moved to utility.py as per comment

LEAHI-TD-FIRMWARE-LDT-4063-1 31 Jul 2026

What is the use case of including this header?

LEAHI-TD-FIRMWARE-LDT-4072-2 30 Jul 2026

Please confirm if these are low-priority alarms at rank 999?

LEAHI-TESTSUITES-LDT-3814-1 16 Jul 2026

this does not work. if i replace 0 with 3 this still passes.

please update to use the lamba and test the value like the other test cases for all these

LEAHI-TD-FIRMWARE-LDT-4040-1 05 Aug 2026

break this line

LEAHI-TD-FIRMWARE-LDT-4072-2 31 Jul 2026

Should we move this to second number and add a blank line after it?

LEAHI-TESTSUITES-LDT-3447-1 04 Aug 2026

Removed the object

LEAHI-TESTSUITES-LDT-3447-1 04 Aug 2026

Added the test script which is same has in staging

LEAHI-TD-FIRMWARE-LDT-4040-1 23 Jul 2026

break this into two or more lines

LEAHI-DD-FIRMWARE-LDT-4049-1 06 Aug 2026

My understanding is that Standby should stop all pumps and heaters, including D108. Although the D108 driver implementation is not available yet, I thought keeping this call would preserve the intended Standby behavior and allow it to work once driver support is added. Could you please let me know if there is any concern with leaving it in place for now?

LEAHI-TD-FIRMWARE-LDT-4072-2 05 Aug 2026

Why are we changing the rank of an existing alarm?

LEAHI-TD-FIRMWARE-LDT-4040-1 23 Jul 2026

recirculateToBloodPrimeRequest is output.

LEAHI-TD-FIRMWARE-LDT-4072-2 04 Aug 2026

It looks like the rows may be misaligned with the alarm ID declarations.
For example, ALARM_ID_TD_BATTERY_CHARGER_ERROR_DETECTED is declared as 204.

LEAHI-TD-FIRMWARE-LDT-4040-1 05 Aug 2026

Add @message id MSG_ID_TD_UI_GENERIC_CONFIRMATION_REQUEST

LEAHI-TD-FIRMWARE-LDT-4063-1 05 Aug 2026

These new functions should be above the test functions.

Please align with the Messaging.c file.
It looks correct in the Messaging.c file.

LEAHI-TD-FIRMWARE-LDT-4033-1 05 Aug 2026

Inputs : fpgaSensorReadings
Outputs: none

LEAHI-DD-FIRMWARE-LDT-3975-2 05 Aug 2026

Add the comment.

LEAHI-DD-FIRMWARE-LDT-3975-2 05 Aug 2026

Delete empty line

LEAHI-APPLICATION-LDT-4767-1 31 Jul 2026

update to use Pre -tx iso state enum FW

LEAHI-TD-FIRMWARE-LDT-4072-2 31 Jul 2026

add a space before and after macro in [ ]

LEAHI-TD-FIRMWARE-LDT-4009-1 04 Aug 2026

updated

LEAHI-TD-FIRMWARE-LDT-4040-1 05 Aug 2026

Thank you for clarifying!

LEAHI-TD-FIRMWARE-LDT-4033-1 05 Aug 2026

Inputs : fpgaSensorReadings
Outputs: none

LEAHI-TD-FIRMWARE-LDT-4072-2 31 Jul 2026

add a space before and size in [ ]

LEAHI-TD-FIRMWARE-LDT-4072-2 31 Jul 2026

capitalize