Comment Search

align the comment

it stop gap to see if it was valve specific. Its been reverted.

so, are we removing this? I think it is better to have this as this might make it easier to get and validate the values in future. Not sure what others think.

Can we be a little more specific about what conductivity we are returning in these functions?
And I think we should include constants in the Inputs section of function headers.

will do in later branch

For testing purpose, Since UI board had old build so it was throwing the alarms

I see in the commits that you commented this #define was that on purpose?

Why did this file get deleted?

Remove blank line.

Why not "TRUE == "?

Why not "TRUE == "?

New code pushed

changed.

removed

So the same channels are used for both the Leahi and Denali?
I am not talking about how collisions are handled; that is handled by the CAN driver, not the FW or SW.
My point is that the CAN Channels by themselves do not have the meaning we want; they are only a priority.
As we defined them, we gave them a meaning as a category; therefore, it is better to name them the Denali/Leahi Channels rather than the CAN Channels.

BN resolves

Remove extra blank line.

even though we are sending U08 at Firmware. Due to structure padding Raw message for priority is converted as 16 bits. While receiving we need to read them as U16. Here is my debug values [CortexR4] ALARM_PROP_T size = 22 bytes
byte[0] = 0x03
byte[1] = 0x00
byte[2] = 0x6F
byte[3] = 0x00
byte[4] = 0x01
byte[5] = 0x00
byte[6] = 0x00
byte[7] = 0x01
byte[8] = 0x00
byte[9] = 0x00
byte[10] = 0x01
byte[11] = 0x00
byte[12] = 0x00
byte[13] = 0x01
byte[14] = 0x00
byte[15] = 0x00
byte[16] = 0x01
byte[17] = 0x00
byte[18] = 0x00
byte[19] = 0x01
byte[20] = 0x0A
byte[21] = 0x00

This is structure defined at firmware side
struct AlarmTableRequestPayload

;
typedef struct AlarmTableRequestPayload ALARM_PROP_T;

This code won't work. The sensor list missing the for loop that's populating it, and the original one is missing the M3 unpack. It's a merge of an old and a new code but both incomplete.

Please reference https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3480-1 for working solution on this.

For init functions, I'm ok with saying something like "Blood leak driver unit variables initialized".

Should the word "GENERIC" be in here somewhere?

updated now

Please confirm if these are low-priority alarms at rank 999?

Add @messages MSG_ID_TD_POST_SINGLE_TEST_RESULT