•  

Comment Results

Review Name Created Custom Fields Content
LEAHI-APPLICATION-LDT-4787-1 29 Jun 2026

BN approves

LEAHI-APPLICATION-LDT-4810-1 30 Jun 2026

remove

LEAHI-TESTSUITES-LDT-2278-1 30 Jun 2026

RESOLVED

LEAHI-APPLICATION-LDT-4810-1 30 Jun 2026

BN approves

LEAHI-DD-FIRMWARE-LDT-4719-1 30 Jun 2026

Suppose to use D74, Instead of D17 (for Control only).

LEAHI-DD-FIRMWARE-LDT-4410-3 26 Jun 2026

Same as above.

LEAHI-DIALIN-LDT-4734-1 01 Jul 2026

fixed. thanks!

LEAHI-DD-FIRMWARE-LDT-4734-1 01 Jul 2026

space after if.

LEAHI-DD-FIRMWARE-LDT-4539-1 30 Jun 2026

Add prevBalChamberState to input and output

LEAHI-TD-FIRMWARE-LDT-4616-1 02 Jul 2026

You also need to add these to the ALARM_RANK_TABLE (the table sorted by rank).

LEAHI-TD-FIRMWARE-LDT-4013-2 01 Jul 2026

Return type should be an enum (TREATMENT_TYPE_T).

LEAHI-TD-FIRMWARE-LDT-4013-2 02 Jul 2026

Align =

LEAHI-APPLICATION-LDT-4852-1 30 Jun 2026

add plugin for reading the checkin from UI/TD
1. Show SW -> FW checkin in some list appending or count

  • make the checkin enabled manually in CAN.py handle_messages()


2. Show on SIM when SW is not running - SW/FW Commincaiton failure

On application
1. When SIM is killed app shows alarm 100

LEAHI-DD-FIRMWARE-LDT-4734-1 01 Jul 2026

Please align the comments

LEAHI-TESTSUITES-LDT-2971-1 05 Feb 2026

Please remove squish import everywhere.
It is also duplicate here.

LEAHI-DD-FIRMWARE-LDT-4734-1 01 Jul 2026

fixed. thanks!

LEAHI-TD-FIRMWARE-LDT-4013-2 12 Jun 2026

Replace // to ///< for line 56 to 60

LEAHI-DD-FIRMWARE-LDT-4409-2 15 Jun 2026

Remove empty line.

LEAHI-APPLICATION-LDT-4852-1 02 Jul 2026

will investigate later

LEAHI-TESTSUITES-LDT-2951-1 17 Jun 2026

Nicholas Ramirez Could you please check why that is, what the difference is between the two, and whether there are any inconveniences with Dial-In we need to take care of?

LEAHI-TESTSUITES-LDT-2951-1 16 Jun 2026

I have updated the step by getting the value from rejections.conf file. For all the rejections message we will create new test script

LEAHI-TD-FIRMWARE-LDT-4875-1 01 Jul 2026

I don't think this is needed. You can't get to this else until the delay counter reaches this count.

LEAHI-DD-FIRMWARE-LDT-4539-1 30 Jun 2026

Add comments.

LEAHI-DD-FIRMWARE-LDT-4734-1 01 Jul 2026

Needs doxygen comments.

LEAHI-DIALIN-LDT-4484-1 23 Jun 2026

Remove extra spaces before comment

LEAHI-DIALIN-LDT-4484-1 29 Jun 2026

There is no Leahi or Denali CANChannels.
There are CAN channels and the naming is what that channel is being used for.
The collision occurs in the FW and the FW handles it before sending out a message.
When reading a CAN, there are no collisions, so there are no priorities. So I have no clue what you want here.

LEAHI-TD-FIRMWARE-LDT-2240-1 30 Jun 2026

Fix merge conflict stuff here.

LEAHI-TESTSUITES-LDT-2278-1 30 Jun 2026

rejection.conf file is available in /home/denali/Public/luis/config/configurations/Alarms/Rejections.conf in this path

LEAHI-TESTSUITES-LDT-2951-1 01 Jul 2026

BN approves

LEAHI-TD-FIRMWARE-LDT-4028-2 01 Jul 2026

Missing pinch valves (H1 and H19).

LEAHI-TESTSUITES-LDT-2839-1 06 Feb 2026

removed commented out code

LEAHI-TD-FIRMWARE-LDT-2240-1 30 Jun 2026

Fix merge conflict stuff here.

LEAHI-DIALIN-LDT-2316-1 06 Feb 2026

Done.

LEAHI-DD-FIRMWARE-LDT-2004-3 05 Feb 2026

Since fill and drain is a single time request and it is not a frequent request similar to supply during dialysate generation. I removed and now run as idle

LEAHI-DD-FIRMWARE-LDT-2004-3 06 Feb 2026

fixed it

LEAHI-DD-FIRMWARE-LDT-2004-3 06 Feb 2026

fixed it

LEAHI-DIALIN-LDT-4878-1 01 Jul 2026

Is this .wsl or .whl?

LEAHI-DD-FIRMWARE-LDT-2004-3 06 Feb 2026

fixed it

LEAHI-DD-FIRMWARE-LDT-2004-3 06 Feb 2026

fixed it

LEAHI-APPLICATION-LDT-4810-1 02 Jul 2026

BN resolves

LEAHI-DD-FIRMWARE-LDT-2004-3 06 Feb 2026

fixed it

LEAHI-DD-FIRMWARE-LDT-2004-3 06 Feb 2026

Fixed it

LEAHI-DD-FIRMWARE-LDT-2004-3 06 Feb 2026

fixed it

LEAHI-DIALIN-LDT-2316-1 06 Feb 2026

Can we make 255 a constant with a name like MAX_AIR_PUMP_POWER_LEVEL to make it clear what we're doing here?

LEAHI-DD-FIRMWARE-LDT-3222-1 06 Feb 2026

We can update this function as part of another Jira ticket.

LEAHI-DIALIN-LDT-2994-3 06 Feb 2026

I don't think it's an enum at all. It was a list, but it was never updated, so I added that part to it.

LEAHI-DIALIN-LDT-3350-1 06 Feb 2026

We agreed to change back the enums into the static variation.
Why would that cover a class that has been implemented to mask the enums from direct access, so if they need to be changed to dynamic or renamed or anything, the other repositories that are using them through this class won't be affected or need any update.

LEAHI-DIALIN-LDT-2994-3 06 Feb 2026

Is this a dynamic enum?

LEAHI-DIALIN-LDT-2994-3 06 Feb 2026

I see it as a list, don't know why it is named enum or what the original purpose of it was.
It was never updated, so I added the update part at least, so it will at least reflect the current states instead of always stating zeros.

LEAHI-DD-FIRMWARE-LDT-2004-3 06 Feb 2026

Remove extra blank line.