•  

Comment Results

Review Name Created Custom Fields Content
LEAHI-TESTSUITES-LDT-2741-1 02 Feb 2026

updated

LEAHI-TESTSUITES-LDT-2278-1 16 Jun 2026

Added the variable for the path

LEAHI-DD-FIRMWARE-LDT-3343-1 03 Feb 2026

For these functions that set specific valves, we should specify which (e.g. recovery valves or balancing chamber valves, or ...).

LEAHI-TD-FIRMWARE-LDT-1415-1 04 Feb 2026

Looks like this reverted back.

LEAHI-APPLICATION-LDT-4561-1 18 Jun 2026

resolved

LEAHI-TD-FIRMWARE-LDT-1415-1 04 Feb 2026

Removed

LEAHI-TESTSUITES-LDT-2951-1 17 Jun 2026

Nicholas Ramirez Please investigate the Dial-In code.

LEAHI-TD-FIRMWARE-LDT-1415-1 04 Feb 2026

Yes, updated

LEAHI-APPLICATION-LDT-3307-1 04 Feb 2026

updated

LEAHI-APPLICATION-LDT-3307-1 04 Feb 2026

the changes are alreadyy in the one in td folder and I do not see this file in project or the .pro.

LEAHI-APPLICATION-LDT-3307-1 04 Feb 2026

moved and updated all isntances

LEAHI-APPLICATION-LDT-3307-1 04 Feb 2026

added comment

LEAHI-TD-FIRMWARE-LDT-1415-1 04 Feb 2026

Remove blank line.

LEAHI-TD-FIRMWARE-LDT-1415-1 04 Feb 2026

It's still UI only. Shouldn't this be commented out before we merge?

LEAHI-TESTSUITES-LDT-2741-1 04 Feb 2026

should be utility.aut() if you only want "leahi" utility.aut(""-E")) if you want "leahi -E" only pass in arguemets and remove name parameter in our aut() method

LEAHI-TESTSUITES-LDT-2741-1 04 Feb 2026

update all "leahi" to utility.aut()

LEAHI-TESTSUITES-LDT-2741-1 04 Feb 2026

update to utility.aut("-q")

LEAHI-TESTSUITES-LDT-2741-1 04 Feb 2026

update to utility.aut()

LEAHI-TESTSUITES-LDT-2741-1 04 Feb 2026

update to utility.aut()

LEAHI-TESTSUITES-LDT-2741-1 04 Feb 2026

update to utility.aut("-E")

LEAHI-TD-FIRMWARE-LDT-1415-1 04 Feb 2026

Commented out already but I dont know why it is showing the same

LEAHI-DD-FIRMWARE-LDT-1473-1 04 Feb 2026

For spent chamber fill, we don't know how low the liquid level is ( in Chamber H) and hence decided not to turn on the trimmer heater for safety reasons. For bicarb fill, the dry bicart code should cover the actuators status. the current bicarb chamber fill code here should be updated with the newly implemented dry bi cart code changes.

LEAHI-DD-FIRMWARE-LDT-1473-1 04 Feb 2026

Since trimmer heater is enabled, no need of temp compensation. only for testing purposes, temp compensation is needed. Hence by default, temp compensation is disabled.

LEAHI-DD-FIRMWARE-LDT-1473-1 04 Feb 2026

Done

LEAHI-DD-FIRMWARE-LDT-1473-1 04 Feb 2026

Done.

LEAHI-APPLICATION-LDT-3307-1 05 Feb 2026

text removed

LEAHI-TESTSUITES-LDT-2971-1 05 Feb 2026

without squish import in utility file scripts will fail so added import squish line in utility.py and navigation.py file

LEAHI-DD-FIRMWARE-LDT-2004-3 05 Feb 2026

Please introduce test config for drybicart selection.

LEAHI-TESTSUITES-LDT-2971-1 05 Feb 2026

Removed the from squish import * line and keeping the import squish in utility.py and navigation.py files

LEAHI-DD-FIRMWARE-LDT-2004-3 05 Feb 2026

space after if. please fix it throughout the files.

LEAHI-DD-FIRMWARE-LDT-3222-1 03 Feb 2026

This function also not using u32ArrayOverride()

LEAHI-DIALIN-LDT-3350-1 02 Feb 2026

What is the use of this dictionary?

LEAHI-DD-FIRMWARE-LDT-3103-1 02 Feb 2026

Remove blank line.

LEAHI-TESTSUITES-LDT-2741-1 04 Feb 2026

remove argument and only pass in arguments.
name is always "leahi" so set it in here

LEAHI-TESTSUITES-LDT-2741-1 04 Feb 2026

update to utility.aut()

LEAHI-TD-FIRMWARE-LDT-4033-1 12 Jun 2026

remove this case

LEAHI-DD-FIRMWARE-LDT-2004-3 05 Feb 2026

I guess, Fill and Drain are priority items than the Supply request, which means upon request of fill and drain, state machine should service that operation.

Also, setting supply request should be based on the level sensor later (there shouldn't be any default request -> currently supply is assigned)

LEAHI-TD-FIRMWARE-LDT-4028-2 24 Jun 2026

I think we should accept this as long as we're in pre-tx: install state. User might confirm before auto-load finishes and that's ok.

LEAHI-DD-FIRMWARE-LDT-4612-1 24 Jun 2026

Can we bring depressurize as well one of the states like fill, supply and drain? And the same way when one of the operations initiated and other should not kick in.

LEAHI-TESTSUITES-LDT-3208-1 25 Jun 2026

yes Behrouz NematiPour this is not part of the pre tx anymore and the changes to this common file is happening in another test case

LEAHI-APPLICATION-LDT-4787-1 26 Jun 2026

updated

LEAHI-TESTSUITES-LDT-3153-1 11 Jun 2026

Take this in a global place.
Testing on the device will be different.

LEAHI-DIALIN-LDT-4787-1 29 Jun 2026

added name to freed up mesg id

LEAHI-TESTSUITES-LDT-2278-1 30 Jun 2026

RESOLVED

LEAHI-DD-FIRMWARE-LDT-4011-2 30 Jun 2026

yes

LEAHI-TESTSUITES-LDT-2278-1 30 Jun 2026

Same as the previous comments I wrote to make it compatible with the device and the VM, the base folders are different, and it's not always on the HOME.

LEAHI-TD-FIRMWARE-LDT-4875-1 02 Jul 2026

Yes, Fixed

LEAHI-TD-FIRMWARE-LDT-4063-1 22 Jun 2026

Use new generic confirmation approach.

LEAHI-TD-FIRMWARE-LDT-4063-1 22 Jun 2026

Replace with request code above.

LEAHI-DD-FIRMWARE-LDT-4409-2 16 Jun 2026

Do we need these comments? delete it if not required.