•  

Comment Results

Review Name Created Custom Fields Content
LEAHI-APPLICATION-LDT-4810-1 30 Jun 2026

bind to isWifiScanning

LEAHI-DD-FIRMWARE-LDT-4539-1 18 Jun 2026

We can combine all these condition checks in a single if() at line 423 separated by || and then we can send the event change in one line.
The code will still work if we remove the first condition check for prevState from line 427 and 431

LEAHI-DD-FIRMWARE-LDT-4719-1 01 Jul 2026

updated

LEAHI-DD-FIRMWARE-LDT-4719-1 01 Jul 2026

moved.

LEAHI-DIALIN-LDT-4484-1 01 Jul 2026

RESOLVED.

LEAHI-TESTSUITES-LDT-3427-1 15 Jun 2026

can you add this test case to the suite.conf file

LEAHI-TESTSUITES-LDT-3670-1 01 Jul 2026

why is this test case part of this feature? It should stay isolated in https://devapps.diality.us/cru/LEAHI-TESTSUITES-LDT-3946-1#details

LEAHI-DIALIN-LDT-4160-1 30 Jun 2026

Priority data type is U08?

LEAHI-DIALIN-LDT-4734-1 01 Jul 2026

Add uncompensated conductivity to the init too

LEAHI-APPLICATION-LDT-4852-1 02 Jul 2026

bn approves

LEAHI-APPLICATION-LDT-4852-1 29 Jun 2026

remove all ID_CANBusFaultCount logic if any

LEAHI-APPLICATION-LDT-4852-1 02 Jul 2026

BN approves

LEAHI-APPLICATION-LDT-4852-1 02 Jul 2026

bn approves

LEAHI-TD-FIRMWARE-LDT-4063-1 22 Jun 2026

No need to move else - not needed.

LEAHI-APPLICATION-LDT-4852-1 02 Jul 2026

BN approves

LEAHI-TD-FIRMWARE-LDT-2749-1 29 Jan 2026

This is not necessary - bubbleDetectionEnabled[] above takes care of this. Remove.

LEAHI-APPLICATION-LDT-3194-1 03 Feb 2026

Updated to align naming with regular ultrafiltration.

LEAHI-TD-FIRMWARE-LDT-4033-1 12 Jun 2026

Fixed

LEAHI-TD-FIRMWARE-LDT-1415-1 29 Jan 2026

Add space between = and (F32)

LEAHI-TD-FIRMWARE-LDT-2749-1 29 Jan 2026

Remove blank line.

LEAHI-TD-FIRMWARE-LDT-4013-2 12 Jun 2026

Use // comments for function prototypes.

LEAHI-APPLICATION-LDT-4787-1 25 Jun 2026

BN Approves

LEAHI-TD-FIRMWARE-LDT-4013-2 12 Jun 2026

add alarm

LEAHI-TESTSUITES-LDT-2278-1 16 Jun 2026

Added for different test case for this test case it is not used

LEAHI-APPLICATION-LDT-3194-1 29 Jan 2026

Properly align all typedefs.

LEAHI-APPLICATION-LDT-4511-1 18 Jun 2026

RESOLVED.

LEAHI-DD-FIRMWARE-LDT-2004-3 30 Jan 2026

right now, only bicarbChamberFillRequested is cleared during the supply. dryBiCartFillRequested and dryBiCartDrainRequested has a Fill/Drain complete state and it remains in that state to check completion state programmatically. an explicit clear request is required to start the next operation. Do I need to clear it ?

LEAHI-TESTSUITES-LDT-2278-1 22 Jun 2026

I am allowing a tolerance of 2 seconds between the expected time and the UI-displayed time.

LEAHI-DIALIN-LDT-3350-1 30 Jan 2026

can you remove this Opode as MODE_TPAR is obsolete and update the rest of the enumeration

LEAHI-DIALIN-LDT-4732-1 18 Jun 2026

Instead of removing, could you move them to the bottom of the list to prevent exceptions being thrown?

LEAHI-TESTSUITES-LDT-2971-1 30 Jan 2026

Why do you need this?
Is any editor used other than Squish?
We need to make sure it is running in the Squish IDE and with its tools on the build server.
Preferably, remove it to be consistent.

LEAHI-DD-FIRMWARE-LDT-3222-1 03 Feb 2026

is it possible to use the function u32ArrayOverride() here ?

LEAHI-DIALIN-LDT-2004-1 03 Feb 2026

@zoltan , could you please confirm whether this is the correct place for BICART_DATA ?

LEAHI-TESTSUITES-LDT-2951-1 26 Jun 2026

Updated the test script with TDTreaRinsebackStates

LEAHI-TD-FIRMWARE-LDT-4033-1 24 Jun 2026

We are already executing this from TaskGeneral.c. Remove from here.

LEAHI-DD-FIRMWARE-LDT-4734-1 01 Jul 2026

Remove empty line.

LEAHI-TD-FIRMWARE-LDT-4033-1 24 Jun 2026

Fixed

LEAHI-APPLICATION-LDT-4787-1 25 Jun 2026

BN Approves

LEAHI-TD-FIRMWARE-LDT-4063-1 22 Jun 2026

Remove this timer code and replace with getConfirmationRequestStatus() and, if status is Accepted, do confirmation code above. If status is Rejected or TimedOut, clear offRequestAwaitingUserConfirmation flag.

LEAHI-APPLICATION-LDT-4810-1 30 Jun 2026

BN approves

LEAHI-APPLICATION-LDT-4810-1 30 Jun 2026

BN approves

LEAHI-TESTSUITES-LDT-2278-1 01 Jul 2026

BN approvees

LEAHI-TESTSUITES-LDT-2819-1 01 Jul 2026

BN approves

LEAHI-DD-FIRMWARE-LDT-4734-1 01 Jul 2026

Space after if.

LEAHI-APPLICATION-LDT-4852-1 02 Jul 2026

will remove later after updating checkin, alarm status, and alarm trigger to new format

LEAHI-DD-FIRMWARE-LDT-4539-1 30 Jun 2026

Add isBalChamberSwitchingActive to input

LEAHI-TD-FIRMWARE-LDT-4013-2 01 Jul 2026

Return type should be an enum (FLUID_BOLUS_MEDIUM_T).

LEAHI-TD-FIRMWARE-LDT-4013-2 01 Jul 2026

What is the 3rd modality?

LEAHI-APPLICATION-LDT-4810-1 30 Jun 2026

rename to isWifiScanning

LEAHI-APPLICATION-LDT-4852-1 29 Jun 2026

remove if possible