•  

Comment Results

Review Name Created Custom Fields Content
LEAHI-DIALIN-LDT-4787-1 25 Jun 2026

Could you just leave it as or TBD_B7 = 0xB7 ?
So it will be easy to see that the msg id location is free to use

LEAHI-TD-FIRMWARE-LDT-4033-1 24 Jun 2026

Monitor is mis-spelled. Should be Control anyway. Move prior to execAlarmMgmt() above.

LEAHI-DIALIN-LDT-4484-1 29 Jun 2026

done

LEAHI-APPLICATION-LDT-4787-1 25 Jun 2026

change name to MTDPowerOffWarning

Move file to td/data

LEAHI-TD-FIRMWARE-LDT-4072-2 22 Jun 2026

( void )

LEAHI-APPLICATION-LDT-4810-1 30 Jun 2026

renamed to wifiModel

LEAHI-TD-FIRMWARE-LDT-4033-1 12 Jun 2026

command is a param

LEAHI-TESTSUITES-LDT-2278-1 15 Jun 2026

Make this a variable, and it will also differ on the device or the DevTest VM.

LEAHI-APPLICATION-LDT-4810-1 29 Jun 2026

check if we need :

LEAHI-TD-FIRMWARE-LDT-4063-1 22 Jun 2026

Remove. Replaced by generic confirmation functions and messages.

LEAHI-DIALIN-LDT-4484-1 25 Jun 2026

Please add a docstring for the function.
including the intention and parameters with their intentions.

LEAHI-DIALIN-LDT-4484-1 25 Jun 2026

Same for CanChannels.
The Channels we are referring to here are Leahi's or Denali's.
Channels mainly have no meaning beyond their priorities when a collision occurs.

LEAHI-DIALIN-LDT-4539-1 22 Jun 2026

Increment the event numbers.

LEAHI-APPLICATION-LDT-4852-1 29 Jun 2026

check if we can remove all action transmits

LEAHI-TD-FIRMWARE-LDT-4063-1 22 Jun 2026

No need for these elses.

LEAHI-TD-FIRMWARE-LDT-1415-1 26 Jan 2026

Fix indent on this case.

LEAHI-TD-FIRMWARE-LDT-1415-1 26 Jan 2026

Is there still a requirement to re-stabilize every 15 minutes (or some interval) in Leahi? It looks like Denali had such a requirement and it would jump back to STABILIZATION_2 state to do it. Since we don't have a STABILIZATION_2 state, we would need to jump back to STABILIZATION state instead.

LEAHI-DD-FIRMWARE-LDT-2030-2 02 Feb 2026

Remove blank line.

LEAHI-TD-FIRMWARE-LDT-4160-1 18 Jun 2026

Please convert the function to have only single point of return.
You can assign result = FALSE here.

Also check for whitespace characters. Use 4 spaces instead of tab.

LEAHI-TD-FIRMWARE-LDT-4033-1 12 Jun 2026

Added

LEAHI-TD-FIRMWARE-LDT-1415-1 29 Jan 2026

Updated

LEAHI-TD-FIRMWARE-LDT-1415-1 29 Jan 2026

Updated

LEAHI-TD-FIRMWARE-LDT-2749-1 29 Jan 2026

MSG_ID_TD_ENABLE_VENOUS_BUBBLE_ALARM

LEAHI-TD-FIRMWARE-LDT-2749-1 29 Jan 2026

Not needed. Remove.

LEAHI-DIALIN-LDT-2749-1 29 Jan 2026

Since this isn't an override, is this still appropriate?

LEAHI-TD-FIRMWARE-LDT-1415-1 28 Jan 2026

This function does not return next state.

LEAHI-TD-FIRMWARE-LDT-4875-1 01 Jul 2026

Is this necessary? Treatment paused state will do this.

LEAHI-TD-FIRMWARE-LDT-2749-1 29 Jan 2026

done.

LEAHI-TD-FIRMWARE-LDT-1415-1 29 Jan 2026

I removed

LEAHI-APPLICATION-LDT-4810-1 29 Jun 2026

check if we need :

LEAHI-TESTSUITES-LDT-2971-1 29 Jan 2026

after changing states to TREATMENT_DIALYSIS_STATE can you add the following line after

waitForObject(names.o_listView_Item)

LEAHI-APPLICATION-LDT-3194-1 03 Feb 2026

Updated to align naming with regular ultrafiltration.

LEAHI-TD-FIRMWARE-LDT-4063-1 22 Jun 2026

Remove.

LEAHI-APPLICATION-LDT-3194-1 03 Feb 2026

Updated.

LEAHI-DD-FIRMWARE-LDT-2004-3 30 Jan 2026

It looks to me like the state machine (drain for example) will keep running so long as the flag is true. I would think it should set the flag to false when drain is done.

LEAHI-DD-FIRMWARE-LDT-2004-3 30 Jan 2026

Fixed.

LEAHI-DD-FIRMWARE-LDT-2004-3 30 Jan 2026

Why is drain request flag different (ends in "ed")?

LEAHI-DD-FIRMWARE-LDT-2004-3 30 Jan 2026

Where do these request flags get set back to FALSE after request is serviced?

LEAHI-TESTSUITES-LDT-3153-1 15 Jun 2026

storing general configurations folder path in config.py

LEAHI-TD-FIRMWARE-LDT-3215-1 18 Jun 2026

Fixed

LEAHI-DD-FIRMWARE-LDT-4409-2 15 Jun 2026

Remove empty line

LEAHI-DD-FIRMWARE-LDT-4409-2 15 Jun 2026

We can keep it as handler instead of exec since this is being invoked from execMixingControl.

LEAHI-DIALIN-LDT-2004-1 03 Feb 2026

Based on the msg id, it should be here

LEAHI-DIALIN-LDT-3350-1 02 Feb 2026

Same here.

LEAHI-DIALIN-LDT-3350-1 02 Feb 2026

same here

LEAHI-APPLICATION-LDT-3194-1 29 Jan 2026

Delete file and remove from .pro.

LEAHI-DD-FIRMWARE-LDT-4409-2 16 Jun 2026

Align the indentation.

LEAHI-TESTSUITES-LDT-2971-1 30 Jan 2026

remove commented out line

LEAHI-APPLICATION-LDT-3307-1 03 Feb 2026

mvoe to TD file and remove file

LEAHI-DD-FIRMWARE-LDT-1473-1 02 Feb 2026

Mis-spelled "Stabilized".