Add a blank line before return statement.
Align the indentation.
RESOLVED.
Swap the order of these two.
updated
looks like this function sets the actuators every time when the same state is set by TD?
BN Approves
i am good with the implementaiton
i agree lets use the definitions in td_defs as these are the most updated ones and use TDTreaRinsebackStates.RINSEBACK_STOP_INIT_STATE.value
fixed
This is a duplicate (On functionality) of the 0xAF Tube set authentication, so please remove. See comment in the FW-SW Integration excel by the 0xAF for more details
pressure is a param
Change the name to ArterialWindow, Art is so confusing.
BN approves
Recommend changing "SETUP_CONNECTION" to "SETUP_TUBING_SET_CONNECTIONS" in these 2 msg ID names.
Move these functions to top area where all public functions defined. let's keep the static function after the public function.
Remove this function - replaced by generic confirmation functions.
Fix spelling in comment (membrane should not have a 'c' in it).
i pulled staging and should all be there
Removed the line
The difference between the actual pressure measured at bicart assembly and the measured D66 pressure based on the placement of the sensor.
remove this one
Fixed
done
I see the same implementations for set functions as well. So, I thought it is required and necessary.
testEnableVenousBubbleAlarm?
Should be ENABLE in this name somewhere.
Function needs function header comments (see other functions for example).
Align | separators all the way to right end of these 2 rows.
done.
remove the Path.home() and use the /home/denali/ On the device, it is not even in the home folder, so the path will be entirely different. on the VM:
conf_path = "/home/denali/Public/luis/config/configurations/" + Alarms/Rejections.conf
on the device, there MAY be something like this:
conf_path = "/opt/leahi/config/configurations/" + Alarms/Rejections.conf
If it's mixing control, then rename the parameters to reflect it, these names suggest a different module
Just curious, during stall condition RPM completely turns down to zero or close to zero (positive integer)?
please add message id.
after changing states to TREATMENT_DIALYSIS_STATE can you add the following line after waitForObject(names.o_listView_Item)
removed
resolved.
Remove the blank line
Update Input section: Balancing chamber state
Does this work? Have you tested it? It seems like while all are using equal, they should overwrite the previous one. It is just a preference; if you can't find a way, that's fine to leave it as it was.
Why do you need try-catch?
Updated.
Added to suite conf
I would think this would be enabled by default.
I would prefer to fix this in balancing chamber new algorithm implementation. That is why i didn't mark it as Unresolved.
Please pull the latest staging and update the test configs regarding that. I think the dry bicart test config is already there
Got a suggestion or an issue? Discuss it on the Atlassian Community or visit Atlassian Support for other options.
