Oh, what is the interval of the lambda call? I have never used it this way. Not sure if that is a good or bad idea. Did we check the performance, or if it blocks the test? Nicholas Ramirez Resolve if you are fine with the implementation.
Thank you for the details. I will leave this to Nicholas Ramirez to decide, and let's discuss if needed. We need to implement a Rejection reason test case and test all the reason IDs passed and the mapped texts displayed to the user in every situation.
the default timeout for the squish API is 20000ms and i thought 20 seconds was too long so we lowered it. I think there is a way to edit this default in the squish test suite settings
This is right, but we don't have a patient connection state implemented yet so we will get stuck here if we do this now. For now, comment out this line with a TODO to restore when patient connection state is implemented and add a temporary line of code to request treatment mode here.
Arpita, we don't want to use doxygen style comments for function prototypes since we cover functions with the function headers. so this is the proper type of comments.
This design is incorrect, For common codes, a proxy or a wrapper class should have been implemented. We will keep it for now to unblock the rest of the team.
Please consult the FW-SW integration xls file for MSG_ID reservations. Please add the ones you need to that list as without missing any reservations for IDs the randomly added IDs will be overwritten by reserved ones.
Being generic is the whole point of it. It was renamed because this is a dialin dedicated to Leahi unit and calling the messages DenaliMessage is misleading. It was renamed to CanMessage for 2 reason: 1. This is a Leahi only dialin, so there is no need to differentiate between different type of Can Messages as there would be only 1 type 2. Calling it CanMessage will make it more future compatible when the dialin get copied over for a new unit development (unlikely in the foreseeable future but possible), removing the need to rename it again
We can combine all these condition checks in a single if() at line 423 separated by || and then we can send the event change in one line. The code will still work if we remove the first condition check for prevState from line 427 and 431
