•  

Comment Results

Review Name Created Custom Fields Content
LEAHI-TD-FIRMWARE-LDT-4033-1 24 Jun 2026

These look like outputs to me (not inputs).

LEAHI-TD-FIRMWARE-LDT-4033-1 24 Jun 2026

I think all flags are outputs (not just adult).

LEAHI-TESTSUITES-LDT-3153-1 29 Jun 2026

RESOLVED

LEAHI-APPLICATION-LDT-4852-1 29 Jun 2026

replace with the actual updated way we send a message

LEAHI-APPLICATION-LDT-4810-1 30 Jun 2026

updated

LEAHI-TESTSUITES-LDT-2278-1 16 Jun 2026

What is 2?
What was 1?

LEAHI-TD-FIRMWARE-LDT-4160-1 18 Jun 2026

Why are we adding this header here?

LEAHI-APPLICATION-LDT-4810-1 29 Jun 2026

make into qml file InputDialog

LEAHI-APPLICATION-LDT-4810-1 29 Jun 2026

storage

LEAHI-APPLICATION-LDT-4810-1 30 Jun 2026

updated

LEAHI-DD-FIRMWARE-LDT-4011-2 01 Jul 2026

updated

LEAHI-DD-FIRMWARE-LDT-4410-3 22 Jun 2026

Initialize at init function.

LEAHI-DD-FIRMWARE-LDT-4539-1 30 Jun 2026

add prevDryBicartState to input and output.

LEAHI-DD-FIRMWARE-LDT-4734-1 01 Jul 2026

Align the indentation

LEAHI-APPLICATION-LDT-4852-1 29 Jun 2026

remove if possible

LEAHI-TD-FIRMWARE-LDT-4028-2 01 Jul 2026

Can we align comments?

LEAHI-TD-FIRMWARE-LDT-4033-1 12 Jun 2026

Fixed

LEAHI-APPLICATION-LDT-4511-1 18 Jun 2026

RESOLVED

LEAHI-TD-FIRMWARE-LDT-1415-1 28 Jan 2026

You added them, but you're not really using them and you're not using the tmp override either as far as I can see. Do we need any of these?

LEAHI-TESTSUITES-LDT-2741-1 19 Jan 2026

it looks like we keep adding a new variable for a specific arguement.

Lets make it more modular and create a function to pass in any arguement

Something like

def aut(name, *args):
    return " ".join((name, *args))"



and use it like

 aut("leahi", "-k", "-K", "-S", "-q")" 
LEAHI-TESTSUITES-LDT-1630-1 29 Jan 2026

remove line as treatment parameters has been removed

LEAHI-TD-FIRMWARE-LDT-2240-1 12 Jun 2026

To be restored?

LEAHI-TD-FIRMWARE-LDT-1415-1 29 Jan 2026

No, by mistake I copy pasted the same

LEAHI-TD-FIRMWARE-LDT-1415-1 28 Jan 2026

Align function name with others (1 more space before name).

LEAHI-DIALIN-LDT-4612-1 12 Jun 2026

remove blank space before =

LEAHI-TD-FIRMWARE-LDT-2749-1 29 Jan 2026

removed.

LEAHI-DIALIN-LDT-3350-1 03 Feb 2026

removed commented out line

LEAHI-APPLICATION-LDT-3194-1 29 Jan 2026

Change to remove 'Goal' from filename.

LEAHI-DD-FIRMWARE-LDT-3343-1 04 Feb 2026

Updated

LEAHI-TESTSUITES-LDT-2971-1 30 Jan 2026

should this method be moved to navigation.py?

LEAHI-DD-FIRMWARE-LDT-4409-2 15 Jun 2026

Initialize result to open loop state and remove the open loop state assignment later.

LEAHI-DD-FIRMWARE-LDT-4485-1 16 Jun 2026

Remove blank line.

LEAHI-TD-FIRMWARE-LDT-3215-1 18 Jun 2026

Fixed

LEAHI-TD-FIRMWARE-LDT-4063-1 24 Jun 2026

Output is none

LEAHI-TD-FIRMWARE-LDT-3215-1 18 Jun 2026

Add alarm : ALARM_ID_TD_REPEATED_AIR_TRAP_LOWER_EVENTS

LEAHI-TD-FIRMWARE-LDT-4028-2 01 Jul 2026

Remove this blank line.

LEAHI-DIALIN-LDT-4612-3 18 Jun 2026

Please maintain the FW-SW Integration.xlsx for MSG_ID reservation.
Meaning, add these there too to avoid overwriting or deleting them

LEAHI-APPLICATION-LDT-4511-1 18 Jun 2026

RESOLVED.

LEAHI-APPLICATION-LDT-4511-1 18 Jun 2026

RESOLVED.

LEAHI-TD-FIRMWARE-LDT-4063-1 22 Jun 2026

add a blank line above this comment.

LEAHI-TD-FIRMWARE-LDT-4063-1 22 Jun 2026

Move this to Messaging.c

LEAHI-DD-FIRMWARE-LDT-4410-3 25 Jun 2026

it shouldn't be the default value

LEAHI-APPLICATION-LDT-4787-1 23 Jun 2026

remoived

LEAHI-TD-FIRMWARE-LDT-4033-1 24 Jun 2026

BPModule is just one of the controllers - move this up into the controllers section.

LEAHI-TESTSUITES-LDT-3120-1 26 May 2026

The test should verify that the config file content is displayed and should not be hard-coded.
So, there should be a function that reads and retrieves the values defined in the conf file, rather than being hard-coded here, and then compares them with the SW Application dialog content.

LEAHI-TD-FIRMWARE-LDT-4033-1 24 Jun 2026

Fixed

LEAHI-TD-FIRMWARE-LDT-4033-1 24 Jun 2026

Fixed

LEAHI-TD-FIRMWARE-LDT-4033-1 24 Jun 2026

Fixed

LEAHI-DIALIN-LDT-4612-3 24 Jun 2026

Update the name.

LEAHI-APPLICATION-LDT-4747-1 23 Jun 2026

comment crapized