•  

Comment Results

Review Name Created Custom Fields Content
LEAHI-TD-FIRMWARE-LDT-3215-1 18 Jun 2026

Fixed

LEAHI-TD-FIRMWARE-LDT-4160-1 18 Jun 2026

Add space : Change all sizeof(ALARM_ID_T) to sizeof( ALARM_ID_T )

LEAHI-TD-FIRMWARE-LDT-3215-1 18 Jun 2026

break it into two lines

LEAHI-APPLICATION-LDT-4787-1 23 Jun 2026

remove handle transmit.

LEAHI-TESTSUITES-LDT-2951-1 15 Jun 2026

can each tst_ be on a line, and break these down into lines with some \ or something?

LEAHI-TESTSUITES-LDT-2951-1 15 Jun 2026

Please shortly explain the lambda use case her.

LEAHI-DD-FIRMWARE-LDT-4539-1 18 Jun 2026

prevDryBicartState

LEAHI-DD-FIRMWARE-LDT-4539-1 18 Jun 2026

Space after 0

LEAHI-TESTSUITES-LDT-2951-1 15 Jun 2026

doesn't the TXStates.RINSEBACK_STOP_INIT_STATE need " .value " like the other enums?

LEAHI-TESTSUITES-LDT-3447-1 17 Jun 2026

please add report to JIRA ticket

LEAHI-DIALIN-LDT-3160-1 27 Jan 2026

ENABLE_DRY_BICART_FILL vs ENABLE_LIQUID_BICARB => we can use only one of these. We can keep test config 2 ( may rename as ENABLE_DRY_BICARB) and 8 can be deleted.

LEAHI-TD-FIRMWARE-LDT-2749-1 02 Feb 2026

input and output is not updated properly

LEAHI-TD-FIRMWARE-LDT-1415-1 28 Jan 2026

Updated

LEAHI-TD-FIRMWARE-LDT-4033-1 12 Jun 2026

I fixed it but it is not showing in crucible

LEAHI-TD-FIRMWARE-LDT-1415-1 28 Jan 2026

Yes, deleted

LEAHI-TD-FIRMWARE-LDT-1415-1 26 Jan 2026

Why are we making this change? It doesn't look correct to have a LongCount capped with a ShortCount and SIZE.

LEAHI-TD-FIRMWARE-LDT-4033-1 12 Jun 2026

break this into two lines

LEAHI-TESTSUITES-LDT-2971-1 29 Jan 2026

Modified the step to get all elements in the list dynamically and performing the action based on user input

LEAHI-DD-FIRMWARE-LDT-2004-3 02 Feb 2026

fixed it

LEAHI-TD-FIRMWARE-LDT-4033-1 12 Jun 2026

Fixed

LEAHI-TD-FIRMWARE-LDT-2749-1 29 Jan 2026

done.

LEAHI-TD-FIRMWARE-LDT-2749-1 29 Jan 2026

done.

LEAHI-DIALIN-LDT-2749-1 29 Jan 2026

done

LEAHI-TD-FIRMWARE-LDT-2749-1 29 Jan 2026

Update function name to match actual name. Remove references to standby mode - function should work in any mode.

LEAHI-TD-FIRMWARE-LDT-4013-2 12 Jun 2026

Either no comment or // comment for function prototypes since doxygen captures function details from function headers.

LEAHI-DD-FIRMWARE-LDT-2004-3 02 Feb 2026

fixed it

LEAHI-TD-FIRMWARE-LDT-2240-1 12 Jun 2026

Are these being initialized in the init function?

LEAHI-TD-FIRMWARE-LDT-2749-1 29 Jan 2026

Check msg payload length, set result to TRUE and set enable only if length is correct.

LEAHI-DIALIN-LDT-3350-1 03 Feb 2026

Look in the td_defs.py for the same comment.

LEAHI-APPLICATION-LDT-4747-1 25 Jun 2026

updatded al ltitles

LEAHI-TD-FIRMWARE-LDT-2749-1 29 Jan 2026

I would make another local variable (BOOL) above and set it per trinary operation and then pass the BOOL to the function.
I think we want to avoid complex logic or function calls as a function parameter per our coding standards.

LEAHI-TD-FIRMWARE-LDT-1415-1 28 Jan 2026

Missing param.

LEAHI-DD-FIRMWARE-LDT-3222-1 03 Feb 2026

I don't think valve needs to be initialized here. The for loop initializes it.

LEAHI-TESTSUITES-LDT-2971-1 29 Jan 2026

Added the line

LEAHI-TESTSUITES-LDT-3120-1 15 Jun 2026

Removed strings as per comment

LEAHI-APPLICATION-LDT-3194-1 30 Jan 2026

Updated.

LEAHI-TESTSUITES-LDT-3427-1 15 Jun 2026

why do we snooze for 2 min?

LEAHI-APPLICATION-LDT-3194-1 03 Feb 2026

Updated.

LEAHI-APPLICATION-LDT-3323-1 03 Feb 2026

Updated.

LEAHI-DIALIN-LDT-3350-1 03 Feb 2026

This is incorrect.
We should not create many objects for all the Enum classes in an API, and we should not use memory that may not even be in use.
We will keep it for now to unblock the rest of the team.

LEAHI-APPLICATION-LDT-3194-1 29 Jan 2026

Remove 'Goal' from variable name.

LEAHI-TESTSUITES-LDT-2741-1 02 Feb 2026

this function also contains Wi-Fi Screen Parameters and Navigate to Wi-Fi Screen from Device Settings is not required in others test scripts

LEAHI-DD-FIRMWARE-LDT-4409-2 15 Jun 2026

Remove the unused header file.

LEAHI-TESTSUITES-LDT-2971-1 03 Feb 2026

Method name is changed and added docstring and method is available in navigation.py file

LEAHI-TESTSUITES-LDT-2971-1 03 Feb 2026

try catch is removed

LEAHI-DD-FIRMWARE-LDT-2004-3 03 Feb 2026

It will be fixed in Balancing chamber re-implementation

LEAHI-APPLICATION-LDT-3194-1 29 Jan 2026

Inherit from MAbstract for all Ms in td directory.

LEAHI-APPLICATION-LDT-3194-1 29 Jan 2026

Add separator.

LEAHI-APPLICATION-LDT-3194-1 27 Jan 2026

Remove comment

LEAHI-APPLICATION-LDT-3194-1 27 Jan 2026

Add user waited too long.