•  

Comment Results

Review Name Created Custom Fields Content
LEAHI-DD-FIRMWARE-LDT-3222-1 03 Feb 2026

Are we sure about the reversing of states here? If we had this backward, I would think the Systems team would have had a much bigger complaint.
The description of their issue suggests that the 8 BC valves were correctly commanded to requested state except for the one they separately commanded earlier.
If we had this backward, I would think they would have said that all 8 valves did the wrong thing.

LEAHI-DD-FIRMWARE-LDT-1473-1 02 Feb 2026

What should trimmer heater be doing in these spent/bicarb chamber states?

LEAHI-TD-FIRMWARE-LDT-4033-1 11 Jun 2026

Add doxygen comment to right.

LEAHI-TESTSUITES-LDT-2741-1 28 Jan 2026

Add test start sections and end sections

LEAHI-TD-FIRMWARE-LDT-2749-1 29 Jan 2026

updated.

LEAHI-TD-FIRMWARE-LDT-1415-1 28 Jan 2026

I would say inputs and outputs are "none".

LEAHI-TD-FIRMWARE-LDT-1415-1 29 Jan 2026

Added param looks wrong.

LEAHI-TD-FIRMWARE-LDT-1415-1 26 Jan 2026

When comment is too far to right to align with other comments, use the following comment format:
<blank line>
/// comment...
#define ...
<blank line>

LEAHI-TD-FIRMWARE-LDT-1415-1 29 Jan 2026

Updated

LEAHI-APPLICATION-LDT-3194-1 30 Jan 2026

Updated.

LEAHI-DD-FIRMWARE-LDT-2004-3 02 Feb 2026

Why is this flag set to FALSE here in start state while the other request flags are set to FALSE in their completed states?

LEAHI-APPLICATION-LDT-3194-1 03 Feb 2026

User waited too long would follow the same rejected behavior, do we still need to show the specific rejection path for the user waiting too long?

LEAHI-DIALIN-LDT-3350-1 03 Feb 2026

Obviously not.
You were reminding me about backwards compatibility. This variable and class ensures that even with this major refactor to the enum structure, the current codebase remains working.

LEAHI-DIALIN-LDT-3350-1 03 Feb 2026

Look in the td_defs.py for the same comment.

LEAHI-APPLICATION-LDT-3194-1 29 Jan 2026

Change HD to TD if moved to td directory.

LEAHI-APPLICATION-LDT-3194-1 27 Jan 2026

Fix MSG description

LEAHI-TESTSUITES-LDT-2971-1 30 Jan 2026

Same (translation)

LEAHI-DIALIN-LDT-3350-1 02 Feb 2026

Not sure about this change. This script is used during the automated builds. Do you use this script anywhere else?

LEAHI-DD-FIRMWARE-LDT-2030-2 02 Feb 2026

Remove extra blank line.

LEAHI-DD-FIRMWARE-LDT-3160-1 27 Jan 2026

SPENT_CHAMBER_H_FILL

LEAHI-TD-FIRMWARE-LDT-1415-1 28 Jan 2026

Added

LEAHI-TD-FIRMWARE-LDT-1415-1 28 Jan 2026

Once I get latest staging I will update this

LEAHI-TESTSUITES-LDT-2971-1 02 Feb 2026

All strings are placed in config.py

LEAHI-DIALIN-LDT-3350-1 02 Feb 2026

same

LEAHI-APPLICATION-LDT-3194-1 29 Jan 2026

Rename to add *Stack.qml. Update Duration as well.

LEAHI-DIALIN-LDT-3350-1 02 Feb 2026

Are these part of FPTemperatureSensorName class?

LEAHI-DD-FIRMWARE-LDT-1473-1 02 Feb 2026

I think you can do this in 1 line of code using the RANGE macro in Common.h.

LEAHI-DD-FIRMWARE-LDT-2004-3 03 Feb 2026

Remove extra blank line.

LEAHI-DD-FIRMWARE-LDT-4409-2 15 Jun 2026

can't we use DialsysateConductivity - local variable instead of getTargetCond()?

LEAHI-DD-FIRMWARE-LDT-4409-2 15 Jun 2026

Add headers for all below functions.

LEAHI-DD-FIRMWARE-LDT-4409-2 15 Jun 2026

Rmove extra blank line

LEAHI-TD-FIRMWARE-LDT-4013-2 15 Jun 2026

Thank you for the clarification!

LEAHI-TESTSUITES-LDT-3153-1 15 Jun 2026

changed direct file path to dynamic user perspective and storing general configurations folder path in config.py

LEAHI-TD-FIRMWARE-LDT-4013-2 15 Jun 2026

Add newAlarmIndicateStop to input and output.

LEAHI-TD-FIRMWARE-LDT-4013-2 15 Jun 2026

Add newAlarmIndicateStop to output

LEAHI-TD-FIRMWARE-LDT-4013-2 15 Jun 2026

Add alarm ALARM_ID_TD_EMPTY_SALINE_BAG

LEAHI-DIALIN-LDT-4612-1 12 Jun 2026

align the indent or remove blank space before =

LEAHI-TESTSUITES-LDT-2951-1 15 Jun 2026

For TXStates.RINSEBACK_STOP_INIT_STATE does not require ".value"

LEAHI-TESTSUITES-LDT-2951-1 15 Jun 2026

For TX states does not require the ".value"

LEAHI-DD-FIRMWARE-LDT-4409-2 16 Jun 2026

Michaels latest code resolved this issue. make sure when you merge to staging, pull the latest from staging. Check with Michael on code commit in staging.

LEAHI-TESTSUITES-LDT-2951-1 16 Jun 2026

Added the separate line for each test cases, using \ getting error

LEAHI-DD-FIRMWARE-LDT-4409-2 15 Jun 2026

Update state name matching handler name.

LEAHI-TESTSUITES-LDT-2951-1 17 Jun 2026

we can make a function to just

def rinsebackrequest_Check():
return rinsebackrequest == 8

if this works better? but well have alot more functions elsewhere. Let us know Behrouz NematiPour but the majority of the test cases do indeed use the lambda

LEAHI-TESTSUITES-LDT-3427-1 18 Jun 2026

To genarate the graph it will take time so added wait here

LEAHI-TD-FIRMWARE-LDT-3215-1 18 Jun 2026

Fixed

LEAHI-TD-FIRMWARE-LDT-3215-1 12 Jun 2026

Use ternary operator to assign true or false.

LEAHI-TD-FIRMWARE-LDT-3215-1 18 Jun 2026

add airTrapLowerEventCount to input

LEAHI-TD-FIRMWARE-LDT-3215-1 18 Jun 2026

Fixed

LEAHI-TD-FIRMWARE-LDT-3215-1 18 Jun 2026

Fixed

LEAHI-TD-FIRMWARE-LDT-3215-1 18 Jun 2026

Fixed