•  

Comment Results

Review Name Created Custom Fields Content
LEAHI-DD-FIRMWARE-LDT-4409-2 09 Jun 2026

Can this be assigned during declaration time?

LEAHI-DIALIN-LDT-4612-1 11 Jun 2026

Rename to CanChannels

LEAHI-TD-FIRMWARE-LDT-4033-1 11 Jun 2026

I think p comes before u. Move up one.

LEAHI-DD-FIRMWARE-LDT-2004-1 26 Jan 2026

teensy wants to parse commands with a , when it has parameters. Lots of string searching with length(), startsWith(), readStringUntil(), and indexOf(). We needed to keep it a char array sowe dont have to refactor the command handler in teensy.

LEAHI-DD-FIRMWARE-LDT-2004-1 26 Jan 2026

fixed.

LEAHI-APPLICATION-LDT-4511-1 09 Jun 2026

add missing parameters to this

LEAHI-DD-FIRMWARE-LDT-2004-1 27 Jan 2026

Removed the ifdef here as these overrides still be used without breaking the teensy driver.
I can add it on request. Unsure if teensy will be tested long enough for them to use those overrides.

In the meantime,

MSG_ID_DD_FILTERED_COND_SENSOR_READINGS_OVERRIDE_REQUEST and MSG_ID_FP_FILTERED_COND_SENSOR_READINGS_OVERRIDE_REQUEST are still available to override the monitor/filtered data.

LEAHI-DD-FIRMWARE-LDT-2004-1 27 Jan 2026

for Teensy it is done at the driver as it is a part of the initialization sequence. See TEENSY_CMD_GET_EEPROM_DATA cmd.

LEAHI-TESTSUITES-LDT-2278-1 27 Jan 2026

Modified the step as per suggestion

LEAHI-DD-FIRMWARE-LDT-2004-1 27 Jan 2026

Temperature monitor only has getter's for d4 and d50 at the moment. It looks like that hasnt been refactored to consider all temp sensors.

LEAHI-DD-FIRMWARE-LDT-2004-1 27 Jan 2026

we need filtered values for various applications in the system. My question is should we be checking dialysate temperature using a filtered value or a sample point? This version showed that we want a sample point.

in Denali, looks like the HD got the filtered temperature value from the DG for checking dialysate temp alarms. Are we upholding that same design of using a filtered value for leahi dialysate temp?

LEAHI-DD-FIRMWARE-LDT-2004-1 27 Jan 2026

Not at the moment. This feature isnt expected to on the V2's. The v2's arent going to have ALY_LINEAR as that is one specific to the teensy sensors.

LEAHI-DD-FIRMWARE-LDT-2004-1 27 Jan 2026

Not here. This include was not in the right spot as we want the two drivers to be separated. the include is in the monitor

LEAHI-DD-FIRMWARE-LDT-2004-1 27 Jan 2026

fixed.

LEAHI-DD-FIRMWARE-LDT-2004-1 27 Jan 2026

fixed.

LEAHI-DD-FIRMWARE-LDT-2004-1 27 Jan 2026

Restore this blank line.

LEAHI-DD-FIRMWARE-LDT-2004-1 26 Jan 2026

Add comments to right.

LEAHI-DD-FIRMWARE-LDT-2004-1 26 Jan 2026

Should we have #ifdef here to determine which driver to initialize?

LEAHI-DD-FIRMWARE-LDT-2004-1 26 Jan 2026

Remove blank line.

LEAHI-DD-FIRMWARE-LDT-2004-1 27 Jan 2026

I don't see fix. Did you push fwcommon?

LEAHI-APPLICATION-LDT-3174-1 27 Jan 2026

added comment

LEAHI-APPLICATION-LDT-3174-1 27 Jan 2026

added correct color

LEAHI-APPLICATION-LDT-3174-1 27 Jan 2026

updated

LEAHI-APPLICATION-LDT-3174-1 27 Jan 2026

updated

LEAHI-APPLICATION-LDT-3174-1 27 Jan 2026

updated

LEAHI-APPLICATION-LDT-3174-1 27 Jan 2026

added back in with comment

LEAHI-APPLICATION-LDT-3174-1 27 Jan 2026

added

LEAHI-APPLICATION-LDT-3174-1 27 Jan 2026

uipdated

LEAHI-APPLICATION-LDT-3174-1 27 Jan 2026

updated

LEAHI-DIALIN-LDT-3160-1 27 Jan 2026

renamed

LEAHI-DIALIN-LDT-3160-1 27 Jan 2026

updated, thanks for the confirmation

LEAHI-DIALIN-LDT-3160-1 27 Jan 2026

updated

LEAHI-DD-FIRMWARE-LDT-2004-1 27 Jan 2026

Remove all of these blank lines please.

LEAHI-DIALIN-LDT-3160-1 27 Jan 2026

TEST_CONFIG_DD_ENABLE_DOSING_OPEN_LOOP_CONTROL

LEAHI-DIALIN-LDT-3160-1 27 Jan 2026

TEST_CONFIG_DD_ENABLE_SPENT_CHAMBER_H_FILL

LEAHI-DIALIN-LDT-3160-1 27 Jan 2026

TEST_CONFIG_DD_ENABLE_D79_PWM_CONTROL. On/Off control is default support.

LEAHI-DIALIN-LDT-3160-1 27 Jan 2026

TEST_CONFIG_DD_ENABLE_DIENER_1000_PUMP

LEAHI-APPLICATION-LDT-3194-1 27 Jan 2026

Remove iso functions.

LEAHI-DIALIN-LDT-2749-1 29 Jan 2026

Remove reset parameter - not an override function.

LEAHI-DD-FIRMWARE-LDT-2004-3 27 Jan 2026

quantity? Is this volume or rate or ...?

LEAHI-TD-FIRMWARE-LDT-2749-1 29 Jan 2026

done.

LEAHI-TD-FIRMWARE-LDT-2749-1 29 Jan 2026

done.

LEAHI-APPLICATION-LDT-3194-1 27 Jan 2026

Check if UF funcs can be removed as well.

LEAHI-APPLICATION-LDT-3194-1 27 Jan 2026

Name screens and indicate where the rejection reason is being shown.

LEAHI-DD-FIRMWARE-LDT-2004-1 27 Jan 2026

I think using filtered values for alarms makes sense.

LEAHI-APPLICATION-LDT-3194-1 27 Jan 2026

Updated.

LEAHI-TD-FIRMWARE-LDT-1415-1 28 Jan 2026

Added

LEAHI-TD-FIRMWARE-LDT-2749-1 29 Jan 2026

done

LEAHI-TD-FIRMWARE-LDT-1415-1 28 Jan 2026

TMP low and high pressure alarms should be here I think.

LEAHI-TD-FIRMWARE-LDT-1415-1 29 Jan 2026

Updated