Comment Search

Updated

move this into Post Treatment title

It's a class containing all the enums of the def file.
Yes we need them as many other Framework and huge amount of code are using them.

same

Fixed

I think this should be commented out before we merge to staging.

Add comment to right.

Align comment. Change "speed" to "rate in comment too.
Also, I don't see you initializing these rates.

TEST_CONFIG_DD_ENABLE_UF_TEMP_COMP. by default, temp compensation is disabled.

Sorry, updated

Added the line

Similarly, we can move this to line 282 and delete handleBPDriverClearCmdAfterAckState()

Bubble status, Low and high level level sensors.

we may just need 60 seconds to plot a line can we update to 60 and check if that works

Here is the latest list from fw

TEST_CONFIG_DD_FP_ENABLE_BETA_1_0_HW = 0, ///< Test configuration DD & FP enable Beta 1.0 hardware
TEST_CONFIG_FIRST = TEST_CONFIG_DD_FP_ENABLE_BETA_1_0_HW, ///< Test configuration first configuration.
TEST_CONFIG_DD_DISABLE_BC_PRESSURE_ALARMS, ///< Test configuration DD disabling BC pressure alarms
TEST_CONFIG_DD_ENABLE_DRY_BICARB, ///< Test configuration DD to use dry bicarb
TEST_CONFIG_DD_ENABLE_4WIRE_RINSE_PUMP, ///< Test configuration DD enable 4-wire rinse pump.
TEST_CONFIG_FP_SKIP_PRE_GEN_FLUSH, ///< Test configuration FP skip pre-gen flush
TEST_CONFIG_DD_ENABLE_DIENER_1000_PUMP, ///< Test configuration to use diener 1000 pump for D48
TEST_CONFIG_DD_ENABLE_D79_PWM_CONTROL, ///< Test configuration to switch to PWM control for D79
TEST_CONFIG_DD_ENABLE_SPENT_CHAMBER_H_FILL, ///< Test configuration DD enable spent chamber H fill
TEST_CONFIG_DD_DISABLE_CONDUCTIVITY_ALARMS, ///< Test configuration to disable DD conductivity alarms
TEST_CONFIG_FP_DISABLE_CONDUCTIVITY_ALARMS, ///< Test configuration to disable FP conductivity alarms
TEST_CONFIG_DD_ENABLE_DOSING_OPEN_LOOP_CONTROL, ///< Test configuration to switch to open loop control for concentrate dosing
TEST_CONFIG_DD_ENABLE_UF_TEMP_COMPENSATION, ///< Test configuration for enabling UF temperature compensation
NUM_OF_TEST_CONFIGS ///< Number of test configuration.

Added

Updated

Is this a rate too?

Why only these states are valid?

Format for params is: param name description
Add "psi" (name) between param and "Pressure value in PSI".

We can move this line to 247 and delete handleBPDriverSendCmdState()

Moved all the constants to config.py file

Updated.

As a general note, avoid try-catch.
Your code should be prepared for exceptions, not to be surprised.

Look in the td_defs.py for the same comment.