Comment Search

The monitor get's are filtered. Driver get's will pull one point of data. The old code was calling the get that was not filtered. Should dialysate temp check based off of a filtered value?

This was added as on bootup the registers were looking at beta 1.9 before, so the initialization was failing. Now that it is changed to look at beta 2 registers on bootup can we remove this as this is no longer required?

change to 250

With new ui change after click on confirm no need to change the mode Is this ok Can you please confirm

Does ModeTxParams.h exist? Didn't we change this to a service?

Fixed

will address it in new file created for mixing

Remove extra blank line.

All the different possible values for cmd in the command request message were added.

please removed commented code

When comment is above, use /// instead of ///<. And add blank lines before/after - doxygen seems to get confused about where to apply the comment without clear separation.

For long macros, consider moving doxygen comment from right side to line above with /// since right side won't line up with others.

Fixed it

Updated as per new modification

correct. It has been updated to call around based the build switch

#ifdef TEENSY for these new functions.

Can we do the separate outer bounds inside the setPressureLimitsToOuterBounds() function?

added faults for default cases in our handle functions.

Teensy will want to parse the commands as a string when it has >1 parameters in the command. Not every command has a parameter with it. it is copied over to condWriteCmdBuffer once we get the length from snprint()

Consider adding TUBE_SET_TYPE_UNKNOWN = 0 as first enum so you can initialize a type variable to something before we install/identify the type.

coefficient data has been updated and commented.

Probably shouldn't have "TEENSY" in the name. Non-teensy driver will probably need this too, so can be generic.

If no instance of this has a colored background, then can this be an Item instead of a Rectangle?

if the tx sub mode is going ot be removed this should be fine then

updated to use the generic override.

Both of you are correct, the generic override can be used.

Since we pack the payload outside of the generic override, for this situation we don't pack the reset byte and therefore will stay as a U32 which satisfies the FW constraint. The other concern I had was that the FW would not reply back with a test ACK back to dialin with this cmd, thus causing a timeout in the generic override function. This is address as all messages in the lookup table in FW will reply back with a test ACK.

Therefore im okay using the generic override method