•  

Comment Results

Review Name Created Custom Fields Content
BOOTLOADER-LEAH-1415-1 01 Oct 2024

I don't think you are doing a double buffer. Remove this note.

BOOTLOADER-LEAH-1415-1 20 Jan 2026

Do we need an end of group marker down here?

BOOTLOADER-LEAH-1415-1 20 Jan 2026

TODO

LEAHI-DD-FIRMWARE-LDT-2004-3 23 Jan 2026

Rename like DRAIN_BICART_PUMP_SPEED. update comment as cartridge drains at maximum speed.

LEAHI-APPLICATION-LDT-3174-1 22 Jan 2026

<Prefix @ for advanced mode>

LEAHI-DIALIN-LDT-2980-1 21 Jan 2026

Updated

LEAHI-APPLICATION-LDT-2937-1 21 Jan 2026

Updated.

LEAHI-APPLICATION-LDT-2937-1 21 Jan 2026

Updated.

LEAHI-DD-FIRMWARE-LDT-2004-3 21 Jan 2026

BICARB_CHAMBER_PERIODIC_FILL_TIME

LEAHI-TESTSUITES-LDT-2741-1 19 Jan 2026

can we give the back buttons a more descirptive name like

o_SettingsBase_backButton_UserMode

LEAHI-DD-FIRMWARE-LDT-2998-1 21 Jan 2026

An alarm is triggered in this function. Add to header.

LEAHI-APPLICATION-LDT-2937-1 20 Jan 2026

Remove if not necessary.

LEAHI-APPLICATION-LDT-2937-1 21 Jan 2026

I don't see the updates.

LEAHI-APPLICATION-LDT-3106-1 21 Jan 2026

Thanks for the update.
Please update the styles as well.

LEAHI-DD-FIRMWARE-LDT-2004-3 21 Jan 2026

Please rename as DRY_BICART_FILL_VENT_TIME_MS

LEAHI-TESTSUITES-LDT-2741-1 22 Jan 2026

Now I am using application_init.update_password_back_to_default_password() function copy password from system.dflt to system.conf as per comment

LEAHI-TESTSUITES-LDT-2741-1 22 Jan 2026

Add def aut(name, *args):
"""
Joins the executable name and argument
into a single command string
"""
return " ".join((name, *args))
function in utility.py and using it main script startApplication(utility.aut("leahi", "-E")) as per comment

LEAHI-TESTSUITES-LDT-2741-1 22 Jan 2026

Removed duplicate objects

LEAHI-APPLICATION-LDT-3174-1 22 Jan 2026

get more specific on opmode and parameter set

add TD -> SW -> UI

LEAHI-APPLICATION-LDT-3174-1 22 Jan 2026

go UI -> SW - TD and vice versa and update self test to do same

LEAHI-APPLICATION-LDT-3174-1 22 Jan 2026

change to 250

LEAHI-APPLICATION-LDT-3174-1 22 Jan 2026

add TODO comment i added for my simulation

LEAHI-APPLICATION-LDT-3174-1 22 Jan 2026

always show sub pages

LEAHI-DD-FIRMWARE-LDT-2977-1 23 Jan 2026

fixed for both _TO_PWM macros

LEAHI-DD-FIRMWARE-LDT-2977-1 23 Jan 2026

fixed.

LEAHI-APPLICATION-LDT-3174-1 23 Jan 2026

updated to alwas who sub steps

LEAHI-APPLICATION-LDT-3174-1 23 Jan 2026

updated

LEAHI-DD-FIRMWARE-LDT-2004-3 23 Jan 2026

Fixed it

LEAHI-DD-FIRMWARE-LDT-2004-3 21 Jan 2026

remove empty line.

LEAHI-DD-FIRMWARE-LDT-2004-3 21 Jan 2026

Remove this macro.

LEAHI-TESTSUITES-LDT-2971-1 26 Jan 2026

Updated

LEAHI-DD-FIRMWARE-LDT-2004-1 26 Jan 2026

our standard overrides for conductivity values is covered in the monitor. Set function for conductivity has been implemented.

LEAHI-DD-FIRMWARE-LDT-2004-1 26 Jan 2026

fixed.

LEAHI-APPLICATION-LDT-2937-1 20 Jan 2026

Get new message IDs from Dara.

LEAHI-APPLICATION-LDT-3174-1 22 Jan 2026

Pre-Treatment

LEAHI-APPLICATION-LDT-3174-1 22 Jan 2026

Remove wait retry and pre-tx participants

LEAHI-TESTSUITES-LDT-2971-1 26 Jan 2026

should this be MODE_TREA ?

LEAHI-DIALIN-LDT-3160-1 27 Jan 2026

renamed

LEAHI-DIALIN-LDT-3160-1 27 Jan 2026

Please sync all of these with Firmware order of definitions.

LEAHI-TD-FIRMWARE-LDT-1415-1 28 Jan 2026

Updated

LEAHI-DD-FIRMWARE-LDT-2004-3 22 Jan 2026

We should use the #defines for .override assignments (i.e. OVERRIDE_RESET or OVERRIDE_KEY).

LEAHI-DD-FIRMWARE-LDT-2004-3 22 Jan 2026

Remove extra blank line.

HD-DENBUG-335-1 04 Jun 2026

RESOLVED in CODE WALKTHROUGH

LEAHI-DD-FIRMWARE-LDT-2998-1 21 Jan 2026

These values should be retained for Beta 1.0

LEAHI-APPLICATION-LDT-2937-1 20 Jan 2026

Change id to _timeoutText.

LEAHI-APPLICATION-LDT-4511-1 10 Jun 2026

updated

LEAHI-APPLICATION-LDT-4511-1 10 Jun 2026

updated

LEAHI-APPLICATION-LDT-3106-1 23 Jan 2026

Updated.

LEAHI-DD-FIRMWARE-LDT-2004-3 23 Jan 2026

Fixed it

LEAHI-DD-FIRMWARE-LDT-2004-3 23 Jan 2026

Fixed it