LEAHI-DD-FIRMWARE-LDT-2998_Update Dialin to support any B1.9 FW and/or HW...

Activity

LEAHI-DD-FIRMWARE-LDT-2998-1 54

Keyboard shortcuts  
  • Summarize the review outcomes (optional)
     
    #permalink

    Details

    Warning: no files are visible, they have all been filtered.
    Participant Role Time Spent Comments Latest Comment
    Author & Moderator 9h 39m 28 Added
    Reviewer - 0% reviewed 1h 23m 3 Why are these items have been removed? If we no longer ne...
    Reviewer - 0% reviewed      
    Reviewer - Complete 1h 37m 1 These values should be retained for Beta 1.0
    Reviewer - Complete 1h 30m 5 An alarm is triggered in this function. Add to header.
    Reviewer - 0% reviewed      
    Reviewer - Complete 3h 31m 16 Please introduce the test config for Beta1.9 changes acro...
    Reviewer - 0% reviewed 10h 47m    
    Reviewer - 0% reviewed      
    Reviewer - 0% reviewed 0m    
    Reviewer - 0% reviewed      
    Reviewer - 0% reviewed 33m 1 This should be before high, it feels wrong to have the or...
    Reviewer - 0% reviewed      
    Reviewer - 0% reviewed      
    Reviewer - 0% reviewed      
    Reviewer - 0% reviewed      
    Total   29h 3m 54  
    #permalink

    Objectives

    There are no specific objectives for this review.

    Branches in review

    #permalink

    Issues Raised From Comments

    Key Summary State Assignee
    #permalink

    General Comments

    There are no general comments on this review.
    /firmware/.../Controllers/BalancingChamber.c Changed
    Open in IDE #permalink
    /firmware/App/Controllers/RinsePump.c Changed
    Open in IDE #permalink
    /firmware/App/Controllers/Valves.c Changed
    Open in IDE #permalink
    /firmware/App/Drivers/PressureSensor.c Changed
    Open in IDE #permalink
    /firmware/App/Drivers/PressureSensor.h Changed
    Open in IDE #permalink
    /firmware/App/Drivers/TemperatureSensors.c Changed 3
    Open in IDE #permalink
    /firmware/App/Drivers/TemperatureSensors.h Changed
    Open in IDE #permalink
    /firmware/App/.../FPModes/ModePreGenPermeate.c Changed
    Open in IDE #permalink
    /firmware/App/Modes/ModeGenDialysate.c Changed 4
    Open in IDE #permalink
    /firmware/App/Modes/ModeGenDialysate.h Changed
    Open in IDE #permalink
    /firmware/App/Monitors/Level.c Changed 19
    Open in IDE #permalink
    /firmware/App/Monitors/Level.h Changed 2
    Open in IDE #permalink
    /firmware/App/Monitors/Pressure.c Changed
    Open in IDE #permalink
    /firmware/App/Monitors/Pressure.h Changed
    Open in IDE #permalink
    /firmware/App/Monitors/Temperature.c Changed 12
    Open in IDE #permalink
    /firmware/App/Monitors/Temperature.h Changed
    Open in IDE #permalink
    /firmware/App/Services/FpgaDD.c Changed 12
    Open in IDE #permalink
    /firmware/App/Services/FpgaDD.h Changed
    Open in IDE #permalink
    /firmware/App/Services/Messaging.c Changed
    Open in IDE #permalink
    /DDDefs.h Changed 2
    Open in IDE #permalink
    /MessagePayloads.h Changed
    Open in IDE #permalink
    /TestSupport.h Changed
    Open in IDE #permalink

    Review updated: Reload | Ignore | Collapse

    You cannot reload the review while writing a comment.

    Log time