Comment Search

It handles different size of payloads, and requests without payload without having an issue, so I don't understand why would it cause an issue.
you are sending a message with this msg id and this payload, if the FW is expecting that, then it will work.

Should I rename the cmd_generic_override to like cmd_generic_message_sender to be less confusing?

Rename file to Pre-Treatment

Updated based on FW

keep and add TODO comment

Remove extra blank line.

variable name has been update to: vTransmembranePressureLimitWindowRejectReason

for Rejection reason and reading text from configuration Rejections.conf file
conf_path = "/home/denali/Public/luis/config/configurations/Alarms/Rejections.conf"
repo = ScopedRejectionRepository(path=conf_path)
REJECT_TEXT = repo.get("1", "Title")

Instructions part updated in https://devapps.diality.us/cru/#LEAHI-TESTSUITES-LDT-3153-1CFR-82873
Removed hard coded instructions text and Now I am getting object id find and then clicking it
content_column = waitForObjectExists(names.o_PreTreatmentBase_contentColumn_Column)
values = utility.findAllObjectsById(content_column, "_message")
for content in values[1:4]:
mouseClick(content)

Make a local BOOL variable and assign it TRUE or FALSE with a ternary operator and then return that local BOOl variable.

I think timer should be internal (private) to this unit.

Change "is the" to "is in". Remove extra "and".

when are we closing D64 valve? handle the same in else block as well.

Does not seem to be updated, right?

added

please remove AUT_NAME and AUT_NAME_ONLY and update the other tests accordinglt please

fixed writing over the error count override.

Model ID isnt an override. Its a set as it does not revert back to another value. FW will be looking for only 1 U32 instead of a TEST_OVERRIDE_PAYLOAD_T.

the generic override will cause the FW to always reject the value since the payload size is not what is expected.

Update inputs/outputs. I think more have been added.

Missing comment to right

Rinseback is initiated by the user during end treatment.

variable name has been update to: vTransmembranePressureLimitWindowRejectReason

Removed.

Updated

For init functions, I think it's ok (and cleaner) to just say we initialize ALL unit variables.

I think this function should return TRUE if exempt (we are in first 10 seconds of flow control from off state). All criteria checked here in this function.

timeSinceP12Started?

This else could be removed if you just set next state to idle at top of function.