•  

Comment Results

Review Name Created Custom Fields Content
BOOTLOADER-LEAH-1415-1 17 Jan 2026

Done

BOOTLOADER-LEAH-1415-1 17 Jan 2026

I will implement the watchdog in the new branch.

BOOTLOADER-LEAH-1415-1 17 Jan 2026

I will implement the watchdog in the new branch.

BOOTLOADER-LEAH-1415-1 17 Jan 2026

Done

BOOTLOADER-LEAH-1415-1 17 Jan 2026

Added the return.

BOOTLOADER-LEAH-1415-1 17 Jan 2026

Removed the interrupt.

BOOTLOADER-LEAH-1415-1 17 Jan 2026

Done

BOOTLOADER-LEAH-1415-1 17 Jan 2026

Done

BOOTLOADER-LEAH-1415-1 17 Jan 2026

Added the return of a value.

BOOTLOADER-LEAH-1415-1 17 Jan 2026

The new update request is checked on top of the mode update exec function. If there is a new update, it will request a transition otherwise, this is a terminal state.

BOOTLOADER-LEAH-1415-1 17 Jan 2026

It is the update mode re-initialized. The initialization is done using other functions that have their own doxygen comments. Do I need to add more here?

BOOTLOADER-LEAH-1415-1 17 Jan 2026

Done

BOOTLOADER-LEAH-1415-1 17 Jan 2026

Removed the TODO.

BOOTLOADER-LEAH-1415-1 17 Jan 2026

Removed the variable.

BOOTLOADER-LEAH-1415-1 17 Jan 2026

Done

BOOTLOADER-LEAH-1415-1 17 Jan 2026

Done

BOOTLOADER-LEAH-1415-1 17 Jan 2026

Done

BOOTLOADER-LEAH-1415-1 17 Jan 2026

Done

BOOTLOADER-LEAH-1415-1 17 Jan 2026

It will be implemented in the new branch.

LEAHI-DIALIN-LDT-3159-1 19 Jan 2026

Based on it's code, doesn't look like it. That's why I removed the publish to not mislead.

LEAHI-DIALIN-LDT-3159-1 16 Jan 2026

DEF is short for de-featured? Not clear, whatever it means. Maybe we shouldn't abbreviate.

LEAHI-DIALIN-LDT-3159-1 16 Jan 2026

Is this callback function coming from a received message?

LEAHI-DIALIN-LDT-2004-1 17 Jan 2026

wrong valve name used , it should be spv

LEAHI-DD-FIRMWARE-LDT-1925-1 20 Jan 2026

Added

LEAHI-DD-FIRMWARE-LDT-1925-1 20 Jan 2026

We need to be calling the isPersistentAlarm function regardless of exemption, but only triggering the alarm if persistent alarm function returns TRUE and exemption is FALSE.

LEAHI-DIALIN-LDT-3159-1 19 Jan 2026

That's how it's called in the FW, I just copied it.
But yes, I suspect the Def is short for defeatured.

BOOTLOADER-LEAH-1415-1 01 Oct 2024

Add a blank line and an end of group marker at bottom of file.

LEAHI-TESTSUITES-LDT-3321-1 08 Jun 2026

renamed folder as per comment and added new name in suite.conf file

LEAHI-APPLICATION-LDT-3139-1 19 Jan 2026

removed

LEAHI-APPLICATION-LDT-3139-1 19 Jan 2026

removed

LEAHI-DD-FIRMWARE-LDT-4001-1 09 Jun 2026

added

LEAHI-TESTSUITES-LDT-2971-1 20 Jan 2026

Variable name has been updated

LEAHI-TESTSUITES-LDT-2971-1 19 Jan 2026

remove if not being used

BOOTLOADER-LEAH-1415-1 01 Oct 2024

Remove reference to double buffer.

LEAHI-DD-FIRMWARE-LDT-2004-3 23 Jan 2026

Fixed it.

LEAHI-APPLICATION-LDT-3106-1 21 Jan 2026

Removed.

LEAHI-DIALIN-LDT-611-1 19 Jan 2026

previously we had the unique keyword above our classes as a developer sanity check to ensure the dev didnt duplicate values in the dict since we dont auto generate this defs.

if i remember correctly, unique is checked when the enum class is imported. We test it our unit tests, both test_constructors and test_imports.

The reason we currently would want to keep unique is because the DialinEnum class has the method has_value(). Without knowing the current usage of this function from our users, it will impact users expected behavior.

My question to you: Should we continue to test and check how the defs for duplicates?

LEAHI-DD-FIRMWARE-LDT-3103-1 21 Jan 2026

Should we remove the condition instead of commenting it out?

LEAHI-DD-FIRMWARE-LDT-3103-1 21 Jan 2026

This is a testable value.

LEAHI-DD-FIRMWARE-LDT-2004-1 26 Jan 2026

removed from here.

LEAHI-DD-FIRMWARE-LDT-4485-1 09 Jun 2026

Please see if you can define a function to handle this and call that function here, to reduce the number of code lines in this function.

LEAHI-APPLICATION-LDT-2937-1 23 Jan 2026

Updated.

LEAHI-APPLICATION-LDT-2937-1 21 Jan 2026

I believe you may need to get the style header from his latest.
Arrow, streamlines, and the streamline title box coloring need to be updated as well.

LEAHI-APPLICATION-LDT-3106-1 20 Jan 2026

Is this one necessary?

LEAHI-DD-FIRMWARE-LDT-4001-1 10 Jun 2026

Please check with TD, I have seen one of the develop branch this populated in pre gen and gen.

LEAHI-TESTSUITES-LDT-2741-1 22 Jan 2026

Now I am using navigation.navigate_to_device_settings_screen() and it will use standby mode and then press settings as per comment

LEAHI-DD-FIRMWARE-LDT-2004-3 22 Jan 2026

Remove blank line.

LEAHI-APPLICATION-LDT-4581-1 10 Jun 2026

moved valves out

LEAHI-APPLICATION-LDT-3174-1 23 Jan 2026

updated vSettings.groupFormat to account for updated scheme

LEAHI-TD-FIRMWARE-LDT-4033-1 02 Jun 2026

Make sure UI s/w is looking for this message on the broadcast channel or change this channel to the TD=>UI channel if UI is looking for this message on that channel.