Remove reset override functions. Reset should be handled in the single (general) override command handler.
do you need to also register the following that are imported in main.qml? VTreatmentAdjustmentBolusVolume VTreatmentAdjustmentDurationEdit VTreatmentAdjustmentDurationConfirm VTreatmentAdjustmentSetPoints VTreatmentAdjustmentBloodFlowRate VTreatmentAdjustmentDialysateFlowRate VTreatmentAdjustmentDialysateTemperature
Properties are being set to zero by default.
Updated.
For all floats add F at the end, across the file.
changed this Ultrafiltration in one line
What about HDF?
Add blank line as required.
done
followed the pattern.
If there are no messages from the BloodLeak.h then we should remove the include.
Obsolete branch to be deleted. Closing reivew
Fixed
Updated the test scripts as per the suggestion
added comment
fixed it
Added
Remove extra blank line.
Add space between (( and )).
spelling error should be "title"
fixed. thanks!
added.
Updated the value to all combo boxes
removed
Updated the value to 120
Only need 2 message IDs here. In Leahi, we don't have separate messages for set vs. reset. Both set and reset are handled in the same message.
Remove "Set" from override function names. These 2 override functions should handle both set and reset (from msg payload).
Remove list of states from comment. It is not a complete list and we shouldn't even try to list them here anyway.
If you are overriding MSG_ID that's in use, please move it to it's new location instead of fully removing to avoid breaking the SW. MSG_ID_TD_SYRINGE_PUMP_DATA = 0xB1
From here forward, we can just call sendMessage() with appropriate params.
Initialize bpResults.
do we have to leave a blank line after this?
Is this normal UF volume or normal UF volume + Iso UF Volume?
View still exists, instance has been moved to main.qml
changed.
Which setting does this message confirm (duration or volume)?
Updated
ask sean
Remove change.
setNIBPCommand is a function, not a variable. I think Outputs should be "none"
I would like to ask to check out the substitution pump on the develop branch and update it based on that. There are some changes thanks to the merging of the refactor.
renamed to reflect whats on staging
M3 or P10 ? need a good documentation
sensor name required in comments
If this function is only called from here, should we just move the function's code into this function (i.e. combine the functions)?
Got a suggestion or an issue? Discuss it on the Atlassian Community or visit Atlassian Support for other options.
