•  

Comment Results

Review Name Created Custom Fields Content
LEAHI-DD-FIRMWARE-LDT-2030-2 12 Jan 2026

Ah, I see it now. But we haven't really addressed my original comment. I will resolve for now, but keep in mind that I'd like to avoid this kind of sequencing where we are declaring local variables below statements like on 948.

LEAHI-DD-FIRMWARE-LDT-3103-1 15 Jan 2026

Fixed it.

LEAHI-APPLICATION-LDT-2805-1 06 Jan 2026

Remove unnecessary parameters.

LEAHI-APPLICATION-LDT-2805-1 05 Jan 2026

Verify why the clamping is necessary.

LEAHI-APPLICATION-LDT-3139-1 08 Jan 2026

remove so we fit the exact image resoliution

LEAHI-DD-FIRMWARE-LDT-4001-1 11 Jun 2026

Change to pumpTargetRate since mL/min is a rate.

LEAHI-TD-FIRMWARE-LDT-3126-1 15 Jan 2026

Removed and updated

LEAHI-TD-FIRMWARE-LDT-4063-1 11 Jun 2026

Alarm id should be 196?
Description looks same as 194.

LEAHI-TD-FIRMWARE-LDT-4063-1 09 Jun 2026

Use generic confirmation functions/messages for off button.

LEAHI-APPLICATION-LDT-2805-1 06 Jan 2026

Updated.

LEAHI-APPLICATION-LDT-2805-1 05 Jan 2026

Verify what is being displayed for no value.

LEAHI-DD-FIRMWARE-LDT-3958-1 29 May 2026

I think we also need this to be uncommented, as we were running into an alarm because of this.

LEAHI-DD-FIRMWARE-LDT-2185-1 13 Jan 2026

We are not checking multiple temperatures here . Its only one temperature , eigther D1 or P10. in that case should remove the 's"

LEAHI-TD-FIRMWARE-LDT-4033-1 11 Jun 2026

Fixed

LEAHI-TD-FIRMWARE-LDT-4013-1 28 May 2026

Can we restore the real code here yet? Ask Dara.

HD-DENBUG-335-1 29 May 2026

Need to remove comment? or missing implementation?

LEAHI-TD-FIRMWARE-LDT-4009-1 29 May 2026

If we are in treatment end state, the treatment is completed (no need to check that) and I don't think iso UF is a modality.

LEAHI-DD-FIRMWARE-LDT-2030-2 07 Jan 2026

done

LEAHI-DD-FIRMWARE-LDT-3958-1 01 Jun 2026

Done.

LEAHI-TD-FIRMWARE-LDT-4013-1 01 Jun 2026

do we need this block?

LEAHI-DD-FIRMWARE-LDT-2030-2 07 Jan 2026

done.

LEAHI-DD-FIRMWARE-LDT-2030-2 07 Jan 2026

Please follow the examples in the code like
if (cmd < num_cmd)

Unknown macro: { memcpy }

else

Unknown macro: { fault alarm }


We should make sure the command is valid and them memcpy next.

LEAHI-DIALIN-LDT-2998-1 07 Jan 2026

Please follow the same naming convention as firmware enums.

LEAHI-DIALIN-LDT-2998-1 07 Jan 2026

You may use the same test configs from DD here, to set the relevant test configs from FP Dialin.

LEAHI-APPLICATION-LDT-2805-1 08 Jan 2026

Updated.

LEAHI-DD-FIRMWARE-LDT-2801-1 09 Jan 2026

Done

LEAHI-TD-FIRMWARE-LDT-4013-1 04 Jun 2026

Should this check be moved to the fluid bolus exec function?

LEAHI-TESTSUITES-LDT-2174-1 16 Jan 2026

Changed the value to 120

LEAHI-DD-FIRMWARE-LDT-2801-1 09 Jan 2026

It's Beta 1.9.

LEAHI-APPLICATION-LDT-3139-1 15 Jan 2026

add <> around placeholders

LEAHI-DD-FIRMWARE-LDT-2185-1 09 Jan 2026

This is a test support sub function.

LEAHI-DD-FIRMWARE-LDT-2030-2 07 Jan 2026

Remove merge conflict line here.

LEAHI-DD-FIRMWARE-LDT-2185-1 09 Jan 2026

space after =

LEAHI-DD-FIRMWARE-LDT-2185-1 13 Jan 2026

can we remove it?

LEAHI-DD-FIRMWARE-LDT-2185-1 14 Jan 2026

Fixed

LEAHI-DD-FIRMWARE-LDT-2185-1 14 Jan 2026

Fixed

LEAHI-TD-FIRMWARE-LDT-4329-1 08 Jun 2026

60 should be coming from somewhere. Is there not a treatment parameter for vitals measurement interval? I think we do (TREATMENT_PARAM_BP_MEAS_INTERVAL).

LEAHI-DD-FIRMWARE-LDT-2185-1 14 Jan 2026

Updated

LEAHI-DD-FIRMWARE-LDT-2185-1 14 Jan 2026

done

LEAHI-APPLICATION-LDT-4561-1 10 Jun 2026

if the tx sub mode is going ot be removed this shold be fine then

LEAHI-DD-FIRMWARE-LDT-4001-1 10 Jun 2026

fixed thanks

LEAHI-TD-FIRMWARE-LDT-4329-1 09 Jun 2026

Should the msg id be: MSG_ID_TD_VITALS_ADJUSTMENT_RESPONSE?

LEAHI-TD-FIRMWARE-LDT-4013-2 12 Jun 2026

Shouldn't we be checking tubing set type instead of modality here?

LEAHI-TD-FIRMWARE-LDT-4072-2 05 Jun 2026

Just use 0x0 and 0xFFFFFFFF

LEAHI-DD-FIRMWARE-LDT-2998-1 06 Jan 2026

Removed

LEAHI-APPLICATION-LDT-2805-1 05 Jan 2026

Check that View is renamed or removed.

LEAHI-TD-FIRMWARE-LDT-4009-1 29 May 2026

Just add this as an AND condition in the if statement above.

LEAHI-APPLICATION-LDT-2805-1 08 Jan 2026

Updated.

LEAHI-APPLICATION-LDT-3139-1 09 Jan 2026

added comment

LEAHI-DD-FIRMWARE-LDT-2030-2 07 Jan 2026

Remove extra blank line.