I guess all these MACRO implementations should move to function/s to compute the final acid and bicarb volume, that would help to calculate the volumes when Na and Bicarb params changed during treatment.
RI: as for the version, we are releasing version 0.5.6 (previous RC was build_1, this is build_3, but build_1 was never promoted to gold). If we need to upgrade the version as well (maybe because 0.5.6-build_1 was recorded as a released version in you QMS), please let me know and we'll re-release build_3 version as 0.5.7
I think we have to check whether the iso uf duration + treatment duration does not exceed maximum treatment duration. And I'm not sure if there is a minimum duration for iso uf, but if there is a minimum, it probably isn't the same as the minimum treatment duration.
Vinayakam Mani What is the advantage of doing that? If I go with Beta_1_9_HW, I will need to rename the flag when we start using Beta 2+. And rename it in all the scripts in different repository when starting with 2.0. While I use a more generic flag, I won't need to do that. So just using a better name I am sparing myself hours of work in the future.
Then the FPGA get function seems mis-named. Pulse width is not really the same as speed. It is the inverse of frequency, which can be converted to speed.
