•  

Comment Results

Review Name Created Custom Fields Content
LEAHI-DD-FIRMWARE-LDT-3173-1 09 Feb 2026

It is there in line 131

It would be nice to have it clubbed it together like

#ifdef _TEENSY_CONDUCTIVITY_DRIVER_
place all code for teensy here

Unknown macro: { MSG_ID_DD_SET_CONDUCTIVITY_MODEL_REQUEST, &testSetTeenyConductivityModel }

,
#else
// move the all code under #ifndef _TEENSY_CONDUCTIVITY_DRIVER_ here

#endif

LEAHI-DD-FIRMWARE-LDT-3173-1 09 Feb 2026

This is already initialized (properly) near top of function. It is not proper (zero) here.

LEAHI-DD-FIRMWARE-LDT-3103-1 10 Feb 2026

Looks like you updated wrong function (the one below instead of this one). It's an output in function below and it's an input in this function.

LEAHI-DIALIN-LDT-3287-1 10 Feb 2026

Duplicate, please remove

LEAHI-DD-FIRMWARE-LDT-2030-2 11 Feb 2026

Actually, for casting, I prefer no spaces around ().

LEAHI-DD-FIRMWARE-LDT-1473-1 10 Feb 2026

Remove blank line.

LEAHI-DD-FIRMWARE-LDT-2030-2 11 Feb 2026

Declare these earlier and just assign them here (i.e. keep declarations together at top of function).

LEAHI-DD-FIRMWARE-LDT-2030-2 11 Feb 2026

Some of these memset calls are zeroing a 2-dimensional array, so the size param is too short (only sizing 1st dimension).

LEAHI-DD-FIRMWARE-LDT-3103-1 10 Feb 2026

removed.

LEAHI-DD-FIRMWARE-LDT-3352-1 10 Feb 2026

Add blank line between declarations and rest of code.

LEAHI-DD-FIRMWARE-LDT-3173-1 10 Feb 2026

Does it make more sense to have them together?

LEAHI-DD-FIRMWARE-LDT-3103-1 10 Feb 2026

Outputs is none now I think.

LEAHI-DD-FIRMWARE-LDT-1473-1 09 Feb 2026

align the comment

LEAHI-DD-FIRMWARE-LDT-2004-3 10 Feb 2026

Put () around the 2 conditions

LEAHI-DD-FIRMWARE-LDT-3173-1 10 Feb 2026

it stop gap to see if it was valve specific. Its been reverted.

LEAHI-DD-FIRMWARE-LDT-3173-1 10 Feb 2026

fixed.

LEAHI-DD-FIRMWARE-LDT-3173-1 10 Feb 2026

reordered and wrapped in a macro

LEAHI-DD-FIRMWARE-LDT-3173-1 09 Feb 2026

I think we need a #ifdef TEENSY macro ?

LEAHI-DD-FIRMWARE-LDT-3103-1 10 Feb 2026

Can you follow up with whoever commented it out and find out if that was intentional? And, if so, will it be coming back? And, if so, should we at least put a TODO on this to restore later?

LEAHI-DD-FIRMWARE-LDT-2030-2 11 Feb 2026

Ok as is. We only need to have constant/literal first when using == operator to prevent confusion with = operator.

LEAHI-DD-FIRMWARE-LDT-2030-2 11 Feb 2026

Minor: Need space in (BLOOD_LEAK_EMB_MODE_CMD_T)

LEAHI-DD-FIRMWARE-LDT-3103-1 10 Feb 2026

Why did this file get deleted?

LEAHI-DD-FIRMWARE-LDT-3344-1 10 Feb 2026

Updated

LEAHI-DD-FIRMWARE-LDT-3103-1 10 Feb 2026

Remove blank line.

LEAHI-DD-FIRMWARE-LDT-3344-1 10 Feb 2026

Updated

LEAHI-DD-FIRMWARE-LDT-3103-1 10 Feb 2026

Why not "TRUE == "?

LEAHI-DD-FIRMWARE-LDT-3103-1 10 Feb 2026

done

LEAHI-DD-FIRMWARE-LDT-3103-1 10 Feb 2026

Why not "TRUE == "?

LEAHI-DD-FIRMWARE-LDT-1473-1 10 Feb 2026

Done.

LEAHI-DIALIN-LDT-2004-1 10 Feb 2026

New code pushed

LEAHI-DD-FIRMWARE-LDT-1473-1 09 Feb 2026

seems to be old , need to merge the staging code

LEAHI-DD-FIRMWARE-LDT-3173-1 10 Feb 2026

reordered MSG IDs such that the teensy specific ones are wrapped in a macro and are far enough in sequence to not cause trouble when we are ready to remove them.

LEAHI-DD-FIRMWARE-LDT-3344-1 11 Feb 2026

changed.

LEAHI-DD-FIRMWARE-LDT-1473-1 10 Feb 2026

Looks crucible is not seeing those. let me check once with Dara.

LEAHI-DD-FIRMWARE-LDT-3173-1 10 Feb 2026

removed

LEAHI-DD-FIRMWARE-LDT-1473-1 11 Feb 2026

Done

LEAHI-DD-FIRMWARE-LDT-2030-2 11 Feb 2026

Remove extra blank line.

LEAHI-DD-FIRMWARE-LDT-2030-2 11 Feb 2026

Please remove extra line

LEAHI-DIALIN-LDT-3287-1 11 Feb 2026

reverted handler to the original version. This was required to get a merge with develop to work

LEAHI-DIALIN-LDT-3287-1 10 Feb 2026

This code won't work. The sensor list missing the for loop that's populating it, and the original one is missing the M3 unpack. It's a merge of an old and a new code but both incomplete.

Please reference https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3480-1 for working solution on this.

LEAHI-DD-FIRMWARE-LDT-2030-2 11 Feb 2026

For init functions, I'm ok with saying something like "Blood leak driver unit variables initialized".