•  

Comment Results

Review Name Created Custom Fields Content
LEAHI-DD-FIRMWARE-LDT-2801-1 05 Jan 2026

Does this function return a speed or a pulse width?

LEAHI-TD-FIRMWARE-LDT-3126-1 05 Jan 2026

Align comment with variable comments below.

LEAHI-DD-FIRMWARE-LDT-2185-1 05 Jan 2026

Add blank line between functions.

LEAHI-DD-FIRMWARE-LDT-2004-3 05 Jan 2026

Align comment.

LEAHI-TD-FIRMWARE-LDT-4033-1 28 May 2026

Fixed

LEAHI-DD-FIRMWARE-LDT-3958-1 29 May 2026

as discussed, these were outcome of the test results. we will review these gains with latest controller.

HD-DENBUG-335-1 01 Jun 2026

The comment was left here to make sure the next developer does not ask the question that the blood pump was not set here. It is a note to remind the developer that the ramp is set below.

LEAHI-DD-FIRMWARE-LDT-3103-1 15 Jan 2026

changed the name to differentiate between driver level and controller level functions.

LEAHI-APPLICATION-LDT-2805-1 05 Jan 2026

Double check duration confirmation message length.

LEAHI-APPLICATION-LDT-2805-1 06 Jan 2026

Updated.

LEAHI-APPLICATION-LDT-2805-1 05 Jan 2026

Verify that both lines are required.
Add comment if they are.

LEAHI-DD-FIRMWARE-LDT-4001-1 11 Jun 2026

fixed thanks

LEAHI-TESTSUITES-LDT-2278-1 07 Jan 2026

Updated the test cases as per your suggestion

LEAHI-TD-FIRMWARE-LDT-4027-1 04 Jun 2026

Add /// doxygen comment for this enumeration and ///< doxygen comments to right of each enum in the list.

LEAHI-DD-FIRMWARE-LDT-2030-2 07 Jan 2026

done

LEAHI-APPLICATION-LDT-4511-1 09 Jun 2026

group not alt. alt is for conditons

LEAHI-TESTSUITES-LDT-1454-1 09 Jan 2026

test report has been uploaded in Jira

LEAHI-TD-FIRMWARE-LDT-3126-1 05 Jan 2026

These are Denali valves. We need to set all Leahi TD actuators here as appropriate. This will eventually be specified by system arch document in JAMA if it's not already. If not yet, let's do the following:
H1 valve = position B
H19 valve = position B
H4 (blood pump) = On (ramping to target rate)
H12/H13/H20 = Auto Air Trap Level Control (done with call to startAirTrapControl() function).
H10 = Off
H5 (ejector) = off (retracted)

LEAHI-TD-FIRMWARE-LDT-3126-1 05 Jan 2026

These overrides need to be updated to Leahi style (returns BOOL, takes message as param, is called by message handler, new Dialin message ID needed for override message, set/reset are merged into single message handling function, etc...).

LEAHI-DD-FIRMWARE-LDT-2185-1 13 Jan 2026

is there two space required ?

LEAHI-DD-FIRMWARE-LDT-2185-1 13 Jan 2026

can we remove it ?

LEAHI-TD-FIRMWARE-LDT-4009-1 01 Jun 2026

Once UI software sends the volume and/or duration change request and once we change them, the UI software will send another request to confirm the displayed settings to the user and that is what is being handled in this function.

LEAHI-TESTSUITES-LDT-2278-1 14 Jan 2026

verify_vitals_pop_up_is_opened_automatically_after_an_interval need to be placed before checking the request in test.verify(waitFor("'vitalsrequest == True'", 1000), "UI Sending the request to FW")

LEAHI-APPLICATION-LDT-3139-1 15 Jan 2026

updated

LEAHI-DD-FIRMWARE-LDT-2185-1 14 Jan 2026

Calculated is mis-spelled.

LEAHI-DD-FIRMWARE-LDT-2185-1 14 Jan 2026

Message handling functions must take a message as parameter (i.e. prototype of function should look like BOOL funcName( MESSAGE_T *message );

LEAHI-DIALIN-LDT-5214-1 29 Jul 2026

typo "the states enum class"

LEAHI-TD-FIRMWARE-LDT-3126-1 15 Jan 2026

Added

LEAHI-TESTSUITES-LDT-2174-1 13 Jan 2026

can we change this to 120 to minimize time

LEAHI-TESTSUITES-LDT-2174-1 13 Jan 2026

change to 120

LEAHI-APPLICATION-LDT-3139-1 15 Jan 2026
  1. "Title" = <Title string>
LEAHI-TD-FIRMWARE-LDT-4009-1 30 Jul 2026

Remove empty line

LEAHI-TD-FIRMWARE-LDT-4072-2 30 Jul 2026

Yes, these are low-priority alarms

CLOUDSYNC-DENBUG-337-1 28 May 2026

Tiffany Mejia
Why do have this defined in two places?

LEAHI-DD-FIRMWARE-LDT-2185-1 15 Jan 2026

Added struct packing

LEAHI-DD-FIRMWARE-LDT-2185-1 15 Jan 2026

This structure is for message payload. There is nothing to pack in this specific structure, but I think we should be in the habit of packing ALL payload structures in case a future structure change does require packing.

LEAHI-APPLICATION-LDT-2805-1 05 Jan 2026

Add comment for change.

LEAHI-TD-FIRMWARE-LDT-3126-1 15 Jan 2026

Combine set/reset for the 2 override functions. And use the helper functions in TestSupport.h (like over override handling functions do). f32Override() for the prime volume override and u32BroadcastIntervalOverride() for the broadcast interval override.

LEAHI-APPLICATION-LDT-2805-1 05 Jan 2026

Change to use "-- --" from Variables.
Check if View is setting default value.

HD-DENBUG-335-1 01 Jun 2026

RESOLVED in CODE WALKTHROUGH

LEAHI-DD-FIRMWARE-LDT-2030-2 07 Jan 2026

removed.

LEAHI-DD-FIRMWARE-LDT-2030-2 07 Jan 2026

removed all.

LEAHI-DD-FIRMWARE-LDT-3103-1 15 Jan 2026

done.

LEAHI-APPLICATION-LDT-2805-1 06 Jan 2026

Put example in comment.

LEAHI-TD-FIRMWARE-LDT-3126-1 09 Jan 2026

Changed

LEAHI-TD-FIRMWARE-LDT-3126-1 05 Jan 2026

We do need to bring blood prime sub-mode into treatment mode (integrate). So signals that blood is primed and it's time to transition from blood prime to dialysis are needed.
Treatment mode needs to be updated to include blood prime as a state (the first) in the treatment mode state machine and that state needs to call the exec function in this BloodPrime unit.

LEAHI-DD-FIRMWARE-LDT-2185-1 09 Jan 2026

temperatureD1

LEAHI-DD-FIRMWARE-LDT-4183-1 01 Jun 2026

Align the comment

LEAHI-DD-FIRMWARE-LDT-2185-1 14 Jan 2026

Added

LEAHI-DD-FIRMWARE-LDT-2185-1 14 Jan 2026

Moved