•  

Comment Results

Review Name Created Custom Fields Content
LEAHI-DD-FIRMWARE-LDT-2030-2 07 Jan 2026

BloodLeakDriver

LEAHI-DD-FIRMWARE-LDT-2030-2 07 Jan 2026

Remove blank line above this declaration and add a blank line below it.

LEAHI-DD-FIRMWARE-LDT-2030-2 12 Jan 2026

It is defined in line 937.

LEAHI-DD-FIRMWARE-LDT-2185-1 13 Jan 2026

Fixed

LEAHI-TD-FIRMWARE-LDT-3126-1 14 Jan 2026

Updated

LEAHI-TD-FIRMWARE-LDT-3126-1 14 Jan 2026

Added

LEAHI-TD-FIRMWARE-LDT-3126-1 09 Jan 2026

Function headers that we copy from Denali will not have some of the new formatting changes - make sure to update all of them to Leahi format (see from other units for example). In this case, there should be a \b before the type of details (Inputs and Outputs here) so they will be bold when documentation is generated.

LEAHI-DD-FIRMWARE-LDT-4409-2 09 Jun 2026

Dry bicart data publish in the comment.

LEAHI-TD-FIRMWARE-LDT-4033-1 12 Jun 2026

Add an else block and keep the state to idle.
In the beginning of the function assign the state to BP_DRIVER_CLEAR_CMD_STATE and remove line 194, 202 and 208.

LEAHI-APPLICATION-LDT-4581-1 09 Jun 2026

move this one out

LEAHI-DD-FIRMWARE-LDT-4011-2 08 Jun 2026

comments start's with uppercase?

HD-DENBUG-335-1 31 May 2026

We changed the order of ORs. But the parenthesis match otherwise, it would not compile.

LEAHI-DD-FIRMWARE-LDT-2998-1 06 Jan 2026

This should be before high, it feels wrong to have the order of 0,1,3,2 instead of 0,1,2,3 (Empty, Low, Medium, High)

LEAHI-TESTSUITES-LDT-1454-1 07 Jan 2026

change the spelling

LEAHI-TESTSUITES-LDT-2278-1 07 Jan 2026

Added as per the suggestion

LEAHI-DD-FIRMWARE-LDT-2030-2 07 Jan 2026

done.

LEAHI-DD-FIRMWARE-LDT-2030-2 07 Jan 2026

changed

LEAHI-APPLICATION-LDT-3139-1 09 Jan 2026

added new comment

LEAHI-DD-FIRMWARE-LDT-2185-1 09 Jan 2026

Logic for this has to be updated

LEAHI-TD-FIRMWARE-LDT-4033-1 12 Jun 2026

add requestAdultBPMeasurement to outputs

LEAHI-TD-FIRMWARE-LDT-4033-1 11 Jun 2026

We should initialize BP module from main at startup so we can use it in any mode.

LEAHI-TESTSUITES-LDT-1454-1 06 Jan 2026

o_ultrafiltration_TittleText not being used.. remove

LEAHI-TD-FIRMWARE-LDT-2240-1 03 Jun 2026

For now, we need to set barcodeScanResponseReceived to TRUE here until barcode scan command is implemented.

LEAHI-DD-FIRMWARE-LDT-2185-1 14 Jan 2026

I will move it

LEAHI-DD-FIRMWARE-LDT-2185-1 13 Jan 2026

This function seems to be a state specific function. in that case it should be handled in that file itself.

LEAHI-DD-FIRMWARE-LDT-3159-1 15 Jan 2026

Updated, Thanks

LEAHI-TD-FIRMWARE-LDT-3126-1 09 Jan 2026

This unit does not compile w/o errors - always build and check for errors before committing/pushing changes. At least one issue is that we need to include Valve3Way.h and I suspect other includes are missing as well (check bottom of compiler warnings list).

LEAHI-TD-FIRMWARE-LDT-3126-1 09 Jan 2026

I believe this function only takes 1 param in Leahi.

LEAHI-TESTSUITES-LDT-2174-1 13 Jan 2026

only need to select one. We do not need to test pressing every selection.

LEAHI-DD-FIRMWARE-LDT-2801-1 06 Jan 2026

The first function: void setFPGAD79RinsePumpControl( U08 value ) is for ON/OFF only. Once PWM is implemented, it will be removed.

LEAHI-APPLICATION-LDT-2805-1 06 Jan 2026

Updated.

LEAHI-DD-FIRMWARE-LDT-2185-1 13 Jan 2026

Updated

LEAHI-DD-FIRMWARE-LDT-2185-1 09 Jan 2026

I think this should not be in test support functions

LEAHI-APPLICATION-LDT-2805-1 06 Jan 2026

This change clamps tValue between [min, max].
For example, given value=2, min=5, max=10, step=1 and increment is called, without this change value will be incremented to 3 (still outside [min, max]), with this change value will be incremented to 5, pulling it into the valid range.

More comments have been added for clarity.

LEAHI-APPLICATION-LDT-2805-1 05 Jan 2026

Switch all adjustment_ReasonText back to text().

LEAHI-DIALIN-LDT-4485-1 11 Jun 2026

fixed thanks

LEAHI-DD-FIRMWARE-LDT-2030-2 07 Jan 2026

done

LEAHI-DIALIN-LDT-2998-1 08 Jan 2026

Renamed

LEAHI-DD-FIRMWARE-LDT-4001-1 11 Jun 2026

fixed thanks

LEAHI-APPLICATION-LDT-2805-1 08 Jan 2026

Updated.

LEAHI-DIALIN-LDT-4612-1 11 Jun 2026

remove 3rd empty line

LEAHI-DD-FIRMWARE-LDT-4485-1 09 Jun 2026

remove blank line

LEAHI-DD-FIRMWARE-LDT-2801-1 08 Jan 2026

Not what I mean. I mean lines 174 and 193 are identical copies.

LEAHI-APPLICATION-LDT-3139-1 09 Jan 2026

going to leave as is. Next story I make further updates to this

LEAHI-TD-FIRMWARE-LDT-4094-1 11 Jun 2026

I don't think you should be subtracting venMinOffset anymore. Check with Eliza.

LEAHI-APPLICATION-LDT-3139-1 09 Jan 2026

updated

LEAHI-DD-FIRMWARE-LDT-2185-1 09 Jan 2026

Yes correct. I fixed it

LEAHI-DD-FIRMWARE-LDT-2185-1 09 Jan 2026

fixed it

LEAHI-DD-FIRMWARE-LDT-2185-1 14 Jan 2026

Added the missing messages

LEAHI-DD-FIRMWARE-LDT-2185-1 14 Jan 2026

need to mention the sensor name in the comment