•  

Comment Results

Review Name Created Custom Fields Content
LEAHI-DIALIN-LDT-2004-2 26 Jan 2026

If Michael is right, then f/w is not expecting an override payload and so we shouldn't use the generic override payload structure.

LEAHI-DD-FIRMWARE-LDT-2004-1 26 Jan 2026

Shouldn't D27 temp be gotten from monitor (Temperature.c) instead of from conductivity drivers?

LEAHI-DD-FIRMWARE-LDT-2004-1 26 Jan 2026

enum should have a /// comment on top.

LEAHI-DIALIN-LDT-3106-1 23 Jan 2026

Updated per Dara's official message IDs.

LEAHI-DD-FIRMWARE-LDT-4409-2 12 Jun 2026

in initial fill we are not closing D64, only in supply cycle, just before supply start, we close it and when supply end, we open it again.
we need to maintain the pressure balance in chamber F

LEAHI-DD-FIRMWARE-LDT-2004-3 23 Jan 2026

Fixed it

LEAHI-APPLICATION-LDT-4511-1 09 Jun 2026

Log Data Collection during Treatment

LEAHI-TD-FIRMWARE-LDT-4033-1 11 Jun 2026

What is "e"? I think this might be a typo and you should put it back the way it was.

LEAHI-DD-FIRMWARE-LDT-2004-3 22 Jan 2026

Use OVERRIDE_RESET instead of 0.

LEAHI-APPLICATION-LDT-3174-1 26 Jan 2026

make Chlorine an arguement of the string

LEAHI-APPLICATION-LDT-3174-1 26 Jan 2026

add TODO comment

LEAHI-DD-FIRMWARE-LDT-2004-3 23 Jan 2026

Remove Max. update comment as acid and bicarb dosing pump speed.

LEAHI-TD-FIRMWARE-LDT-4033-1 11 Jun 2026

I think this should be executed from TaskGeneral so we can do BP things in any mode.

LEAHI-DD-FIRMWARE-LDT-2004-1 26 Jan 2026

fixed.

LEAHI-APPLICATION-LDT-3174-1 22 Jan 2026

Can you use LabelUnitValueAdjuster instead of LabelUnitContainer with ValueAdjusters?

LEAHI-APPLICATION-LDT-3174-1 22 Jan 2026

create advancedFormat to prefix "@"..... @%1^%2

LEAHI-SW-PLUGINS-SIM-LDT-2937-1 21 Jan 2026

Updated.

LEAHI-APPLICATION-LDT-2937-1 20 Jan 2026

Move from hd to td directory.

LEAHI-DD-FIRMWARE-LDT-4001-1 09 Jun 2026

Align comment please.

LEAHI-DD-FIRMWARE-LDT-4001-1 09 Jun 2026

In develop branch , its substitionrate ? need in sync with develop and staging

LEAHI-TESTSUITES-LDT-2741-1 22 Jan 2026

If I use Standby also it will directly navigate to Manufacture password screen and after launching of aut with -E

LEAHI-APPLICATION-LDT-4511-1 10 Jun 2026

updated

LEAHI-DD-FIRMWARE-LDT-2004-3 22 Jan 2026

Done

LEAHI-DIALIN-LDT-4485-1 11 Jun 2026

fixed thanks

LEAHI-APPLICATION-LDT-3174-1 22 Jan 2026

remove all simulation code from app

LEAHI-APPLICATION-LDT-3174-1 23 Jan 2026

updated

LEAHI-DD-FIRMWARE-LDT-2004-3 21 Jan 2026

remove empty space/s

LEAHI-DD-FIRMWARE-LDT-2004-1 26 Jan 2026

fixed.

LEAHI-DD-FIRMWARE-LDT-2004-1 26 Jan 2026

updated to consider the build switch.

LEAHI-APPLICATION-LDT-4561-1 09 Jun 2026

check with Sean

LEAHI-TD-FIRMWARE-LDT-4063-1 11 Jun 2026

please add blank space between ( (int)postState ), TRUE );

LEAHI-TD-FIRMWARE-LDT-4072-2 05 Jun 2026

I don't think we need these min/max #defines. Just use 0x0 for minimums and 0xFFFFFFFF for maximums.

LEAHI-DD-FIRMWARE-LDT-2004-1 26 Jan 2026

No model selection for V2 sensor?

LEAHI-DD-FIRMWARE-LDT-2004-3 22 Jan 2026

Function prototypes do not require comments to right, but for consistency we should add one here since all the other prototypes have comments.

LEAHI-DD-FIRMWARE-LDT-2004-3 22 Jan 2026

Update outputs to include the start time.

LEAHI-APPLICATION-LDT-3174-1 26 Jan 2026

add TODO comment in implement later story

LEAHI-APPLICATION-LDT-3174-1 26 Jan 2026

get caryna full hex

LEAHI-APPLICATION-LDT-3106-1 21 Jan 2026

Updated.

LEAHI-SW-PLUGINS-SIM-LDT-2937-1 20 Jan 2026

Use specific message function in Dialin.

LEAHI-APPLICATION-LDT-3106-1 20 Jan 2026

Removed endClicked.

LEAHI-DD-FIRMWARE-LDT-2004-3 22 Jan 2026

Done

LEAHI-DD-FIRMWARE-LDT-2004-3 23 Jan 2026

Fixed it

LEAHI-DD-FIRMWARE-LDT-2004-3 23 Jan 2026

Fixed it

LEAHI-DD-FIRMWARE-LDT-4001-1 10 Jun 2026

fixed thanks

LEAHI-DD-FIRMWARE-LDT-2004-1 26 Jan 2026

fixed.

LEAHI-TD-FIRMWARE-LDT-4027-1 09 Jun 2026

This medium alarm is ID 196 (from enum above). So I would expect it to be at the bottom of this table. Why are you placing it here?

LEAHI-APPLICATION-LDT-3106-1 20 Jan 2026

Move message ID to beginning and message name after.

LEAHI-APPLICATION-LDT-3174-1 22 Jan 2026

add message id

LEAHI-APPLICATION-LDT-3174-1 22 Jan 2026

Fill in Parameters

LEAHI-DD-FIRMWARE-LDT-2004-1 26 Jan 2026

Only needed for TEENSY, right? So #ifdef should be applied.