Comment Search

This is a change from Zoltan and I am updated that into my local branch

updated

I would not do that because the function names and messages for each project should be different to avoid confusion.
I think that is fine for now.

RESOLVED.

Add space between } and type name.

I don't think we need to check test config for variable initialization.

Add TODO to comment.

fixed. thanks

Need two spaces before the test function

Is there no "first" enum for this group?

Are we supporting multiple models? Is this for Teensy or new sensor or both?

Align =

Done.

I do not see bloodLeakDataPublicationTimerCounter being initialized in the function.
Should we add bloodLeakEmbModeCmdQ to the list?

Yes. updated.

Remove the empty space.

RESOLVED for now.

arrange this code and new sensor code in a group- line 131 - 142

removed.

Could you update all the overrides to use the generic method? So we don't need to maintain these on more than one place
Broadcast -> cmd_generic_broadcast_interval_override
others -> cmd_generic_override

You can check any of the other modules how to use them

It is there in line 131

It would be nice to have it clubbed it together like

#ifdef _TEENSY_CONDUCTIVITY_DRIVER_
place all code for teensy here

,
#else
// move the all code under #ifndef _TEENSY_CONDUCTIVITY_DRIVER_ here

#endif

Looks like you updated wrong function (the one below instead of this one). It's an output in function below and it's an input in this function.

Actually, for casting, I prefer no spaces around ().

Declare these earlier and just assign them here (i.e. keep declarations together at top of function).

removed.

Does it make more sense to have them together?