•  

Comment Results

Review Name Created Custom Fields Content
DG-DEN-4322-1 21 Aug 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-13460-2 22 Sep 2022

RESOLVED IN CODE WALKTHROUGH

DIALIN-DEN-13903-1 22 Sep 2022

Why are these removed?
It might be used in our SquishQt dev tests.

DIALIN-DEN-13903-1 22 Sep 2022

Missing payload.

UI-DEN-4438-1 23 Aug 2020

done

HD-DEN-14000-1 13 Oct 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-14000-1 13 Oct 2022

RESOLVED in CODE WALKTHROUGH.

UI-DEN-3605-4 25 Aug 2020

Remove extra line.

UI-DEN-4438-1 25 Aug 2020

File name must use camelCase.

UI-DEN-4438-1 25 Aug 2020

File name must use camelCase.

UI-DEN-4438-1 25 Aug 2020

File name must use camelCase.

UI-DEN-4438-1 25 Aug 2020

File name must use camelCase.

UI-DEN-3605-4 25 Aug 2020

Remove extra line.

DIALIN-DEN-3875-1 25 Aug 2020

These need to be filled in so the API documentation is populated

DG-DEN-4322-1 26 Aug 2020

Yes, it should be one blank line at the end. I do see in code composer there is one blank line at the end of these files.

UI-DEN-4438-1 20 Aug 2020

Why is indentation of } off?

UI-DEN-4438-1 25 Aug 2020

File name must use camelCase.

VV-DEN-1434-1 11 Jun 2020

Why is this file named bkup?

VV-DEN-1434-1 11 Jun 2020

Remove file from repo.

UI-DEN-3253-1 11 Jun 2020

Our current drivers don't require keep-awake CAN traffic between UI and FW, so I've set it to be disabled by default.

DG-DEN-4217-1 12 Aug 2020

Add extra line between } and function.

UI-DEN-3253-1 11 Jun 2020

RESOLVED.

DG-DEN-3922-1 22 Jul 2020

RESOLVED in CODE WALKTHROUGH.

UI-DEN-3253-1 11 Jun 2020

RESOLVED.

UI-DEN-3253-1 11 Jun 2020

Agreed, would move them, there, in fact isn't AlarmDefs.h part of common between DG FW, HD FW, and UI SW? I believe alarms and messages are the only items that are common to all three software items/systems.

UI-DEN-3253-1 26 Jun 2020

Models do not suppose to instantiate from QObject because we don't what them emit signals and use slots.
They are just data models.

DIALIN-DEN-3433-1 11 Jun 2020

RESOLVED.

UI-DEN-3253-1 15 Jun 2020

Thanks for the demo.
I'm still concerned about performance and some other things and I need to investigate more.
Until then, please use png instead.

UI-DEN-3253-1 15 Jun 2020

You're almost right.
If we are going to use SVG we need to completely move to SVG and not partially using svg or png here and there.
I don't want to jump to a new solution without investigating enough.
I spent some time in weekend reading about using SVG for embedded systems and I didn't find any complete suggestions and recommendation other than one single guy named "Stanley Moriss" who on 2014 decided to use SVG in Fuji project (as one his presentation pages shows) in BIT-Group.
Last thing I remember there was no png used in Fuji so what happened to that idea I'm not sure.
That concerns me a little that we are going the first one and I don't our project to be the "crash test dummy" for other people.
Thanks again for the great demo and how it works we will move to SVG as soon as we are completely sure that's a correct approach.
So please stick to the plan (using png) until then.

DG-DEN-4322-1 19 Aug 2020

RESOLVED in CODE WALKTHROUGH.

UI-DEN-3149-1 11 Jun 2020

To find the section easier.
Something like a line.
not a comment thought.

DIALIN-DEN-3593-1 20 Jul 2020

Done

UI-DEN-3253-1 26 Jun 2020

RESOLVED

DG-DEN-3922-1 22 Jul 2020

Remove extra lines.

UI-DEN-3875-1 12 Aug 2020

}}?

UI-DEN-3253-1 22 Jun 2020

Thanks for applying that.
Also please move the MouseArea after all the components so it becomes the highest in the z order and can grab all the clicks.

DG-DEN-3421-1 12 Aug 2020

Agreed. Will fix this once I started working on the story

UI-DEN-3253-1 15 Jun 2020

Why insist on making the same comment twice? We both know where ColorOverlay is and that QGraphicalEffects is necessary to import to use it.

In my demo on Friday, the application did not look "ugly." It was using QGraphicalEffects to draw SVG's and my understanding was that you said it looked fine. I'm confused. What has changed?

UI-DEN-3253-1 22 Jun 2020

Done

DIALIN-DEN-2379-1 07 Jul 2020

Done

UI-DEN-3253-1 25 Jun 2020

Same here.

UI-DEN-3253-1 22 Jun 2020

RESOLVED

DG-DEN-4169-1 31 Jul 2020

RESOLVED in CODE WALKTRHOUGH

UI-DEN-3253-1 22 Jun 2020

RESOLVED

UI-DEN-3253-1 07 Jul 2020

RESOLVED.

HD-DEN-4211-1 28 Aug 2020

Done

UI-DEN-3253-1 07 Jul 2020

RESOLVED.

DG-DEN-4169-1 03 Aug 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-4217-1 20 Aug 2020

Spaces between arithmetic operation signs.

UI-DEN-3875-1 12 Aug 2020

Remove all commented lines.