You'll probably disagree with using svg's for small icons and png's for large images, but this is in alignment with the recommendation of the Qt company:
> Use SVG images for small icons. While larger SVGs can be slow to render, small ones work well. Vector images avoid the need to provide several versions of an image, as is necessary with bitmap images.
The bell and alarm icons are small, so I have used svg to avoid adding many versions of them to support all the alarm priority colors, sizes, and ease future changes during integration work several months from now.
Clicked actually suggests that a mouse is being used. Pressed suggested that someone pressed the screen with their finger, which is our primary use case.
I had the same comment, should we change our C++ coding standard, too? Behrouz mentioned that this is the recommended way. I still believe this is really hard to read and against other coding standard I have worked in the past.
Again, you've made your point many times about the svg vs. png issue. We don't need extra comments reminding us of it or where the svg's are in the code.
These macros keeping the code simple to avoid multiple repetitive codes which are almost the same and have only one parameters different. Those are mostly Qt related Signal/Slot definitions which are not caught by any static code analyzer and are not anything that they can suggest to change any other way than Qt documented. So other usage of this macros are to simplify the code. I still would like to keep them and don't want to remove them until the time comes. thanks,