•  

Comment Results

Review Name Created Custom Fields Content
HD-DEN-3115-1 05 Jun 2020

Done.

UI-DEN-3253-1 15 Jun 2020

As per our conversation and my demo last Friday about shifting to using svg instead of png, could you please resolve?

DG-DEN-4217-1 12 Aug 2020

Space after // in comments

UI-DEN-3149-1 23 Jun 2020

RESOLVED.

DG-DEN-3922-1 22 Jul 2020

RESOLVED in CODE WALKTHROUGH.

UI-DEN-3149-1 23 Jun 2020

RESOLVED.

UI-DEN-3253-1 15 Jun 2020

You'll probably disagree with using svg's for small icons and png's for large images, but this is in alignment with the recommendation of the Qt company:

> Use SVG images for small icons. While larger SVGs can be slow to render, small ones work well. Vector images avoid the need to provide several versions of an image, as is necessary with bitmap images.

The bell and alarm icons are small, so I have used svg to avoid adding many versions of them to support all the alarm priority colors, sizes, and ease future changes during integration work several months from now.

https://www3.sra.co.jp/qt/relation/doc-snapshot/qtquick/qtquick-bestpractices.html

DG-DEN-4322-1 15 Aug 2020

Assuming this is F32. Should be 1.0.

UI-DEN-3149-1 23 Jun 2020

RESOLVED.

UI-DEN-3253-1 15 Jun 2020

RESOLVED

DG-DEN-3922-1 22 Jul 2020

Done

UI-DEN-3253-1 15 Jun 2020

Clicked actually suggests that a mouse is being used. Pressed suggested that someone pressed the screen with their finger, which is our primary use case.

UI-DEN-3149-1 23 Jun 2020

I had the same comment, should we change our C++ coding standard, too? Behrouz mentioned that this is the recommended way. I still believe this is really hard to read and against other coding standard I have worked in the past.

DG-DEN-4322-1 15 Aug 2020

Do we need to override this ratio? Can't we already do this indirectly by overriding conductivity sensor(s)?

DG-DEN-3922-1 23 Jul 2020

RESOLVED in CODE WALKTHROUGH.

DIALIN-DEN-3593-1 18 Jul 2020

HD stands for Hemodialysis Delivery, not Device.

DIALIN-DEN-3964-1 18 Jul 2020

If comments end all with ".", we should be consistent, my preference would be to have no "." at the end of each comment

UI-DEN-3253-1 26 Jun 2020

Same comment as O am not a big fan of iterating on variable names, function names, etc. This is also not Jira, but Crucible.

UI-DEN-3253-1 15 Jun 2020

Again, you've made your point many times about the svg vs. png issue. We don't need extra comments reminding us of it or where the svg's are in the code.

HD-DEN-4211-1 26 Aug 2020

Done

DIALIN-DEN-2379-1 07 Jul 2020

Done

DG-DEN-3922-1 23 Jul 2020

RESOLVED IN CODE WALKTHROUGH

UI-DEN-3253-1 07 Jul 2020

RESOLVED.

HD-DEN-4211-1 26 Aug 2020

Done

UI-DEN-3253-1 15 Jun 2020

Why does it matter, functionally?

UI-DEN-3149-1 15 Jun 2020

The semicolon usage is difference between these two functions. Shouldn't we not have semicolons in QML?

UI-DEN-3253-1 22 Jun 2020

please refer to the reply of the comment :
http://dvm-linux02:8060/cru/UI-DEN-3253-1#c2505

UI-DEN-3149-1 15 Jun 2020

Thanks Peter for your great suggestions.

These macros keeping the code simple to avoid multiple repetitive codes which are almost the same and have only one parameters different.
Those are mostly Qt related Signal/Slot definitions which are not caught by any static code analyzer and are not anything that they can suggest to change any other way than Qt documented.
So other usage of this macros are to simplify the code.
I still would like to keep them and don't want to remove them until the time comes.
thanks,

LEAHI-APPLICATION-LDT-2160-1 15 Sep 2025

RESOLVED

DIALIN-DEN-2379-1 07 Jul 2020

RESOLVED

DG-DEN-4169-1 31 Jul 2020

Done

UI-DEN-3253-1 22 Jun 2020

Thanks Peter,
Out of curiosity why do you still need
#include "guicontroller.h" ?

UI-DEN-3253-1 15 Jun 2020

The notification background for the normal messages should be white by default.
As we have it in the UX design.
https://app.zeplin.io/project/5e160353a7c41a9404596a70/screen/5e4f250562025d78ef8435b8

Please explain why it's changed?

DIALIN-DEN-2379-1 07 Jul 2020

RESOLVED

DG-DEN-4169-1 31 Jul 2020

Done

DIALIN-DEN-3964-1 20 Jul 2020

RESOLVED.

DG-DEN-4169-1 31 Jul 2020

Recommend using time windowed count here to narrow the time. Currently, it is enforcing a maximum # of instances over entire time system is on.

DG-DEN-4169-1 31 Jul 2020

Move all arguments and align them with the left "(" of start of argument list.

DG-DEN-3421-1 12 Aug 2020

Is the "\" necessary in C for the Compiler we use?

DG-DEN-3421-1 12 Aug 2020

Done

DG-DEN-4217-1 12 Aug 2020

Done

DG-DEN-3421-1 12 Aug 2020

Yes, I have seen issues if I don't put it.

DG-DEN-3421-1 12 Aug 2020

Yes, I have seen issues if I don't put it.

DG-DEN-3421-1 12 Aug 2020

Will fix this throughout code

DG-DEN-3421-1 12 Aug 2020

Where is the /*@}/ Doxygen comment at eof?

DG-DEN-3421-1 13 Aug 2020

Planned for DEN S26.

DG-DEN-4322-1 17 Aug 2020

alarm data type has been removed. This module will only take F32 until we need to account for other type.

DG-DEN-4217-1 17 Aug 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-2379-1 05 Jun 2020

RESOLVED in CODE WALKTHROUGH.

UI-DEN-3149-1 11 Jun 2020

What is this comment for?