•  

Comment Results

Review Name Created Custom Fields Content
LEAHI-DD-FIRMWARE-LDT-618-3 11 Dec 2025

Added.

LEAHI-TESTSUITES-LDT-2278-1 12 Dec 2025

Removed the wait function

LEAHI-DD-FIRMWARE-LDT-2185-1 12 Dec 2025

added

LEAHI-TD-FIRMWARE-LDT-1886-1 11 Dec 2025

move static function after public function

LEAHI-TD-FIRMWARE-LDT-1886-1 11 Dec 2025

Let all public functions come on top for all files

LEAHI-DD-FIRMWARE-LDT-2998-1 05 Jan 2026

Changed

LEAHI-DD-FIRMWARE-LDT-2998-1 05 Jan 2026

Added

LEAHI-DD-FIRMWARE-LDT-2936-1 02 Dec 2025

Fixed.

LEAHI-DD-FIRMWARE-LDT-2936-1 02 Dec 2025

Fixed.

LEAHI-TD-FIRMWARE-LDT-1886-1 02 Dec 2025

Done

LEAHI-TESTSUITES-LDT-2174-1 06 Nov 2025

For testing the patient ID just test 2 different scenarios.
1. Test with a ptient ID (ideally with the full character limit) then enter all parameters then validate

  • Can test the validator only able to enter character that are acceptable..
    2. Test with NO patient ID then enter all parameters then validate.


No need to test 10 different patient IDs just those scenarios listed

LEAHI-TD-FIRMWARE-LDT-473-1 16 Dec 2025

MODE_TPAR should be deleted.

LEAHI-DD-FIRMWARE-LDT-2936-1 03 Dec 2025

Published in the respective modules

LEAHI-DD-FIRMWARE-LDT-2936-1 03 Dec 2025

Publish all other important data like conductivity and pressures

LEAHI-DD-FIRMWARE-LDT-2936-1 26 Nov 2025

Need to co-ordinate with drybicart message id since it is using 0x70

LEAHI-DD-FIRMWARE-LDT-2936-1 03 Dec 2025

arrange static and global function properly , public on top and static on bottom

HD-DENBUG-335-1 29 May 2026

The alarm data doesn't sound correct.

LEAHI-DD-FIRMWARE-LDT-618-2 04 Dec 2025

Updated

LEAHI-TD-FIRMWARE-LDT-473-1 05 Dec 2025

I guess my point was, we don't need the "APP_SERVICES" part in the name.

LEAHI-TD-FIRMWARE-LDT-473-1 02 Dec 2025

Missing param line in function header.

LEAHI-DD-FIRMWARE-LDT-2004-1 26 Jan 2026

yes. they are added.

LEAHI-TD-FIRMWARE-LDT-473-1 05 Dec 2025

Why was this moved to header file?

LEAHI-TESTSUITES-LDT-2278-1 08 Dec 2025

Renamed the function to match the staging

LEAHI-TD-FIRMWARE-LDT-2240-1 03 Jun 2026

Something is wrong here. We already had reg 33 at line 192 above. Reconcile with HDD.

LEAHI-TD-FIRMWARE-LDT-4013-1 01 Jun 2026

where are we calling an alarm?
i think we are only sending event change data in completeBolusToCumulative() right?

LEAHI-DD-FIRMWARE-LDT-2004-3 08 Dec 2025

Done.

LEAHI-TD-FIRMWARE-LDT-473-1 16 Dec 2025

Should we request pre-treatment mode here instead? How do we get to pre-treatment mode?

LEAHI-TD-FIRMWARE-LDT-4027-1 05 Jun 2026

currentPreTxRecircState looks like an input.

LEAHI-TD-FIRMWARE-LDT-473-1 08 Dec 2025

Missing return statement.

LEAHI-TD-FIRMWARE-LDT-4013-2 12 Jun 2026

Can we not determine this now? Why TODO?

LEAHI-DD-FIRMWARE-LDT-2030-2 11 Dec 2025

Changed. Thank you.

LEAHI-DD-FIRMWARE-LDT-2030-2 10 Dec 2025

Please bring public functions on top. check it for all function in this file , except test functions

LEAHI-DD-FIRMWARE-LDT-2185-1 12 Dec 2025

fixed it

LEAHI-DD-FIRMWARE-LDT-4409-2 09 Jun 2026

Align comment

LEAHI-DD-FIRMWARE-LDT-2185-1 12 Dec 2025

removed

LEAHI-DD-FIRMWARE-LDT-2185-1 11 Dec 2025

Keep blank line here.

LEAHI-DIALIN-LDT-1886-2 18 Dec 2025

Integer 'i' is 4 bytes. Is that what you mean?

LEAHI-DD-FIRMWARE-LDT-4001-1 09 Jun 2026

BROADCAST_INTERVAL?

LEAHI-TD-FIRMWARE-LDT-473-1 08 Dec 2025

Message handler functions must have a single parameter (message). The payload of the message will have the param and value in it and this function needs to parse them out of the payload. Also need to check payload length first.
We need a new message ID in MsgDefs.h for Dialin to send us this message and we need to add an entry in the message/handler table in Messaging.c.

LEAHI-TD-FIRMWARE-LDT-4072-2 05 Jun 2026

NUM_OF_BATTERY_REGISTERS - 1

LEAHI-TD-FIRMWARE-LDT-4063-1 29 Jul 2026

This reason code is not used anywhere, and the existing REQUEST_REJECT_REASON_NOT_ALLOWED_IN_CURRENT_MODE can be used if a rejection response is needed. I removed the new reason code.

LEAHI-DD-FIRMWARE-LDT-4409-2 09 Jun 2026

Do we need to close D64 as well?

LEAHI-TESTSUITES-LDT-1454-1 16 Dec 2025

method name is updated has setObjectText()

LEAHI-DD-FIRMWARE-LDT-2185-1 12 Dec 2025

use the Rinse pump API to get the flow rate

LEAHI-TD-FIRMWARE-LDT-1886-1 17 Dec 2025

Done

TEENSY-BOARD-LDT-2004-6 18 Dec 2025

fixed. thanks!

LEAHI-APPLICATION-LDT-3046-1 17 Dec 2025

Feature Configurations to match system.conf

LEAHI-DD-FIRMWARE-LDT-2004-3 15 Dec 2025

Remove extra blank line.

LEAHI-DD-FIRMWARE-LDT-2004-3 11 Dec 2025

Remove extra spaces between { and msg name.

LEAHI-DD-FIRMWARE-LDT-2004-3 04 Dec 2025

Why FP? I don't see FP prefixed s/w faults in the enum.