Doesn't make sense to have a static function prototyped in the header file. Static suggests the function is private. Prototyping in header file suggests function is public. I suspect this function should be private, so keep that static but move this prototype inside the .c file.
1. at this point we need to verify after all parameters are populated then the names.o_PreTreatmentButton is now enabled. 2. User needs to first press the button for the FW to respond
I would prefer to keep it here, as the start state (DRY_BICART_START_STATE) is always executed when the fill bicart flag (dryBiCartFillRequested) is not set. There are other execs, say fill chamber (execBicarbChamberFillMode) mode controls D80 in its sub states. So, not two execs controlling same valve. Once we identified where all modes using these execs, will come up with signals to avoid such scenarios.
Its like we need to compile the safe library and include it. But if we are using only memcpy and memset, memcmp and static code analyzer check the destination buffer size , I am marking it as resolved
