•  

Comment Results

Review Name Created Custom Fields Content
LEAHI-TESTSUITES-LDT-2278-1 11 Dec 2025

Update:

1. You need a test to wait for the timer to countdown all the way and confirm FW is receiving the request. I suggest setting the inerval to 5 min and add a way to wait 5 min max until we receive the Request from UI..
e.g. To listen for a UI message look into can_interface.register_receiving_publication_function().. example in Solution infusion.
2. I would like a test during the timer running to change the interval time and verify the count down updates per the new interval.
e.g. set 30 min and verify the count down is going down to the nearest 30 min interval, Open the vitals interval popup and change to 5 min and confirm then test the countdown udpates to countdown to the nearest 5 min mark

LEAHI-DD-FIRMWARE-LDT-2936-1 02 Dec 2025

Fixed.

LEAHI-DD-FIRMWARE-LDT-2936-1 09 Dec 2025

Resolved

LEAHI-DD-FIRMWARE-LDT-3272-1 27 May 2026

This file has been updated by HALCoGen automatically.

LEAHI-TD-FIRMWARE-LDT-3259-1 27 May 2026

Done

LEAHI-TESTSUITES-LDT-2174-1 03 Dec 2025

The steps have been modified as per suggestion

LEAHI-TESTSUITES-LDT-2174-1 03 Dec 2025

The steps have been modified as per suggestion

LEAHI-TD-FIRMWARE-LDT-1886-1 02 Dec 2025

Align =

LEAHI-DD-FIRMWARE-LDT-2329-2 09 Dec 2025

Done

LEAHI-TESTSUITES-LDT-2174-1 02 Dec 2025

type o_PreTreatmentButton

LEAHI-TD-FIRMWARE-LDT-4009-1 29 May 2026

How can settings be pending when you set that flag to TRUE in the code below this? And why would we want to use uf volume setting in the else part of this ternary?

LEAHI-TESTSUITES-LDT-3588-1 04 Jun 2026

Where updated test cases. The changes should bein exisitng test cases

LEAHI-DD-FIRMWARE-LDT-2936-1 04 Dec 2025

I don't think the number of samples is what you want as 3rd parameter. You want number of bytes so 4 x number of samples so you should pass "sizeof( roRRSamples )".

LEAHI-DD-FIRMWARE-LDT-618-2 04 Dec 2025

Done.

LEAHI-DD-FIRMWARE-LDT-618-2 04 Dec 2025

Changed

LEAHI-DD-FIRMWARE-LDT-618-2 04 Dec 2025

Even though we are giving the type a name at the bottom of the enum, we typically still want to give the enum a name up top here. See other enums throughout code for examples.

LEAHI-TD-FIRMWARE-LDT-473-1 02 Dec 2025

Get function for rejected is not needed?

LEAHI-TESTSUITES-LDT-2174-1 08 Dec 2025

Verify the active property of heprain stop time

LEAHI-TESTSUITES-LDT-2174-1 08 Dec 2025

Check the QR code visible property

LEAHI-DD-FIRMWARE-LDT-2936-1 03 Dec 2025

Small letter used

LEAHI-DD-FIRMWARE-LDT-2004-3 08 Dec 2025

Done.

LEAHI-TESTSUITES-LDT-2278-1 11 Dec 2025

reason

LEAHI-DIALIN-LDT-598-2 10 Dec 2025

when I get the version with python3 version.py it will show the correct branch and commit version instead of just 1.0.0, which tells nothing.
I use this when they ask what version of dialin I have, as I know the branch, but not the commit version, and it's faster with this then asking git around.

LEAHI-TESTSUITES-LDT-2174-1 05 Dec 2025

test the active property test.compare(heprain_Stop_time.isActive,False, "Heprain stop time active property is set to False")

LEAHI-APPLICATION-LDT-2957-1 10 Dec 2025

done

LEAHI-TESTSUITES-LDT-1454-1 11 Dec 2025

Renamed the function has setObjectText

LEAHI-DD-FIRMWARE-LDT-2030-2 11 Dec 2025

I think you are seeing previous commit. It is not there in the present code.

LEAHI-RO-FIRMWARE-LDT-2116-1 08 Dec 2025

comments should start with capital letter

LEAHI-TESTSUITES-LDT-1802-1 12 Dec 2025

Shouldn't this function be defined in a more general location/file?
And same comment here to be aware of the translation flexibility for later.

LEAHI-DD-FIRMWARE-LDT-2185-1 11 Dec 2025

Call this in both Pre Gen: Verify Water and Gen Permeate

LEAHI-TD-FIRMWARE-LDT-473-1 16 Dec 2025

Deleted.

LEAHI-DD-FIRMWARE-LDT-2185-1 12 Dec 2025

Something like this
( QUADRATIC_COEFFICIENT * ( pressureP13 * pressureP13 ) ) - ( LINEAR_COEFFICIENT * ( pressureP13 ) ) + CONSTANT_TERM;

LEAHI-DD-FIRMWARE-LDT-2185-1 15 Dec 2025

it can be directly initialized

LEAHI-DD-FIRMWARE-LDT-2185-1 16 Dec 2025

Updated

LEAHI-DD-FIRMWARE-LDT-2185-1 16 Dec 2025

Removed

LEAHI-DD-FIRMWARE-LDT-2185-1 12 Dec 2025

Remove extra blank line.

LEAHI-DD-FIRMWARE-LDT-2185-1 18 Dec 2025

Can we remove this code?

LEAHI-APPLICATION-LDT-3046-1 18 Dec 2025

updated to false

LEAHI-APPLICATION-LDT-3000-1 18 Dec 2025

updated logic

LEAHI-TD-FIRMWARE-LDT-1886-1 16 Dec 2025

This if should have an else where we zero .valveOpsStartTime (in case it briefly got set but then failed this if before timeout).

LEAHI-DD-FIRMWARE-LDT-2004-3 11 Dec 2025

Is this temporary? If so, put a TODO to remove later.

LEAHI-TESTSUITES-LDT-2278-1 19 Dec 2025

updated

LEAHI-APPLICATION-LDT-3000-1 17 Dec 2025

enable lock icon

LEAHI-APPLICATION-LDT-3000-1 17 Dec 2025

add comment

LEAHI-DD-FIRMWARE-LDT-2004-3 11 Dec 2025

Is this always needed or is it only needed in one or more specific modes (i.e. gen dialysate mode)? If only needed in specific modes, I think this should be called from those modes (similar to BC exec).

LEAHI-TESTSUITES-LDT-1454-1 10 Dec 2025

in staging the function name is setObjectText() please be consistant

LEAHI-DD-FIRMWARE-LDT-2936-1 02 Dec 2025

Fixed.

LEAHI-DD-FIRMWARE-LDT-2936-1 02 Dec 2025

Fixed.

LEAHI-DD-FIRMWARE-LDT-3958-1 29 May 2026

Use ternary to explicitly assign TRUE or FALSE.

LEAHI-TD-FIRMWARE-LDT-473-1 02 Dec 2025

Thanks for catching that. Yes, this was an accidental change on my part. I’ll revert it and proceed with deleting ModeTxParams.c and the related header files as suggested.