•  

Comment Results

Review Name Created Custom Fields Content
LEAHI-TD-FIRMWARE-LDT-4063-1 09 Jun 2026

Change PRES_OCCL to PRESSURE

LEAHI-TD-FIRMWARE-LDT-3975-1 28 May 2026

Why isn't this TRUE == ?

LEAHI-DD-FIRMWARE-LDT-618-2 04 Dec 2025

Yeah, I removed this.

LEAHI-TESTSUITES-LDT-2278-1 05 Dec 2025

Moved this function into utility.py file

LEAHI-TESTSUITES-LDT-2278-1 05 Dec 2025

removed the waits as per suggestion

LEAHI-TESTSUITES-LDT-1078-1 03 Dec 2025

ive noticed this common method being used in other test cases. If its a general method that is used throughout please move outside in a shared file and call from there. Please update other repositories that use this as well.

LEAHI-TESTSUITES-LDT-2174-1 02 Dec 2025

why 10 second wait? We shouldnt need any additional delays. If you need a delay or wait for an object we should better be using waitForObject()

LEAHI-TD-FIRMWARE-LDT-4033-1 10 Jun 2026

Fixed

LEAHI-TD-FIRMWARE-LDT-473-1 05 Dec 2025

Updated

LEAHI-TD-FIRMWARE-LDT-473-1 05 Dec 2025

Updated

LEAHI-TESTSUITES-LDT-2174-1 07 Dec 2025

Comment block is added to all the functions

LEAHI-DD-FIRMWARE-LDT-4410-3 29 Jul 2026

Add comment

LEAHI-DD-FIRMWARE-LDT-4001-1 11 Jun 2026

Is this a rate too?

LEAHI-DD-FIRMWARE-LDT-4001-1 11 Jun 2026

pumpTargetRate

LEAHI-DD-FIRMWARE-LDT-4001-1 11 Jun 2026

Is currentPumpSpeed also a rate? If not, we're subtracting a speed from a rate which doesn't make much sense.

LEAHI-APPLICATION-LDT-2957-1 10 Dec 2025

updated to statusColor

LEAHI-TD-FIRMWARE-LDT-4033-1 28 May 2026

use ternary to make TRUE or FALSE.

LEAHI-TD-FIRMWARE-LDT-4033-1 27 May 2026

nextState is the return value.
Should we add requestAdultBPMeasurement, bpMeasurementReady and bpDriverError to outputs?

LEAHI-TESTSUITES-LDT-1802-1 10 Dec 2025

all the test cases need ot be listed here. Only add on your new test case and do not remove the others

LEAHI-DD-FIRMWARE-LDT-4410-3 29 Jul 2026

Also need a function for Spent side only open for drain

LEAHI-TESTSUITES-LDT-2174-1 11 Dec 2025

Removed the commented lines

LEAHI-DD-FIRMWARE-LDT-2185-1 11 Dec 2025

What are these coefficients for? At least describe in comments, if not the names.

LEAHI-DD-FIRMWARE-LDT-2185-1 11 Dec 2025

Update FP_Pre_GenP_Def_Mode_States enum in FPDefs.h

LEAHI-TESTSUITES-LDT-2278-1 11 Dec 2025

instead of wait wait for o_vitalCountdown_Text property to be visible

LEAHI-DD-FIRMWARE-LDT-2004-2 16 Dec 2025

As per Sean's comment mark it as resolved

LEAHI-DD-FIRMWARE-LDT-5209-1 30 Jul 2026

Same here adding 'bicarbChamberPregenFillRequested' flag.

LEAHI-TD-FIRMWARE-LDT-473-1 16 Dec 2025

Updated.

LEAHI-DD-FIRMWARE-LDT-2185-1 12 Dec 2025

No need to initialize these to zero.

LEAHI-TD-FIRMWARE-LDT-4031-1 30 Jul 2026

Make a #define up top for the 5.

LEAHI-APPLICATION-LDT-3000-1 17 Dec 2025

only run when visible

LEAHI-APPLICATION-LDT-2825-1 17 Dec 2025

loook into font size of settings screen and pretreatment. Fix insititual labelunit container font sizes too

LEAHI-DD-FIRMWARE-LDT-2004-3 15 Dec 2025

This function has an output.

LEAHI-TESTSUITES-LDT-1454-1 03 Dec 2025

can we make this a more general method and put in a shared file and update throughout.. update to something like

def setObjectText(obj, text):
    obj["text"] = text
    return obj:
LEAHI-DD-FIRMWARE-LDT-2185-1 18 Dec 2025

FPFilterFlushDefeatured.

LEAHI-TESTSUITES-LDT-3427-1 30 Jul 2026

remove commented out line

LEAHI-RO-FIRMWARE-LDT-2116-1 18 Dec 2025

roRejectionRatioTankFill is an input.

LEAHI-RO-FIRMWARE-LDT-2116-1 18 Dec 2025

Update inputs/outputs.

LEAHI-DD-FIRMWARE-LDT-2936-1 02 Dec 2025

Fixed.

LEAHI-TD-FIRMWARE-LDT-473-1 02 Dec 2025

No need to initialize here as it is initialized in init function. Also, need to add a doxygen comment to the right of this line.

LEAHI-TESTSUITES-LDT-2278-1 11 Dec 2025

This never happens because the interval doesnt hit 0 in the test.. I would suggest settings timeout to 5 min and waiting listening in a loop for 5 min to get the request.. look into can_interface.register_receiving_publication_function() to listen for a message from UI

LEAHI-DD-FIRMWARE-LDT-3272-1 27 May 2026

Done

LEAHI-DD-FIRMWARE-LDT-3272-1 27 May 2026

This file has been updated by HALCoGen automatically.

LEAHI-TD-FIRMWARE-LDT-473-1 16 Dec 2025

Yes, we need to

LEAHI-TD-FIRMWARE-LDT-4013-1 20 May 2026

only 1 return statement

LEAHI-DD-FIRMWARE-LDT-2185-1 12 Dec 2025

fixed it

LEAHI-DD-FIRMWARE-LDT-2936-1 02 Dec 2025

as a practice , we need to add a pragma pack for all structure irrespective of the size as per Sean.

LEAHI-DD-FIRMWARE-LDT-4001-1 01 Jun 2026

Update alarms and Input/Output sections.

LEAHI-TD-FIRMWARE-LDT-4009-1 01 Jun 2026

Maintain alphabetical order.

LEAHI-DD-FIRMWARE-LDT-618-2 04 Dec 2025

Removed

LEAHI-TD-FIRMWARE-LDT-473-1 08 Dec 2025

Updated