•  

Comment Results

Review Name Created Custom Fields Content
LEAHI-DD-FIRMWARE-LDT-4410-3 29 Jul 2026

Could you please move 10.0F aligned to the rest of the declaration. I see Drybicart persistence duration (500ms) is as well not aligned.

LEAHI-DD-FIRMWARE-LDT-4410-3 29 Jul 2026

this variable is removed now ,

LEAHI-TD-FIRMWARE-LDT-4029-1 30 Jul 2026

Set "Stops" property back to TRUE like the other reserved UI alarms.

LEAHI-DD-FIRMWARE-LDT-2936-1 04 Dec 2025

Put first condition in () too.

LEAHI-DD-FIRMWARE-LDT-618-2 03 Dec 2025

Add space between if and (.

LEAHI-DD-FIRMWARE-LDT-618-2 03 Dec 2025

Add one more blank line here. Should be 2 blank lines above and 2 below this banner.

LEAHI-TESTSUITES-LDT-1036-1 05 Dec 2025

Now using setText(obj, text) method and moved to configuration folder utility.py file

LEAHI-DD-FIRMWARE-LDT-2030-2 10 Dec 2025

If it is not used for serial message, its OK, but if you are opting for packing , club it together , in line number 36 , or bring that structure defined on top to here

LEAHI-TESTSUITES-LDT-2278-1 05 Dec 2025

As per previous test script removed this function and using set_property_text method

LEAHI-TD-FIRMWARE-LDT-473-1 02 Dec 2025

I don't think we need to check for rejected here. If we rejected params, UI will have to send us new params until we accept them.

LEAHI-TD-FIRMWARE-LDT-473-1 02 Dec 2025

Remove extra blank line.

LEAHI-DIALIN-LDT-618-1 08 Dec 2025

Remove the old 0xA008. There can only be one message ID.

LEAHI-TESTSUITES-LDT-1078-1 05 Dec 2025

Not a comment to be done right now.
But better to create arrays of test data on top of the function/file, loop through them, and call the function (verify_td_and_dd_versions) to use those.
So we can more easily add multiple test data cases later to cover more edge cases.

LEAHI-TD-FIRMWARE-LDT-473-1 05 Dec 2025

Removed

LEAHI-TESTSUITES-LDT-2278-1 03 Dec 2025

moved to shared file and update to have the object as a parameter

LEAHI-DD-FIRMWARE-LDT-2936-1 09 Dec 2025

Fixed the ordering

LEAHI-DD-FIRMWARE-LDT-2185-1 11 Dec 2025

Be consistent on whether you have a blank line between break and next case.

LEAHI-APPLICATION-LDT-2957-1 10 Dec 2025

added

LEAHI-TESTSUITES-LDT-2278-1 11 Dec 2025

Renamed the function setObjectText

LEAHI-DD-FIRMWARE-LDT-1773-1 12 Dec 2025

fixed. thanks!

LEAHI-TD-FIRMWARE-LDT-1886-1 17 Dec 2025

Done

LEAHI-TESTSUITES-LDT-2174-1 05 Dec 2025

for consistency with all the other branches please use setObjectText isntead.

LEAHI-TESTSUITES-LDT-2174-1 04 Dec 2025

rename to set_property_text()

LEAHI-APPLICATION-LDT-2727-1 10 Dec 2025

No Action For Now:
Same for the vError param:
https://devapps.diality.us/cru/#LEAHI-APPLICATION-LDT-2727-1CFR-76762

LEAHI-DD-FIRMWARE-LDT-2185-1 12 Dec 2025

updated

LEAHI-DD-FIRMWARE-LDT-2185-1 12 Dec 2025

fixed it

LEAHI-RO-FIRMWARE-LDT-2116-1 18 Dec 2025

Add message for Reject Ratio data.

LEAHI-DD-FIRMWARE-LDT-2185-1 11 Dec 2025

Handle transition here after changing the flush logic

transitionToGenPermeateDefeaturedMode();
requestGenWaterDefStart();

LEAHI-TD-FIRMWARE-LDT-473-1 09 Dec 2025

I didn't see this in header file.

LEAHI-DD-FIRMWARE-LDT-2004-2 18 Nov 2025

it should test all the cases like for example

if (written >= 0 && written < sizeof(buffer))

Unknown macro: { // Success the string was fully written and null-terminated }

else if (written >= sizeof(buffer))

Unknown macro: { // The output was truncated. handle as needed }

else

Unknown macro: { // An encoding error occurred }
LEAHI-RO-FIRMWARE-LDT-2116-1 18 Dec 2025

Update inputs/outputs.

LEAHI-TD-FIRMWARE-LDT-1886-1 16 Dec 2025

Declarations should be at top of scope.

LEAHI-APPLICATION-LDT-3000-1 17 Dec 2025

remove lock diasbaled

LEAHI-TESTSUITES-LDT-2174-1 11 Dec 2025

Removed the function and using setObjectText

LEAHI-DD-FIRMWARE-LDT-3272-1 27 May 2026

Non-Dialin messages should be higher in this list than Dialin messages. Move this above all of the "test" handlers.

LEAHI-APPLICATION-LDT-2957-1 10 Dec 2025

What is this file used for?
And please add a brief description for the file comment.

LEAHI-DD-FIRMWARE-LDT-2936-1 03 Dec 2025

Handled in FPOperationModes and respective states of PreGen have it.

LEAHI-DD-FIRMWARE-LDT-3958-1 29 May 2026

Use ternary to explicitly assign TRUE or FALSE.

LEAHI-TESTSUITES-LDT-1650-1 05 Dec 2025

Now using setText(obj, text) method and moved to configuration folder utility.py file

LEAHI-TESTSUITES-LDT-1078-1 05 Dec 2025

Now findObjectById(parent, id): method is moved to configuration folder utility.py file

LEAHI-TESTSUITES-LDT-1650-1 05 Dec 2025

Now findObjectById(parent, id): method is moved to configuration folder utility.py file and get_aut_version(aut_path): method is moved to configuration folder application_init.py file

LEAHI-DD-FIRMWARE-LDT-4500-1 29 Jul 2026

Updated

LEAHI-TESTSUITES-LDT-3321-1 01 Jun 2026

can we rename this test case to tst_headerbar_settings_diagnostics_popup jsut so its clear what this test cast actually is

LEAHI-DD-FIRMWARE-LDT-1773-1 08 Dec 2025

Remove extra blank lines.

LEAHI-TESTSUITES-LDT-2174-1 05 Dec 2025

Steps have been updated -> After click on the button then from fw send the td_Treatment_Parameters_Validation

LEAHI-TESTSUITES-LDT-2278-1 03 Dec 2025

moved to shared file and update to have the object as a parameter

LEAHI-TESTSUITES-LDT-2278-1 03 Dec 2025

remove as this is already in the config.py

LEAHI-TD-FIRMWARE-LDT-4072-2 05 Jun 2026

Don't need min/max for this. Just use 0x0 and 0xFFFFFFFF where needed.

LEAHI-TESTSUITES-LDT-2278-1 08 Dec 2025

Removed this function and using set_Object_Text() function

LEAHI-TESTSUITES-LDT-1802-1 08 Dec 2025

removed the outer startSection and uploaded the new test report