•  

Comment Results

Review Name Created Custom Fields Content
LEAHI-DD-FIRMWARE-LDT-2004-3 04 Dec 2025

Remove extra blank line.

LEAHI-DIALIN-LDT-2998-1 18 Dec 2025

like D63 level sensor, please add D98 level sensor throughout the units. Keep naming as D98_LEVEL ( instead of D98_COND)

LEAHI-DD-FIRMWARE-LDT-2936-1 02 Dec 2025

Fixed.

LEAHI-DD-FIRMWARE-LDT-2936-1 02 Dec 2025

Fixed.

LEAHI-DD-FIRMWARE-LDT-618-2 04 Dec 2025

Noted.

LEAHI-DD-FIRMWARE-LDT-618-2 04 Dec 2025

( TRUE == isTestingActivated() ) && ( ovType != OVERRIDE_INVALID ) && ( ovType < NUM_OF_OVERRIDE_TYPES ) conditions are not needed because the override functions check them already.

LEAHI-DIALIN-LDT-4612-1 11 Jun 2026

Not in use, don't need to add

LEAHI-DD-FIRMWARE-LDT-2185-1 12 Dec 2025

fixed it

LEAHI-TESTSUITES-LDT-2278-1 05 Dec 2025

Removed all the waits

LEAHI-DD-FIRMWARE-LDT-618-2 04 Dec 2025

Typically we name this last one starting with "NUM_OF_" to help differentiate from the real enums (i.e. this one is just a count).

LEAHI-DD-FIRMWARE-LDT-618-2 04 Dec 2025

In comments, we don't need to call attention to the fact that these can be overridden. Their primary purpose is to be the TD supplied treatment parameters. The fact that they can be overridden by Dialin is just an extra. Just write a normal comment.

LEAHI-TESTSUITES-LDT-1036-1 03 Dec 2025

move this method outside to a shared functions file

LEAHI-TESTSUITES-LDT-2278-1 03 Dec 2025

remove waits

LEAHI-TD-FIRMWARE-LDT-4033-1 27 May 2026

Recommend command be a U08 here. Driver should have the enum and pass the enum to this function. FPGA should just take a byte.

LEAHI-DD-FIRMWARE-LDT-2004-3 08 Dec 2025

Done.

LEAHI-DIALIN-LDT-618-1 08 Dec 2025

Updated.

LEAHI-TD-FIRMWARE-LDT-3970-1 27 May 2026

Add a doxygen comment above this array (similar to structures).

LEAHI-DD-FIRMWARE-LDT-2185-1 12 Dec 2025

removed

LEAHI-SW-SCRIPTS-LDT-2727-1 10 Dec 2025

This does not entirely follow the standard.
But it is fine since we do not have the Bluetooth feature implemented yet.
Standard format example

HD-DENBUG-335-1 31 May 2026

No this comment is explaining what will happen at the bottom.

LEAHI-TD-FIRMWARE-LDT-4013-1 29 May 2026

rejReason = INVALID REQUEST FORMAT

LEAHI-DIALIN-LDT-618-1 08 Dec 2025

Update the message to 0xA008.

LEAHI-APPLICATION-LDT-2957-1 10 Dec 2025

pop(null) will unwind the stack and go back to main treatment. I tested and added a comment in code as well

LEAHI-APPLICATION-LDT-3000-1 18 Dec 2025

done

LEAHI-TESTSUITES-LDT-2278-1 10 Dec 2025

In stagin the function name is setObjectText please update to avoid conflicts

HD-DENBUG-335-1 01 Jun 2026

RESOLVED in CODE WALKTHROUGH

LEAHI-DD-FIRMWARE-LDT-2185-1 12 Dec 2025

added

LEAHI-APPLICATION-LDT-2727-1 10 Dec 2025

No Action For Now:
Please always use mError, since it is local to the script function, to be consistent with the rest.
Also, usually it is a number, not a bool.

It is fine for now, but later we should create a decorator to cover these types of similarities.

LEAHI-DD-FIRMWARE-LDT-2185-1 12 Dec 2025

added comments

LEAHI-DD-FIRMWARE-LDT-2185-1 11 Dec 2025

Add space before ).

LEAHI-DD-FIRMWARE-LDT-4001-1 01 Jun 2026

fixed

LEAHI-RO-FIRMWARE-LDT-2116-1 18 Dec 2025

Update inputs/outputs.

HD-DENBUG-335-1 04 Jun 2026

Done

LEAHI-DD-FIRMWARE-LDT-2185-1 16 Dec 2025

Fixed

LEAHI-TD-FIRMWARE-LDT-1886-1 16 Dec 2025

No. It is permanent, I would like to know the value for the homing.

LEAHI-DD-FIRMWARE-LDT-2185-1 12 Dec 2025

implement an API in RinsePump and call that API.

LEAHI-TD-FIRMWARE-LDT-4033-1 27 May 2026

We should initialize this in init functions.

LEAHI-DIALIN-LDT-4612-1 11 Jun 2026

Rename to CanChannels

LEAHI-DD-FIRMWARE-LDT-4410-3 29 Jul 2026

yes we need to check band 4. it was a mistake

LEAHI-TD-FIRMWARE-LDT-4063-1 29 Jul 2026

Move buttons down just above "Comm.h". And why is buttons being included here?

LEAHI-DD-FIRMWARE-LDT-4410-3 29 Jul 2026

added

LEAHI-DD-FIRMWARE-LDT-4410-3 29 Jul 2026

could you please arrange Fresh side and Spend side valve together ?

LEAHI-DIALIN-LDT-1886-2 18 Dec 2025

Aren't these fields are for 4 byte range? The integer is just 1 byte

LEAHI-APPLICATION-LDT-3046-1 17 Dec 2025

change title to "Feature Configurations" and put items below all plus RO

LEAHI-APPLICATION-LDT-3000-1 17 Dec 2025

same as above

LEAHI-APPLICATION-LDT-2825-1 17 Dec 2025

Use PROPERTY

LEAHI-APPLICATION-LDT-2825-1 17 Dec 2025

add "..." for ocntinuatoin

LEAHI-TESTSUITES-LDT-2278-1 11 Dec 2025

responses are only after requests. Manually entering vitals is not a request so a response from FW will never hapen. This test is invalid.

Please Update to request first then reject when popup is open and that will satisfy https://devapps.diality.us/cru/LEAHI-TESTSUITES-LDT-2278-1#c25754

LEAHI-RO-FIRMWARE-LDT-2116-1 18 Dec 2025

roRejectionRatio is an input.

LEAHI-DD-FIRMWARE-LDT-2936-1 02 Dec 2025

Fixed.